search for: backup_dir_buf

https://bugzilla.samba.org/show_bug.cgi?id=7869 Summary: rsync segfault Product: rsync Version: 3.0.7 Platform: x64 OS/Version: Linux Status: NEW Severity: minor Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: rafa.silva at gmail.com QAContact: rsync-qa at

Dear All, I have been seeing some strange behavior using rsync 3.1.1 on OSX with the 3 standard patches applied when using the --backup and --backup-Dir options. This works as expected on 3.0.9, moving any files on dest that are not on source to the backup folder. If no changes then the backup folder is not even created. -aHAXN --fileflags --force-change --protect-decmpfs ?delete --backup

...sync instead of making screwy directories. This is my diff, assuming one runs fileflags, crtimes, and hfs_compression diffs first for OSX and rsync 3.1.1. Rob diff --git a/backup.c b/backup.c --- a/backup.c +++ b/--- a/backup.c @@ -65,6 +65,9 @@ BOOL ret = True; stat_x sx; char *b, *rel = backup_dir_buf + backup_dir_len, *name = rel; + + if (x_lstat(fname, &sx.st, NULL) < 0) + return 1; for (f = fname, b = rel; *f && *f == *b; f++, b++) { if (*b == '/') @@ -215,17 +218,18 @@ stat_x sx; struct file_struct *file; int save_preserve_xattrs; - char *buf = get...

Dear rsync folks, I'd like to request/suggest that cli options to set TCP send/receive buffers be added to rsync client-side. Summary: I'm aware that a daemon's config-file can set socket options for the server side (e.g. SO_SNDBUF, SO_RCVBUF). That is useful. But when trying to get high-throughput rsync over long paths (i.e. large bandwidth*delay product), since

...-------------------------------------- *** work/rsync-3.0.7/options.c.orig 2009-12-22 00:40:41.000000000 +0200 --- work/rsync-3.0.7/options.c 2010-07-09 15:16:22.000000000 +0300 *************** *** 165,170 **** --- 165,171 ---- char *rsync_path = RSYNC_PATH; char *backup_dir = NULL; char backup_dir_buf[MAXPATHLEN]; + long check_point = -1; char *sockopts = NULL; int rsync_port = 0; int compare_dest = 0; *************** *** 325,330 **** --- 326,332 ---- rprintf(F," -b, --backup make backups (see --suffix & --backup-dir)\n"); rprintf(F," --backup-...

...&modify_window, OPT_MODIFY_WINDOW, 0, 0 }, {"super", 0, POPT_ARG_VAL, &am_root, 2, 0, 0 }, {"no-super", 0, POPT_ARG_VAL, &am_root, 0, 0, 0 }, @@ -1285,6 +1288,9 @@ "P *%s", backup_suffix); parse_rule(&filter_list, backup_dir_buf, 0, 0); } + + if (omit_dir_changes) + omit_dir_times = 2; if (make_backups && !backup_dir) omit_dir_times = 1; @@ -1513,6 +1519,8 @@ argstr[x++] = 'm'; if (omit_dir_times == 2) argstr[x++] = 'O'; + if (omit_dir_changes == 1) + args[ac++] = "--omi...

...t/popthelp.o popt/poptparse.o patchwork diff options.c --- options.c 2004-02-23 10:22:51.000000000 -0500 +++ options.c 2004-02-23 10:29:14.000000000 -0500 @@ -119,6 +119,7 @@ char *password_file = NULL; char *rsync_path = RSYNC_PATH; char *backup_dir = NULL; +char *link_by_hash_dir = NULL; char backup_dir_buf[MAXPATHLEN]; int rsync_port = RSYNC_PORT; int link_dest = 0; @@ -264,6 +265,7 @@ rprintf(F," -T --temp-dir=DIR create temporary files in directory DIR\n"); rprintf(F," --compare-dest=DIR also compare destination files relative to DIR\n"); rprintf(F,...

...t/popthelp.o popt/poptparse.o patchwork diff options.c --- options.c 2004-02-17 10:36:44.000000000 -0500 +++ options.c 2004-02-17 10:36:44.000000000 -0500 @@ -119,6 +119,7 @@ char *password_file = NULL; char *rsync_path = RSYNC_PATH; char *backup_dir = NULL; +char *link_by_hash_dir = NULL; char backup_dir_buf[MAXPATHLEN]; int rsync_port = RSYNC_PORT; int link_dest = 0; @@ -264,6 +265,7 @@ rprintf(F," -T --temp-dir=DIR create temporary files in directory DIR\n"); rprintf(F," --compare-dest=DIR also compare destination files relative to DIR\n"); rprintf(F,...

...t/popthelp.o popt/poptparse.o patchwork diff options.c --- options.c 2004-02-23 10:22:51.000000000 -0500 +++ options.c 2004-02-23 10:29:14.000000000 -0500 @@ -119,6 +119,7 @@ char *password_file = NULL; char *rsync_path = RSYNC_PATH; char *backup_dir = NULL; +char *link_by_hash_dir = NULL; char backup_dir_buf[MAXPATHLEN]; int rsync_port = RSYNC_PORT; int link_dest = 0; @@ -264,6 +265,7 @@ rprintf(F," -T --temp-dir=DIR create temporary files in directory DIR\n"); rprintf(F," --compare-dest=DIR also compare destination files relative to DIR\n"); rprintf(F,...

...t/popthelp.o popt/poptparse.o patchwork diff options.c --- options.c 2004-02-16 10:24:37.000000000 -0500 +++ options.c 2004-02-16 11:26:27.000000000 -0500 @@ -119,6 +119,7 @@ char *password_file = NULL; char *rsync_path = RSYNC_PATH; char *backup_dir = NULL; +char *link_by_hash_dir = NULL; char backup_dir_buf[MAXPATHLEN]; int rsync_port = RSYNC_PORT; int link_dest = 0; @@ -264,6 +265,7 @@ rprintf(F," -T --temp-dir=DIR create temporary files in directory DIR\n"); rprintf(F," --compare-dest=DIR also compare destination files relative to DIR\n"); rprintf(F,...

...\ popt/popthelp.o popt/poptparse.o diff -rupNP rsync-2.6.2/options.c rsync-2.6.2-fnameconv.clean/options.c --- rsync-2.6.2/options.c 2004-04-17 20:07:23.000000000 +0300 +++ rsync-2.6.2-fnameconv.clean/options.c 2004-05-29 21:17:09.000000000 +0300 @@ -124,6 +124,7 @@ char *backup_dir = NULL; char backup_dir_buf[MAXPATHLEN]; int rsync_port = RSYNC_PORT; int link_dest = 0; +char *fname_convert_cmd = NULL; int verbose = 0; int quiet = 0; @@ -290,6 +291,7 @@ void usage(enum logcode F) rprintf(F," --bwlimit=KBPS limit I/O bandwidth, KBytes per second\n"); rprintf(F,"...

...tion in primary source file extern int backup_dir_len; ^ backup.c(26): remark #1419: external declaration in primary source file extern unsigned int backup_dir_remainder; ^ backup.c(27): remark #1419: external declaration in primary source file extern char backup_dir_buf[MAXPATHLEN]; ^ backup.c(28): remark #1419: external declaration in primary source file extern char *backup_suffix; ^ backup.c(29): remark #1419: external declaration in primary source file extern char *backup_dir; ^ backup.c(31): remark #1419: exte...