Displaying 20 results from an estimated 83 matches for "backingformat".
2017 Jun 25
0
Re: [PATCH 1/2] launch: add support for autodetection of appliance image format
...rtions(+), 8 deletions(-)
>
> diff --git a/lib/create.c b/lib/create.c
> index bd4c32ef7..aedfe8670 100644
> --- a/lib/create.c
> +++ b/lib/create.c
> @@ -272,7 +272,8 @@ disk_create_qcow2 (guestfs_h *g, const char *orig_filename, int64_t size,
> */
> if (STRNEQ (backingformat, "raw") &&
> STRNEQ (backingformat, "qcow2") &&
> - STRNEQ (backingformat, "vmdk")) {
> + STRNEQ (backingformat, "vmdk") &&
> + STRNEQ (backingformat, AUTODETECTION_FORMAT)) {
> error...
2014 Nov 23
0
[PATCH 1/3] lib: guestfs_disk_create: Allow vmdk as a valid backingformat.
...changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/create.c b/src/create.c
index 621ace5..bfb8b76 100644
--- a/src/create.c
+++ b/src/create.c
@@ -261,7 +261,12 @@ disk_create_qcow2 (guestfs_h *g, const char *orig_filename, int64_t size,
if (optargs->bitmask & GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK) {
backingformat = optargs->backingformat;
- if (STRNEQ (backingformat, "raw") && STRNEQ (backingformat, "qcow2")) {
+ /* Conservative whitelist. This can be extended with other
+ * valid formats as required.
+ */
+ if (STRNEQ (backingfo...
2020 Feb 06
3
[PATCH] lib: Autodetect backing format and specify it explicitly.
In the guestfs_disk_create API we have traditionally allowed you to
set backingfile without setting backingformat. The meaning of this is
to let qemu autodetect the backing format when opening the overlay
disk.
However libvirt >= 6.0 refuses to even pass such disks to qemu (see
https://bugzilla.redhat.com/show_bug.cgi?id=1798148).
For this reason, move the autodetection earlier and make it explicit.
We n...
2020 Mar 09
3
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote:
> On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote:
> > In the guestfs_disk_create API we have traditionally allowed you to
> > set backingfile without setting backingformat. The meaning of this is
> > to let qemu autodetect the backing format when opening the overlay
> > disk.
> >
> > However libvirt >= 6.0 refuses to even pass such disks to qemu (see
> > https://bugzilla.redhat.com/show_bug.cgi?id=1798148).
> >
> > For...
2017 Jun 08
1
[PATCH] lib: create: Allow any [[:alnum:]]+ string as a backingfmt parameter.
If you use the libguestfs tools which open disk images read-only
(eg. virt-df), with formats such as 'vdi', then you will see an error:
error: invalid value for backingformat parameter 'vdi'
This is because opening a disk image read-only will try to create a
qcow2 file with the original image as a backing file. However the
list of permitted backing formats was very restrictive and did not
include 'vdi' (nor many other uncommon formats).
Instead of usi...
2020 Mar 09
2
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...ote:
> > On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote:
> > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote:
> > > > In the guestfs_disk_create API we have traditionally allowed you to
> > > > set backingfile without setting backingformat. The meaning of this is
> > > > to let qemu autodetect the backing format when opening the overlay
> > > > disk.
> > > >
> > > > However libvirt >= 6.0 refuses to even pass such disks to qemu (see
> > > > https://bugzilla.redhat.com/s...
2018 Aug 22
1
[PATCH] lib: create: avoid one extra string allocation
...ow2 (guestfs_h *g, const char *orig_filename, int64_t size,
+disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
const char *backingfile,
const struct guestfs_disk_create_argv *optargs)
{
- CLEANUP_FREE char *filename = NULL;
const char *backingformat = NULL;
const char *preallocation = NULL;
const char *compat = NULL;
@@ -263,16 +262,6 @@ disk_create_qcow2 (guestfs_h *g, const char *orig_filename, int64_t size,
CLEANUP_CMD_CLOSE struct command *cmd = guestfs_int_new_command (g);
int r;
- /* If the filename is something like "...
2020 Mar 09
0
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote:
> In the guestfs_disk_create API we have traditionally allowed you to
> set backingfile without setting backingformat. The meaning of this is
> to let qemu autodetect the backing format when opening the overlay
> disk.
>
> However libvirt >= 6.0 refuses to even pass such disks to qemu (see
> https://bugzilla.redhat.com/show_bug.cgi?id=1798148).
>
> For this reason, move the autodetection...
2014 Nov 23
7
[PATCH 0/3] patches needed for virt-bmap
See http://rwmj.wordpress.com/2014/11/23/mapping-files-to-disk/
2020 Mar 09
0
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...ichard W.M. Jones wrote:
> On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote:
> > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote:
> > > In the guestfs_disk_create API we have traditionally allowed you to
> > > set backingfile without setting backingformat. The meaning of this is
> > > to let qemu autodetect the backing format when opening the overlay
> > > disk.
> > >
> > > However libvirt >= 6.0 refuses to even pass such disks to qemu (see
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1798148)....
2020 Mar 09
0
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...On Mon, Mar 09, 2020 at 11:07:20AM +0100, Pino Toscano wrote:
> > > > On Thursday, 6 February 2020 18:20:19 CET Richard W.M. Jones wrote:
> > > > > In the guestfs_disk_create API we have traditionally allowed you to
> > > > > set backingfile without setting backingformat. The meaning of this is
> > > > > to let qemu autodetect the backing format when opening the overlay
> > > > > disk.
> > > > >
> > > > > However libvirt >= 6.0 refuses to even pass such disks to qemu (see
> > > > > http...
2014 Jan 28
11
[PATCH 00/10] New API: disk-create for creating blank disks.
A lot of code runs 'qemu-img create' or 'truncate' to create blank
disk images.
In the past I resisted adding an API to do this, since it essentially
duplicates what you can already do using other tools (ie. qemu-img).
However this does simplify calling code quite a lot since qemu-img is
somewhat error-prone to use (eg: don't try to create a disk called
"foo:bar")
2016 Nov 30
0
[PATCH] v2v: -o vdsm, -o rhev: Don't create compat=0.10 images;
...eate" () in
- (* For qcow2, override v2v-supplied compat option, because RHEL 6
- * nodes cannot handle qcow2 v3 (RHBZ#1145582).
- *)
- let compat = if format <> "qcow2" then compat else Some "0.10" in
g#disk_create ?backingfile ?backingformat ?preallocation ?compat
?clustersize path format size;
(* Make it sufficiently writable so that possibly root, or
diff --git a/v2v/output_vdsm.ml b/v2v/output_vdsm.ml
index 7cd94c0..92ce5c0 100644
--- a/v2v/output_vdsm.ml
+++ b/v2v/output_vdsm.ml
@@ -145,16 +145,6 @@ object...
2019 Mar 29
2
guestfish Remote Images IPv6 Support
...fs: trace: get_tmpdir
libguestfs: trace: get_tmpdir = "/tmp"
libguestfs: trace: disk_create "/tmp/libguestfs3pGMi6/overlay1.qcow2"
"qcow2" -1
"backingfile:rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none"
"backingformat:raw"
libguestfs: command: run: qemu-img
libguestfs: command: run: \ create
libguestfs: command: run: \ -f qcow2
libguestfs: command: run: \ -o
backing_file=rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none,backing_fmt=raw
libguestfs: command: run:...
2019 Apr 01
2
Re: guestfish Remote Images IPv6 Support
...t;server:tcp:[fd00::cefc:1]:6789"
> This is probably where it goes wrong:
>
>> "/tmp/libguestfs3pGMi6/overlay1.qcow2" "qcow2" -1 "backingfile:rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none"
>> "backingformat:raw"
>> libguestfs: command: run: \ -o backing_file=rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none,backing_fmt=raw
>> libguestfs: command: run: \ /tmp/libguestfs3pGMi6/overlay1.qcow2
>> qemu-img: /tmp/libguestfs3pGMi6/overlay1.q...
2016 Aug 02
0
[PATCH] launch: libvirt: Autodetect backing format for drive overlays (RHBZ#1354335).
..._int_lazy_make_tmpdir (g) == -1)
return NULL;
@@ -176,10 +222,8 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK;
optargs.backingfile = backing_drive;
- if (format) {
- optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK;
- optargs.backingformat = format;
- }
+ optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK;
+ optargs.backingformat = format;
if (guestfs_disk_create_argv (g, overlay, "qcow2", -1, &optargs) == -1) {
free (overlay);
@@ -196,13 +240,18 @@ create_cow_o...
2020 Feb 06
1
Re: [PATCH v2] launch: add support for autodetection of appliance image format
...mpdir (g) == -1)
> return NULL;
>
> @@ -232,8 +231,10 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
>
> optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK;
> optargs.backingfile = backing_drive;
> - optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK;
> - optargs.backingformat = format;
> + if (format) {
> + optargs.bitmask |= GUESTFS_DISK_CREATE_BACKINGFORMAT_BITMASK;
> + optargs.backingformat = format;
> + }
>
> if (guestfs_disk_create_argv (g, overlay, "qcow2", -1, &optargs) == -1) {
&...
2019 Apr 01
1
Re: guestfish Remote Images IPv6 Support
...race: get_tmpdir = "/root/libguestfs/tmp"
libguestfs: trace: disk_create
"/root/libguestfs/tmp/libguestfs9gclsg/overlay1.qcow2" "qcow2" -1
"backingfile:rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00\:\:cefc\:1]\:6789:auth_supported=none"
"backingformat:raw"
libguestfs: command: run: qemu-img
libguestfs: command: run: \ create
libguestfs: command: run: \ -f qcow2
libguestfs: command: run: \ -o
backing_file=rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00\:\:cefc\:1]\:6789:auth_supported=none,backing_fmt=raw
libguestfs: command: ru...
2019 Apr 01
2
Re: guestfish Remote Images IPv6 Support
..."
>>> This is probably where it goes wrong:
>>>
>>>> "/tmp/libguestfs3pGMi6/overlay1.qcow2" "qcow2" -1 "backingfile:rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none"
>>>> "backingformat:raw"
>>>> libguestfs: command: run: \ -o backing_file=rbd:images/CentOS-7-x86_64-GenericCloud-1901:mon_host=[fd00::cefc:1]\:6789:auth_supported=none,backing_fmt=raw
>>>> libguestfs: command: run: \ /tmp/libguestfs3pGMi6/overlay1.qcow2
>>>> qemu-img: /tmp/lib...
2016 Dec 01
1
[PATCH v2] v2v: -o vdsm: Add --vdsm-compat-11 flag, -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).
...eate" () in
- (* For qcow2, override v2v-supplied compat option, because RHEL 6
- * nodes cannot handle qcow2 v3 (RHBZ#1145582).
- *)
- let compat = if format <> "qcow2" then compat else Some "0.10" in
g#disk_create ?backingfile ?backingformat ?preallocation ?compat
?clustersize path format size;
(* Make it sufficiently writable so that possibly root, or
diff --git a/v2v/output_vdsm.ml b/v2v/output_vdsm.ml
index 7cd94c0..fbddee8 100644
--- a/v2v/output_vdsm.ml
+++ b/v2v/output_vdsm.ml
@@ -30,6 +30,7 @@ type vdsm_param...