search for: backend_is_rot

...(b_next); } static int next_can_flush (void *nxdata) { - struct b_h *b_h = nxdata; - return backend_can_flush (b_h->b); + struct backend *b_next = nxdata; + return backend_can_flush (b_next); } static int next_is_rotational (void *nxdata) { - struct b_h *b_h = nxdata; - return backend_is_rotational (b_h->b); + struct backend *b_next = nxdata; + return backend_is_rotational (b_next); } static int next_can_trim (void *nxdata) { - struct b_h *b_h = nxdata; - return backend_can_trim (b_h->b); + struct backend *b_next = nxdata; + return backend_can_trim (b_next); } sta...

...= backend_can_fua (backend); + fl = backend_can_fua (top); if (fl == -1) return -1; if (fl) eflags |= NBD_FLAG_SEND_FUA; - fl = backend_can_flush (backend); + fl = backend_can_flush (top); if (fl == -1) return -1; if (fl) eflags |= NBD_FLAG_SEND_FLUSH; - fl = backend_is_rotational (backend); + fl = backend_is_rotational (top); if (fl == -1) return -1; if (fl) eflags |= NBD_FLAG_ROTATIONAL; /* multi-conn is useless if parallel connections are not allowed. */ - fl = backend_can_multi_conn (backend); + fl = backend_can_multi_conn (top); if (fl...

...connection *conn) - __attribute__((__nonnull__ (1, 2))); -extern int backend_can_write (struct backend *b, struct connection *conn) - __attribute__((__nonnull__ (1, 2))); -extern int backend_can_flush (struct backend *b, struct connection *conn) - __attribute__((__nonnull__ (1, 2))); -extern int backend_is_rotational (struct backend *b, struct connection *conn) - __attribute__((__nonnull__ (1, 2))); -extern int backend_can_trim (struct backend *b, struct connection *conn) - __attribute__((__nonnull__ (1, 2))); -extern int backend_can_zero (struct backend *b, struct connection *conn) - __attribute__((_...

v1 was here: https://www.redhat.com/archives/libguestfs/2020-February/msg00081.html v2 replaces struct connection *conn = GET_CONN; with GET_CONN; which sets conn implicitly and asserts that it is non-NULL. If we actually want to test if conn is non-NULL or behave differently, then you must use threadlocal_get_conn() instead, and some existing uses do that. Rich.

The third patch is a large but mechanical change which gets rid of passing around struct connection * entirely within the server, preferring instead to reference the connection through thread-local storage. I hope this is a gateway to simplifying other parts of the code. Rich.

...- struct backend *b_next = nxdata; - return backend_can_write (b_next); -} - -static int -next_can_flush (void *nxdata) -{ - struct backend *b_next = nxdata; - return backend_can_flush (b_next); -} - -static int -next_is_rotational (void *nxdata) -{ - struct backend *b_next = nxdata; - return backend_is_rotational (b_next); -} - -static int -next_can_trim (void *nxdata) -{ - struct backend *b_next = nxdata; - return backend_can_trim (b_next); -} - -static int -next_can_zero (void *nxdata) -{ - struct backend *b_next = nxdata; - return backend_can_zero (b_next); -} - -static int -next_can_fast_zero...

...*b, struct connection *conn) { + struct b_conn_handle *h = &conn->handles[b->i]; + debug ("%s: can_flush", b->name); - return b->can_flush (b, conn); + if (h->can_flush == -1) + h->can_flush = b->can_flush (b, conn); + return h->can_flush; } int backend_is_rotational (struct backend *b, struct connection *conn) { + struct b_conn_handle *h = &conn->handles[b->i]; + debug ("%s: is_rotational", b->name); - return b->is_rotational (b, conn); + if (h->is_rotational == -1) + h->is_rotational = b->is_rotational (b,...

...t;, b->name); @@ -319,7 +319,7 @@ int backend_can_flush (struct backend *b) { GET_CONN; - struct b_conn_handle *h = &conn->handles[b->i]; + struct handle *h = get_handle (conn, b->i); controlpath_debug ("%s: can_flush", b->name); @@ -333,7 +333,7 @@ int backend_is_rotational (struct backend *b) { GET_CONN; - struct b_conn_handle *h = &conn->handles[b->i]; + struct handle *h = get_handle (conn, b->i); controlpath_debug ("%s: is_rotational", b->name); @@ -347,7 +347,7 @@ int backend_can_trim (struct backend *b) { GET_CON...

It's easy to use the sh script to demonstrate that nbdkit is inefficiently calling into .get_size, .can_fua, and friends more than necessary. We've also commented on the list in the past that it would be nice to ensure that when filters call into next_ops, they are not violating constraints (as we've have to fix several bugs in the past where we did not have such checking to protect

...handle; + assert (nxdata->b == b->next && nxdata->conn == conn); if (f->filter.is_rotational) - return f->filter.is_rotational (&next_ops, &nxdata, handle); + return f->filter.is_rotational (&next_ops, nxdata, nxdata->handle); else return backend_is_rotational (b->next, conn); } @@ -494,10 +520,11 @@ static int filter_can_trim (struct backend *b, struct connection *conn, void *handle) { struct backend_filter *f = container_of (b, struct backend_filter, backend); - struct b_conn nxdata = { .b = b->next, .conn = conn }; + struct b_conn...

This is a subset of the last half of the larger 9-patch series. The uncontroversial first half of that series is pushed, but here, I tried to reduce the size of the patches by splitting out some of the more complex changes, so that the rest of the changes remaining in the series are more mechanical. In turn, it forced me to write timing tests, which let me spot another spot where we are wasting

I think this is my last round of patches for issues I identified with the retry filter. With this in place, it should be safe to interject another filter in between retry and the plugin. Eric Blake (5): retry: Don't call into closed plugin tests: Refactor test-retry-reopen-fail.sh tests: Enhance retry test to cover failed reopen server: Move prepare/finalize/close recursion to

The immediate reason for this patch is to reduce the amount of debugging in virt-v2v with using the virt-v2v -v option (because this implies running nbdkit in verbose mode too). Most of the messages are datapath ones about pread/pwrite requests, and in fact as we've added more filters on top of nbdkit these messages have got more and more verbose. However they are not particularly

I still don't have .prepare/.finalize working cleanly across reopen, but did find a nasty bug where a botched assertion means we failed to notice reads beyond EOF in both the xz and retry filter. Refactoring backend.c will make .finalize work easier. Eric Blake (5): xz: Avoid reading beyond EOF retry: Check size before transactions tests: Test retry when get_size values change