search for: backend_is_libvirt

...ils then we carry - on and hope for the best. *) + permissions so can still access the resource. *) val error_if_no_ssh_agent : unit -> unit diff --git a/lib/utils.ml b/lib/utils.ml index 174c01b1e92f..7d69c9e0d177 100644 --- a/lib/utils.ml +++ b/lib/utils.ml @@ -149,21 +149,15 @@ let backend_is_libvirt () = let rec chown_for_libvirt_rhbz_1045069 file = let running_as_root = Unix.geteuid () = 0 in - if running_as_root && backend_is_libvirt () then ( - try - let user = Option.value ~default:"qemu" (libvirt_qemu_user ()) in - let uid = - if String.is_pref...

...l index a1b1dfa1e..545a8f5da 100644 --- a/v2v/input_libvirt_xen_ssh.ml +++ b/v2v/input_libvirt_xen_ssh.ml @@ -34,16 +34,16 @@ class input_libvirt_xen_ssh password libvirt_uri parsed_uri scheme server guest object inherit input_libvirt password libvirt_uri guest + method precheck () = + if backend_is_libvirt () then + error (f_"because of libvirt bug https://bugzilla.redhat.com/1140166 you must set this environment variable:\n\nexport LIBGUESTFS_BACKEND=direct\n\nand then rerun the virt-v2v command."); + error_if_libvirt_does_not_support_json_backingfile (); + error_if_no_ssh_agent...

...st. *) > + permissions so can still access the resource. *) > > val error_if_no_ssh_agent : unit -> unit > > diff --git a/lib/utils.ml b/lib/utils.ml > index 174c01b1e92f..7d69c9e0d177 100644 > --- a/lib/utils.ml > +++ b/lib/utils.ml > @@ -149,21 +149,15 @@ let backend_is_libvirt () = > > let rec chown_for_libvirt_rhbz_1045069 file = > let running_as_root = Unix.geteuid () = 0 in > - if running_as_root && backend_is_libvirt () then ( > - try > - let user = Option.value ~default:"qemu" (libvirt_qemu_user ()) in > - l...

...can still access the resource. *) >> >> val error_if_no_ssh_agent : unit -> unit >> >> diff --git a/lib/utils.ml b/lib/utils.ml >> index 174c01b1e92f..7d69c9e0d177 100644 >> --- a/lib/utils.ml >> +++ b/lib/utils.ml >> @@ -149,21 +149,15 @@ let backend_is_libvirt () = >> >> let rec chown_for_libvirt_rhbz_1045069 file = >> let running_as_root = Unix.geteuid () = 0 in >> - if running_as_root && backend_is_libvirt () then ( >> - try >> - let user = Option.value ~default:"qemu" (libvirt_qemu_u...

...gt;> > >> val error_if_no_ssh_agent : unit -> unit > >> > >> diff --git a/lib/utils.ml b/lib/utils.ml > >> index 174c01b1e92f..7d69c9e0d177 100644 > >> --- a/lib/utils.ml > >> +++ b/lib/utils.ml > >> @@ -149,21 +149,15 @@ let backend_is_libvirt () = > >> > >> let rec chown_for_libvirt_rhbz_1045069 file = > >> let running_as_root = Unix.geteuid () = 0 in > >> - if running_as_root && backend_is_libvirt () then ( > >> - try > >> - let user = Option.value ~default:&q...

...;> val error_if_no_ssh_agent : unit -> unit >>>> >>>> diff --git a/lib/utils.ml b/lib/utils.ml >>>> index 174c01b1e92f..7d69c9e0d177 100644 >>>> --- a/lib/utils.ml >>>> +++ b/lib/utils.ml >>>> @@ -149,21 +149,15 @@ let backend_is_libvirt () = >>>> >>>> let rec chown_for_libvirt_rhbz_1045069 file = >>>> let running_as_root = Unix.geteuid () = 0 in >>>> - if running_as_root && backend_is_libvirt () then ( >>>> - try >>>> - let user = Option...

...it a/v2v/input_libvirt_xen_ssh.ml b/v2v/input_libvirt_xen_ssh.ml index 4975eff..a68cdf8 100644 --- a/v2v/input_libvirt_xen_ssh.ml +++ b/v2v/input_libvirt_xen_ssh.ml @@ -38,6 +38,9 @@ object debug "input_libvirt_xen_ssh: source: scheme %s server %s" scheme server; + if backend_is_libvirt () then ( + error (f_"because of libvirt bug https://bugzilla.redhat.com/1434651 you must set this environment variable:\n\nexport LIBGUESTFS_BACKEND=direct\n\nand then rerun the virt-v2v command.") + ); error_if_libvirt_does_not_support_json_backingfile (); error_if_no_...

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024 v1 was here: <https://listman.redhat.com/archives/libguestfs/2023-June/031910.html>. Make any "chown_for_libvirt_rhbz_1045069" failure a hard one; that way the user gets to see more direct and more uniform error messages (namely that we couldn't connect to libvirt). Document those connection problems, and a simple

...Laszlo Ersek <lersek at redhat.com> --- Notes: v2: - new patch lib/utils.mli | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils.mli b/lib/utils.mli index 5687bf75867e..cf88a467fd54 100644 --- a/lib/utils.mli +++ b/lib/utils.mli @@ -62,7 +62,7 @@ val backend_is_libvirt : unit -> bool (** Return true iff the current backend is libvirt. *) val chown_for_libvirt_rhbz_1045069 : string -> unit -(** If running and root, and if the backend is libvirt, libvirt +(** If running as root, and if the backend is libvirt, libvirt will run qemu as a non-root user....

...ename = object +class input_vmx input_transport arg = object inherit input - method as_options = "-i vmx " ^ vmx_filename + method as_options = "-i vmx " ^ arg + + method precheck () = + match input_transport with + | None -> () + | Some `SSH -> + if backend_is_libvirt () then + error (f_"because libvirtd doesn't pass the SSH_AUTH_SOCK environment variable to qemu you must set this environment variable:\n\nexport LIBGUESTFS_BACKEND=direct\n\nand then rerun the virt-v2v command."); + error_if_no_ssh_agent () method source () = -...

...d. Thanks: Kun Wei. --- v2v/input_ova.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/v2v/input_ova.ml b/v2v/input_ova.ml index fb6b286..e80ec82 100644 --- a/v2v/input_ova.ml +++ b/v2v/input_ova.ml @@ -171,7 +171,8 @@ object *) if Unix.geteuid () = 0 && backend_is_libvirt () then ( warning (f_"making OVA directory public readable to work around libvirt bug https://bugzilla.redhat.com/1045069"); - let cmd = [ "chmod"; "-R"; "go=u,go-w"; exploded ] in + let cmd = [ "chmod"; "-R"; "go=u,g...

...input_libvirt_xen_ssh.ml > index 4975eff..a68cdf8 100644 > --- a/v2v/input_libvirt_xen_ssh.ml > +++ b/v2v/input_libvirt_xen_ssh.ml > @@ -38,6 +38,9 @@ object > debug "input_libvirt_xen_ssh: source: scheme %s server %s" > scheme server; > > + if backend_is_libvirt () then ( > + error (f_"because of libvirt bug https://bugzilla.redhat.com/1434651 you must set this environment variable:\n\nexport LIBGUESTFS_BACKEND=direct\n\nand then rerun the virt-v2v command.") > + ); LGTM if you amend the bug number to RHBZ#1140166 in commit log and...

...sh libvirt_conn input_password parsed_uri server guest = +class input_libvirt_xen_ssh libvirt_conn input_conn input_password parsed_uri server guest = object (self) - inherit input_libvirt libvirt_conn guest + inherit input_libvirt libvirt_conn ~input_conn guest method precheck () = if backend_is_libvirt () then diff --git a/v2v/input_libvirt_xen_ssh.mli b/v2v/input_libvirt_xen_ssh.mli index 120a52f7..3cbca9d7 100644 --- a/v2v/input_libvirt_xen_ssh.mli +++ b/v2v/input_libvirt_xen_ssh.mli @@ -18,4 +18,4 @@ (** [-i libvirt] when the source is Xen *) -val input_libvirt_xen_ssh : Libvirt.rw Libvir...

The first patch was previously posted here: https://www.redhat.com/archives/libguestfs/2017-December/msg00018.html That patch hasn't changed except that I made the ‘input_transport’ variable type-safe. The second patch adds a significant new mode for liberating data from VMware: the ability to copy VMs over SSH directly from ESXi hypervisors. Although this requires enabling SSH access (a

https://bugzilla.redhat.com/show_bug.cgi?id=1570407 This turned into quite an in-depth refactoring of how we handle OVAs. It also fixes a potential security issue. Rich.

Use -ip instead of --password-file, and various refactorings. It strikes me that we should probably deprecate and eventually remove virt-v2v-copy-to-local. With the introduction of the new SSH and VDDK transports, and with RHEL 5 Xen becoming more irrelevant, it's no longer needed. Rich.

This has to be applied on top of this series: https://www.redhat.com/archives/libguestfs/2017-March/msg00144.html This is a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1430680 Kun Wei noticed that virt-v2v -i ova has a problem if we are running as root and the OVA is not located on a path which is fully readable by non-root. The reason for this is that libvirt runs qemu as a

...class input_libvirt_xen_ssh input_conn input_password parsed_uri server guest = -object - inherit input_libvirt input_conn input_password guest +class input_libvirt_xen_ssh lazy_conn parsed_uri server guest = +object (self) + inherit input_libvirt lazy_conn guest method precheck () = if backend_is_libvirt () then @@ -43,12 +43,7 @@ object method source () = debug "input_libvirt_xen_ssh: source: server %s" server; - (* Get the libvirt XML. This also checks (as a side-effect) - * that the domain is not running. (RHBZ#1138586) - *) - let xml = Libvirt_utils.dumpxml ?...

Originally posted here: https://www.redhat.com/archives/libguestfs/2019-April/thread.html#00054 https://www.redhat.com/archives/libguestfs/2019-April/msg00076.html https://www.redhat.com/archives/libguestfs/2019-April/msg00126.html This is a rebase on top of current master branch with no other changes. The first patch in the old series was pushed a while back, and the last "TEMPORARY"

This series (except the last one) changes virt-v2v to use nbdkit for several input modes: -i vmx -it vddk: No change in functionality, as this already uses nbdkit-vddk-plugin, but the code is refactored for the other modes to use. -i libvirtxml: Use nbdkit-curl-plugin instead of qemu curl. vCenter: Use nbdkit-curl-plugin instead of qemu curl. xen: Use nbdkit-ssh-plugin instead of qemu