search for: b844bf5

...Reported-by: Richard W.M. Jones <rjones@redhat.com> Fixes: 7f5bb9bf13f041ea7702bda557d9dd668bc3423a Signed-off-by: Eric Blake <eblake@redhat.com> --- plugins/nbd/nbd.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index b844bf5..e79042c 100644 --- a/plugins/nbd/nbd.c +++ b/plugins/nbd/nbd.c @@ -311,6 +311,8 @@ nbd_reply_raw (struct handle *h, int *fd) struct reply rep; struct transaction **ptr; struct transaction *trans; + void *buf; + uint32_t count; *fd = -1; if (read_full (h->fd, &rep, sizeof r...

Hi Eric, There's a memory leak in the nbd client. The message (below) is not very useful because somehow debuginfo is missing in the plugin. However it's easily reproducible by doing: make check-valgrind TESTS=test-nbd I tried the attached patch to fix what I thought was the bug, but sadly the fix doesn't work for me :-( So I guess something else is going on, but it does look as

I tried reproducing the testsuite failure on test-parallel-*.sh using the same machine Rich posted a log from, but did not quickly hit it on a loop of make -j20 check TESTS=test-parallel-{file,nbd}.sh But I still think this series can't hurt. Eric Blake (2): nbd: Don't advertise writes if nbdkit is readonly tests: Make parallel tests more robust plugins/nbd/nbd.c | 2 ++

...at redhat.com> --- I'm still not sure why 'make check' passes while 'make check-valgrind' fails for TESTS=test-nbd, but this at least avoids the memory leak. plugins/nbd/nbd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c index b844bf5..425abe4 100644 --- a/plugins/nbd/nbd.c +++ b/plugins/nbd/nbd.c @@ -334,6 +334,7 @@ nbd_reply_raw (struct handle *h, int *fd) } *fd = trans->u.fds[1]; + free (trans); switch (be32toh (rep.error)) { case NBD_SUCCESS: if (trans->buf && read_full (h->fd, trans->b...

...l not sure why 'make check' passes while 'make check-valgrind' > fails for TESTS=test-nbd, but this at least avoids the memory leak. > > plugins/nbd/nbd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/plugins/nbd/nbd.c b/plugins/nbd/nbd.c > index b844bf5..425abe4 100644 > --- a/plugins/nbd/nbd.c > +++ b/plugins/nbd/nbd.c > @@ -334,6 +334,7 @@ nbd_reply_raw (struct handle *h, int *fd) > } > > *fd = trans->u.fds[1]; > + free (trans); > switch (be32toh (rep.error)) { > case NBD_SUCCESS: > if (trans-&...