search for: b541286

virt-sparsify shouldn't die if sparsifying a filesystem that contains read-only LVs. https://bugzilla.redhat.com/show_bug.cgi?id=1185561 I thought about trying to make the LV writable temporarily, but I suspect that if the sysadmin has made the LV read-only, then they probably did it for a reason, so we shouldn't touch it. Rich.

...if not (is_ignored fs) then ( + if not (is_ignored fs) && not (is_read_only_lv fs) then ( if List.mem fs zeroes then ( if not quiet then printf (f_"Zeroing %s ...\n%!") fs; diff --git a/sparsify/utils.ml b/sparsify/utils.ml index 4de7d08..b541286 100644 --- a/sparsify/utils.ml +++ b/sparsify/utils.ml @@ -22,9 +22,25 @@ open Printf open Common_utils +module G = Guestfs + let prog = Filename.basename Sys.executable_name let error ?exit_code fs = error ~prog ?exit_code fs let warning fs = warning ~prog fs let info fs = info ~prog fs...

...en ( > + if not (is_ignored fs) && not (is_read_only_lv fs) then ( > if List.mem fs zeroes then ( > if not quiet then > printf (f_"Zeroing %s ...\n%!") fs; > diff --git a/sparsify/utils.ml b/sparsify/utils.ml > index 4de7d08..b541286 100644 > --- a/sparsify/utils.ml > +++ b/sparsify/utils.ml > @@ -22,9 +22,25 @@ open Printf > > open Common_utils > > +module G = Guestfs > + > let prog = Filename.basename Sys.executable_name > let error ?exit_code fs = error ~prog ?exit_code fs > let warni...