search for: b516ea586d71

Przemysław Kopa reports that since commit b516ea586d71 ("PCI: Enable NVIDIA HDA controllers"), the discrete GPU Nvidia GeForce GT 540M on his 2011 Samsung laptop refuses to runtime suspend, resulting in a power regression and excessive heat. Rivera Valdez witnesses the same issue with a GeForce GT 525M (GF108M) of the same era, as does anoth...

...tive PCI bus, and pci_parent_bus_reset() does not work on busses which have more then a single device function present. So, fix this by simply calling pci_reset_bus() instead which properly resets the GPU bus and all device functions under it, including both the GPU and the HDA controller. Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") Cc: Lukas Wunner <lukas at wunner.de> Cc: Daniel Drake <drake at endlessm.com> Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Aaron Plattner <aplattner at nvidia.com> Cc: Peter Wu <peter at lekensteyn.nl> Cc: Ilia Mirkin...

Users kept complaining about those messages and it's a little spammy on prime systems so turn it into a debug print. Cc: Bjorn Helgaas <bhelgaas at google.com> Cc: Lukas Wunner <lukas at wunner.de> Cc: linux-pci at vger.kernel.org Cc: nouveau at lists.freedesktop.org Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 44cab813bf951..b10c77bbe4716 100644 --- a/driver...

This reverts commit b516ea586d717472178e6ef1c152e85608b0ce32. While this fixes audio for a number of users, this commit has the sideaffect of breaking the BIOS workaround that's required to make the GPU on the nvidia P50 work, by causing the GPU's PCI device function to stop working after it's been set to multifunctio...

...ion outside the purview of a driver, since I assume BIOS had some reason for hiding the HDA controller. > Cc: Bjorn Helgaas <bhelgaas at google.com> > Cc: Lukas Wunner <lukas at wunner.de> > Cc: linux-pci at vger.kernel.org > Cc: nouveau at lists.freedesktop.org > Fixes: b516ea586d71 ("PCI: Enable NVIDIA HDA controllers") > Signed-off-by: Karol Herbst <kherbst at redhat.com> > --- > drivers/pci/quirks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 44cab813bf951...

...essary"). Please describe in more detail how the GPU's PCI function stops working. Does it respond with "all ones" when accessing MMIO? Do MMIO accesses cause the system to hang? Could you provide lspci -vvxx output for the GPU and its associated HDA controller with and without b516ea586d71? Does this machine have external display connectors via which audio can be streamed? > I'm not really holding my breath on this patch to being accepted: > there's a good chance there's a better solution for this (and I'm going > to continue investigating for one after se...

...the GPU's PCI function stops working. > > Does it respond with "all ones" when accessing MMIO? > > Do MMIO accesses cause the system to hang? > > > > Could you provide lspci -vvxx output for the GPU and its associated > > HDA controller with and without b516ea586d71? > > > > Does this machine have external display connectors via which audio > > can be streamed? > > > > > > > I'm not really holding my breath on this patch to being accepted: > > > there's a good chance there's a better solution for t...

...escribe in more detail how the GPU's PCI function stops working. > Does it respond with "all ones" when accessing MMIO? > Do MMIO accesses cause the system to hang? > > Could you provide lspci -vvxx output for the GPU and its associated > HDA controller with and without b516ea586d71? > > Does this machine have external display connectors via which audio > can be streamed? > > > > I'm not really holding my breath on this patch to being accepted: > > there's a good chance there's a better solution for this (and I'm going > > to co...