search for: b44ce1c

...return 0; > +} We do have already a "fsck" action; OTOH fsck.btrfs does nothing, so I would rather call `btrfs check` there, instead of adding a new btrfs-specific API. Let's make our fsck useful on btrfs :) > diff --git a/generator/actions.ml b/generator/actions.ml > index b44ce1c..c328319 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12267,6 +12267,20 @@ Reads all the data and metadata on the filesystem, and uses checksums > and the duplicate copies from RAID storage to identify and repair any > corrupt data." }; > > +...

Hi, There is one problem: btrfs_filesystem_set_label just doesnt work, giving error message: libguestfs: error: btrfs_filesystem_set_label: /: ERROR: unable to set label Bad address I'm almost sure the patch has no problem, but can't figure out what's the cause. So patch 5 is only for review. Other APIs have no problem. Regards, Hu Hu Tao (5): New API: btrfs_scrub New API:

...t"); + ADD_ARG (argv, i, path_buf); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", path, err); + return -1; + } + + return 0; +} diff --git a/generator/actions.ml b/generator/actions.ml index a6a6dad..b44ce1c 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12250,6 +12250,23 @@ several qgroups into a parent qgroup to share common limit." }; longdesc = "\ Remove qgroup C<src> from the parent qgroup C<dst>." }; + { defaults with + name = "btrfs_s...

...quot;check"); + ADD_ARG (argv, i, device); + ADD_ARG (argv, i, NULL); + + r = commandv (&out, &err, argv); + if (r == -1) { + reply_with_error ("%s: %s", device, err); + return -1; + } + + return 0; +} diff --git a/generator/actions.ml b/generator/actions.ml index b44ce1c..c328319 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -12267,6 +12267,20 @@ Reads all the data and metadata on the filesystem, and uses checksums and the duplicate copies from RAID storage to identify and repair any corrupt data." }; + { defaults with + name = "...

...tead of adding a new > btrfs-specific API. > Let's make our fsck useful on btrfs :) I found btrfs_fsck has been already implemented. Do you mean we should extend btrfs to support btrfs? Regards, Hu > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index b44ce1c..c328319 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -12267,6 +12267,20 @@ Reads all the data and metadata on the filesystem, and uses checksums > > and the duplicate copies from RAID storage to identify and repair any > > corrupt data...