search for: b37505fe

David, Thanks for reviewing! On Wed, Oct 9, 2013 at 11:36 AM, David Blaikie <dblaikie at gmail.com> wrote: > Might be easier if these were on Phabricator, but here are some thoughts: > > 0001: > This patch generally, while separated for legibility, is untested & > difficult to discuss in isolation. > I agree, this patch adds the functionality but does not use it,

Might be easier if these were on Phabricator, but here are some thoughts: 0001: This patch generally, while separated for legibility, is untested & difficult to discuss in isolation. I may need to refer to the second patch in reviewing this first one. DwarfDebug.cpp: computeSizeAndOffsets: I believe this produces the wrong offset for the 3rd CU and onwards. computeSizeAndOffset

...platform. >>>> >>>> Thanks, >>>> Manman >>>> >>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131009/b37505fe/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Debug-Info-remove-from-from-addDIEEntry.patch Type: application/octet-stream Size: 8647 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131009/b3750...