search for: b3258ff1d6

...e and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. This was the working behaviour before the change introduced in commit b3258ff1d6. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/char/virtio_console.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)...

...e and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. This was the working behaviour before the change introduced in commit b3258ff1d6. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/char/virtio_console.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)...

...gt; > > > This patch removes the unused buffers in vq's when we unplug the port. > > This is the best we can do as we cannot call device_reset because virtio > > device is still active. This was the working behaviour before the change > > introduced in commit b3258ff1d6. > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") > > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> > > I think if you do this you need to add support > in...

...gt; > > > This patch removes the unused buffers in vq's when we unplug the port. > > This is the best we can do as we cannot call device_reset because virtio > > device is still active. This was the working behaviour before the change > > introduced in commit b3258ff1d6. > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") > > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> > > I think if you do this you need to add support > in...

...> This patch removes the unused buffers in vq's when we unplug the port. > > > This is the best we can do as we cannot call device_reset because virtio > > > device is still active. This was the working behaviour before the change > > > introduced in commit b3258ff1d6. > > > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") > > > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> > > > > I think if you do this yo...

...or if queue is full. > > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. This was the working behaviour before the change > introduced in commit b3258ff1d6. > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> I think if you do this you need to add support in the packed ring. > --- > dr...

...error if queue is full. > > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. This was the working behaviour before the change > introduced in commit b3258ff1d6. ping. This patch fixes a regression in upstream kernel, virtio_console driver. Can we please have this merged. Thanks, Pankaj > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") > Signed-off-by:...

...> > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. Why is this indented? > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Fixes: b3258ff1d608 ("virtio: Decrement avail idx on buffer detach") is the correct format to use. And given that this is from 2.6.39 (and 2.6.38.5), shouldn't it also be backported for the stable kernels? thanks, greg k-h

This patch series fixes the issue with unplug/replug of a port in virtio console device, which fails with an error "Error allocating inbufs\n". Patch 2 makes virtio packed ring code compatible with virtio split ring. Tested the packed ring code with the qemu virtio 1.1 device code posted here [1]. Changes from v1[2] ----- Make virtio packed ring code compatible with split ring -

...s in virtqueue and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/char/virtio_console.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index...

...ch unused buffers without doing a device reset first. Defer detaching the buffers until device unplug. Of course this means we might get an interrupt for a vq without an attached port now. Handle that by discarding the consumed buffer. Reported-by: Tiwei Bie <tiwei.bie at intel.com> Fixes: b3258ff1d6 ("virtio: Decrement avail idx on buffer detach") CC: stable at kernel.org Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/char/virtio_console.c | 49 +++++++++++++++++++++---------------------- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/driver...

Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6): virtio_console: don't tie bufs to a vq virtio: add ability to iterate over vqs virtio_console:

Turns out virtio console tries to take a buffer out of an active vq. Works by sheer luck, and is explicitly forbidden by spec. And while going over it I saw that error handling is also broken - failure is easy to trigger if I force allocations to fail. Lightly tested. Michael S. Tsirkin (6): virtio_console: don't tie bufs to a vq virtio: add ability to iterate over vqs virtio_console: