Displaying 3 results from an estimated 3 matches for "b0251e4".
Did you mean:
002514
2015 Jul 03
0
boot... round 2
...e to only apply the change
> to readconfig.c if you want.
>
It works OK as whole, for the current git:
com32/include/menu.h | 2 +-
com32/menu/readconfig.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/com32/include/menu.h b/com32/include/menu.h
index bc0182f..b0251e4 100644
--- a/com32/include/menu.h
+++ b/com32/include/menu.h
@@ -195,7 +195,7 @@ void local_cursor_enable(bool);
static inline int my_isspace(char c)
{
- return (unsigned char)c <= ' ';
+ return (unsigned char)c <= ' ' || (unsigned char)c == '\x7f';
}
int...
2015 Jul 03
7
boot... round 2
...e problem
>
> - "c >= 0 && c <= ' '" solves the problem for the current git
Could you try the following patch? Feel free to only apply the change
to readconfig.c if you want.
--
-Gene
diff --git a/com32/include/menu.h b/com32/include/menu.h
index bc0182f..b0251e4 100644
--- a/com32/include/menu.h
+++ b/com32/include/menu.h
@@ -195,7 +195,7 @@ void local_cursor_enable(bool);
static inline int my_isspace(char c)
{
- return (unsigned char)c <= ' ';
+ return (unsigned char)c <= ' ' || (unsigned char)c == '\x7f';
}
int m...
2015 Jul 02
6
boot... round 2
Hi,
hpa wrote:
> On PowerPC (I think) "unsigned char" is the default.
In any case it seems a good idea to interpret the character
more explicitely. To my experience, one signdness change causes
a little tree of consequential signedness changes or questionable
cast operations.
How about the following instead ?
if ((c >= 0 && c <= ' ') || c == '\x7f')