Displaying 3 results from an estimated 3 matches for "auth_request_log_finished".
2019 Jul 12
2
[bug] success field never emited in auth_request_finished event
...nished' event is documented as having a 'successful' field, but in the code, the field is defined as 'success' (e->add_str("success", "yes")).
But more important, in the function "auth_request_success_continue()" (auth/auth-request.c:288), "auth_request_log_finished(request)" is call (line 303) before updating the request status: "request->successful = TRUE" (line 312)
So the log function never set the success field to "yes" as at this point request->successful is still false.
Jean-Daniel
2019 Jul 12
1
[bug] success field never emited in auth_request_finished event
...e, the field is defined as 'success' (e->add_str("success", "yes")).
</div>
<div>
<br>
</div>
<div>
But more important, in the function "auth_request_success_continue()" (auth/auth-request.c:288), "auth_request_log_finished(request)" is call (line 303) before updating the request status: "request->successful = TRUE" (line 312)
</div>
<div>
<br>
</div>
<div>
So the log function never set the success field to "yes" as at this point reque...
2019 Jul 12
0
[bug] success field never emited in auth_request_finished event
...; event is documented as having a 'successful' field, but in the code, the field is defined as 'success' (e->add_str("success", "yes")).
>
> But more important, in the function "auth_request_success_continue()" (auth/auth-request.c:288), "auth_request_log_finished(request)" is call (line 303) before updating the request status: "request->successful = TRUE" (line 312)
>
> So the log function never set the success field to "yes" as at this point request->successful is still false.
>
> Jean-Daniel
>
>
>...