Displaying 7 results from an estimated 7 matches for "assert_death".
2008 Dec 27
0
[LLVMdev] [Patch] Adding unit tests to LLVM
...hat we'll end up using googletest, here are some
comments on your patch:
* s/Insure/Ensure/
* LLVM uses "llvm/foo.h" for inclusion rather than <llvm/foo.h>
* You should use the same format for gtest headers
* If reverse iteration isn't supported, you should either have an
ASSERT_DEATH() on the decrement, or not have the code there (that's
commented out) at all.
* Instead of this:
EXPECT_TRUE(uintMap[0] == 1);
you should use EXPECT_EQ()
* Instead of this:
EXPECT_TRUE(uintMap.find(0u) == uintMap.begin());
is it possible to use EXPECT_EQ() as well?
* In this test:
TEST_F(Den...
2008 Dec 23
6
[LLVMdev] [Patch] Adding unit tests to LLVM
(Forwarding this to llvm-dev)
This patch adds a unit test framework to LLVM, along with a sample unit test
for DenseMap. I don't expect this patch to be accepted as-is, this is mainly
a trial balloon and proof of concept.
Some notes about the patch:
1) For the testing framework, I went with Google Test, since it's the one I
have the most experience with. I fully expect an extended
2008 Dec 27
3
[LLVMdev] [Patch] Adding unit tests to LLVM
...e are some
> comments on your patch:
>
> * s/Insure/Ensure/
>
> * LLVM uses "llvm/foo.h" for inclusion rather than <llvm/foo.h>
> * You should use the same format for gtest headers
>
> * If reverse iteration isn't supported, you should either have an
> ASSERT_DEATH() on the decrement, or not have the code there (that's
> commented out) at all.
>
> * Instead of this:
> EXPECT_TRUE(uintMap[0] == 1);
> you should use EXPECT_EQ()
>
> * Instead of this:
> EXPECT_TRUE(uintMap.find(0u) == uintMap.begin());
> is it possible to use EXPEC...
2008 Oct 12
0
[LLVMdev] 2.4 Pre-release (v1) Available for Testing
On Sun, Oct 12, 2008 at 11:13 AM, Keir Mierle <mierle at gmail.com> wrote:
> Justs to chime in: I'm one of the gtest devs. I'd like to add that gtest is
> very portable, more so than llvm; it even works on WinCE and blackberry. If
> there are specific features needed by LLVM, depending on what it is I may be
> able to get it into gtest.
I noticed that gtest uses fork to
2008 Dec 27
1
[LLVMdev] [Patch] Adding unit tests to LLVM
...e are some
> comments on your patch:
>
> * s/Insure/Ensure/
>
> * LLVM uses "llvm/foo.h" for inclusion rather than <llvm/foo.h>
> * You should use the same format for gtest headers
>
> * If reverse iteration isn't supported, you should either have an
> ASSERT_DEATH() on the decrement, or not have the code there (that's
> commented out) at all.
>
I'll probably just remove it.
> * Instead of this:
> EXPECT_TRUE(uintMap[0] == 1);
> you should use EXPECT_EQ()
>
Sure.
> * Instead of this:
> EXPECT_TRUE(uintMap.find(0u) == uint...
2008 Dec 27
0
[LLVMdev] [Patch] Adding unit tests to LLVM
...e are some
> comments on your patch:
>
> * s/Insure/Ensure/
>
> * LLVM uses "llvm/foo.h" for inclusion rather than <llvm/foo.h>
> * You should use the same format for gtest headers
>
> * If reverse iteration isn't supported, you should either have an
> ASSERT_DEATH() on the decrement, or not have the code there (that's
> commented out) at all.
>
> * Instead of this:
> EXPECT_TRUE(uintMap[0] == 1);
> you should use EXPECT_EQ()
>
> * Instead of this:
> EXPECT_TRUE(uintMap.find(0u) == uintMap.begin());
> is it possible to use EXPEC...
2008 Oct 12
2
[LLVMdev] 2.4 Pre-release (v1) Available for Testing
On Sat, Oct 11, 2008 at 11:58 PM, Talin <viridia at gmail.com> wrote:
> I've been using gtest (http://code.google.com/p/googletest/) for all of
> my frontend unit tests and I'm very happy with it. It does all of that
> automatic test discovery stuff pretty well. I haven't tried the XML test
> report generation stuff, but it does have that capability.
Justs to chime