search for: asmcallsuffix

Hi all, I've encountered a couple of minor build issues on Solaris that have crept in since 2.5, fixes below: 1. In lib/Target/X86/X86JITInfo.cpp, there is: // Check if building with -fPIC #if defined(__PIC__) && __PIC__ && defined(__linux__) #define ASMCALLSUFFIX "@PLT" #else #define ASMCALLSUFFIX #endif Which causes a link failure due to the non-PLT relocation that results. I'm not sure if this should be #if defined(__PIC__) && __PIC__ && (defined(__linux__) || defined(__sun__)) or #if defined(__PIC__) && __PIC_...

Hello, Nathan > or if it should be a configure test, which might be safer. Are there > any x86 platforms (other than apple) that don't need PLT-indirect calls? Yes, mingw. However just tweaking the define is not enough - we're not loading address of GOT into ebx before the call (on 32 bit ABIs) thus the call will be to nowhere. -- With best regards, Anton Korobeynikov Faculty of

...string> using namespace llvm; @@ -52,7 +53,7 @@ #define ASMPREFIX GETASMPREFIX(__USER_LABEL_PREFIX__) // Check if building with -fPIC -#if defined(__PIC__) && __PIC__ && defined(__linux__) +#if defined(__PIC__) && __PIC__ && defined(NEED_PLT_CALL) #define ASMCALLSUFFIX "@PLT" #else #define ASMCALLSUFFIX Index: autoconf/configure.ac =================================================================== --- autoconf/configure.ac (revision 79390) +++ autoconf/configure.ac (working copy) @@ -1150,6 +1150,11 @@ dnl Check, whether __dso_handle...

...I've encountered a couple of minor build issues on Solaris that > have crept in since 2.5, fixes below: > >   1. In lib/Target/X86/X86JITInfo.cpp, there is: > > // Check if building with -fPIC > #if defined(__PIC__) && __PIC__ && defined(__linux__) > #define ASMCALLSUFFIX "@PLT" > #else > #define ASMCALLSUFFIX > #endif > > Which causes a link failure due to the non-PLT relocation that > results. I'm not sure if this should be > #if defined(__PIC__) && __PIC__ && (defined(__linux__) || > defined(__sun__)) > &gt...