search for: argpo

...a core dump in upssched >> when an event occurs. During my research i found out that this happens when >> the line: >> >> AT ONBATT * START-TIMER shutdown 30 >> >> is parsed. It crashed then in add_arg_word at the following line: >> >> ctx->arglist[argpos] = realloc(ctx->arglist[argpos], newlen); >> >> I looked at the code (and did a diff to the previous stable code) but did >> not find anything. I'm at the end of my knowledge now, so i want to ask you >> if you did have any idea? >> >> Regards >> Vo...

...ons(-) diff --git a/include/nbdkit-common.h b/include/nbdkit-common.h index 27f6ed1..36fce20 100644 --- a/include/nbdkit-common.h +++ b/include/nbdkit-common.h @@ -45,6 +45,13 @@ extern "C" { #endif +#if defined(__GNUC__) || defined(__clang__) +#define ATTRIBUTE_FORMAT_PRINTF(fmtpos, argpos) \ + __attribute__((__format__ (__printf__, fmtpos, argpos))) +#else +#define ATTRIBUTE_FORMAT_PRINTF(fmtpos, argpos) +#endif + #define NBDKIT_THREAD_MODEL_SERIALIZE_CONNECTIONS 0 #define NBDKIT_THREAD_MODEL_SERIALIZE_ALL_REQUESTS 1 #define NBDKIT_THREAD_MODEL_SERIALIZE_REQUESTS...

v1 was here: https://www.redhat.com/archives/libguestfs/2019-January/msg00008.html In v2 I have provided two patches: The first patch extends attribute((nonnull)) to most internal functions, but not to the external API. The second patch uses a macro so that attribute((format)) is only used in the public API on GCC or Clang. At least in theory these headers could be used by a C compiler which

...rosh_ls(const char *cmdstr, const char *pwdstr) { char filestr[ROSH_PATH_SZ + 1]; - int cmdpos; /* Position within cmdstr */ + char optstr[ROSH_OPT_SZ]; /* Options string */ + int cmdpos, tpos; /* Position within cmdstr, temp position */ + int numargs; /* number of non-option arguments */ + int argpos; /* number of non-option arguments processed */ + int optarr[2]; ROSH_DEBUG("CMD: '%s'\npwd: '%s'\n", cmdstr, pwdstr); /* Initialization */ filestr[0] = 0; + optstr[0] = 0; cmdpos = 0; + numargs = 0; + argpos = 0; /* skip the first word */ cmdpos = rosh_parse...

...| 2 + 4 files changed, 83 insertions(+), 53 deletions(-) diff --git a/include/nbdkit-common.h b/include/nbdkit-common.h index d38b37d2..8684b95a 100644 --- a/include/nbdkit-common.h +++ b/include/nbdkit-common.h @@ -55,6 +55,8 @@ extern "C" { #define ATTRIBUTE_FORMAT_PRINTF(fmtpos, argpos) #endif +#define NBDKIT_DLLEXPORT + #define NBDKIT_THREAD_MODEL_SERIALIZE_CONNECTIONS 0 #define NBDKIT_THREAD_MODEL_SERIALIZE_ALL_REQUESTS 1 #define NBDKIT_THREAD_MODEL_SERIALIZE_REQUESTS 2 @@ -76,49 +78,63 @@ extern "C" { #define NBDKIT_EXTENT_HOLE (1<<0) /...

...char filestr[ROSH_PATH_SZ + 1]; - int cmdpos; /* Position within cmdstr */ + char filestr[ROSH_PATH_SZ]; + char optstr[ROSH_OPT_SZ]; /* Options string */ + int cmdpos, tpos; /* Position within cmdstr, temp position */ + int numargs; /* number of non-option arguments */ + int argpos; /* number of non-option arguments processed */ + int optarr[3]; - ROSH_DEBUG("CMD: '%s'\npwd: '%s'\n", cmdstr, pwdstr); + ROSH_DEBUG("CMD: '%s'\n", cmdstr); /* Initialization */ filestr[0] = 0; + optstr[0] = 0; cmdpos = 0;...

...t; <token> <prio>\n" + " watch <path> <token>\n" " waitwatch\n" " ackwatch <token>\n" " unwatch <path> <token>\n" @@ -197,22 +201,34 @@ " dump\n"); } +static int argpos(const char *line, unsigned int num) +{ + unsigned int i, len = 0, off = 0; + + for (i = 0; i <= num; i++) { + off += len; + off += strspn(line + off, " \t\n"); + len = strcspn(line + off, " \t\n"); + if (!len) + return off; + } + return off; +} + static char *arg(char...

Also available here: https://github.com/rwmjones/nbdkit/tree/2020-windows-mingw This is the port to Windows using native Windows APIs (not MSYS or Cygwin). This patch series is at the point where it basically now works. I can run the server with the memory plugin, and access it remotely using guestfish, creating filesystems and so on without any apparent problems. Nevertheless there are many

This is an incomplete port to Windows. Currently the server compiles and starts up successfully, but goes into an infinite loop when you connect to it. Nevertheless I think the approach is ready for feedback. This being Windows the changes go quite deep. Rich.