search for: arch_validate_virtio_featur

...virtio: PV needs VIRTIO I/O device protection arch/s390/mm/init.c | 27 +++++++++++++++++++++++++++ drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 3 files changed, 47 insertions(+) -- 2.25.1 Changelog to v5: - return directly from S390 arch_validate_virtio_features() when the guest is not protected. (Connie) - Somme rewording (Connie, Michael) - moved back code from arch/s390/ ...kernel/uv.c to ...mm/init.c (Christian) to v4: - separate virtio and arch code (Pierre) - moved code from arch/s390/mm/init.c to arch/s390/kernel/uv.c (as interpre...

On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel <pmorel at linux.ibm.com> wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's not the case, preventing a host error on access > attempt > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > --- > arch/s390/mm/init.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > di...

On Thu, 9 Jul 2020 10:39:19 +0200 Pierre Morel <pmorel at linux.ibm.com> wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's not the case, preventing a host error on access > attempt > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > --- > arch/s390/mm/init.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > di...

.../mm/init.c | 28 ++++++++++++++++++++++++++++ drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 3 files changed, 48 insertions(+) -- 2.25.1 Changelog to v6: - rewording warning messages (Connie, Halil) to v5: - return directly from S390 arch_validate_virtio_features() when the guest is not protected. (Connie) - Somme rewording (Connie, Michael) - moved back code from arch/s390/ ...kernel/uv.c to ...mm/init.c (Christian) to v4: - separate virtio and arch code (Pierre) - moved code from arch/s390/mm/init.c to arch/s390/kernel/uv.c (as interpre...

...io/virtio.c > @@ -167,6 +167,21 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) > } > EXPORT_SYMBOL_GPL(virtio_add_status); > > +/* > + * arch_needs_virtio_iommu_platform - provide arch specific hook when finalizing s/arch_needs_virtio_iommu_platform/arch_validate_virtio_features/ :) > + * features for VIRTIO device dev > + * @dev: the VIRTIO device being added > + * > + * Permits the platform to provide architecture specific functionality when s/provide architecture specific functionality/handle architecture-specific requirements/ ? > + * dev...

...io/virtio.c > @@ -167,6 +167,21 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) > } > EXPORT_SYMBOL_GPL(virtio_add_status); > > +/* > + * arch_needs_virtio_iommu_platform - provide arch specific hook when finalizing s/arch_needs_virtio_iommu_platform/arch_validate_virtio_features/ :) > + * features for VIRTIO device dev > + * @dev: the VIRTIO device being added > + * > + * Permits the platform to provide architecture specific functionality when s/provide architecture specific functionality/handle architecture-specific requirements/ ? > + * dev...

...to enforce VIRTIO I/O device protection through the use of > VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. Hm... what about: "If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features() interface to enforce this." > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > --- > arch/s390/kernel/uv.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c > index c2...

...to enforce VIRTIO I/O device protection through the use of > VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM. Hm... what about: "If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features() interface to enforce this." > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > --- > arch/s390/kernel/uv.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c > index c2...

...ael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: > > > If protected virtualization is active on s390, the virtio queues are > > > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > > > negotiated. Use the new arch_validate_virtio_features() interface to > > > fail probe if that's not the case, preventing a host error on access > > > attempt. > > > > > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > > > Reviewed-by: Cornelia Huck <cohuck at redhat.com> > &gt...

...ael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: > > > If protected virtualization is active on s390, the virtio queues are > > > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > > > negotiated. Use the new arch_validate_virtio_features() interface to > > > fail probe if that's not the case, preventing a host error on access > > > attempt. > > > > > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > > > Reviewed-by: Cornelia Huck <cohuck at redhat.com> > &gt...

...+++++++++ drivers/virtio/virtio.c | 19 +++++++++++++++++++ include/linux/virtio_config.h | 1 + 3 files changed, 48 insertions(+) -- 2.25.1 Changelog to v7: - typo in warning message (Connie) to v6: - rewording warning messages (Connie, Halil) to v5: - return directly from S390 arch_validate_virtio_features() when the guest is not protected. (Connie) - Somme rewording (Connie, Michael) - moved back code from arch/s390/ ...kernel/uv.c to ...mm/init.c (Christian) to v4: - separate virtio and arch code (Pierre) - moved code from arch/s390/mm/init.c to arch/s390/kernel/uv.c (as interpre...

Hi all, I changed the patch subject to reflect the content, becoming more general. 1) I removed the ack from Christian and Jason even far as I understand they gave it for the functionality more than for the implementation. @Jason, @Christian, please can I get back your acked-by with these changes? 2) previous patch had another name: [PATCH v3 0/1] s390: virtio: let arch choose to

On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's not the case, preventing a host error on access > attempt. > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > Reviewed-by: Cornelia Huck <cohuck at redhat.com> > Acked-by: Halil Pasic <pasic at linux.ibm.com>...

On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's not the case, preventing a host error on access > attempt. > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > Reviewed-by: Cornelia Huck <cohuck at redhat.com> > Acked-by: Halil Pasic <pasic at linux.ibm.com>...

...git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index a977e32a88f2..c4e14d46a5b6 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -167,6 +167,21 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) } EXPORT_SYMBOL_GPL(virtio_add_status); +/* + * arch_validate_virtio_features - provide arch specific hook when finalizing + * features for VIRTIO device dev + * @dev: the VIRTIO device being added + * + * Permits the platform to handle architecture-specific requirements when + * device features are finalized. This is the default implementation. + * Architecture impl...

...o/virtio.c > index a977e32a88f2..c4e14d46a5b6 100644 > --- a/drivers/virtio/virtio.c > +++ b/drivers/virtio/virtio.c > @@ -167,6 +167,21 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) > } > EXPORT_SYMBOL_GPL(virtio_add_status); > > +/* > + * arch_validate_virtio_features - provide arch specific hook when finalizing > + * features for VIRTIO device dev > + * @dev: the VIRTIO device being added > + * > + * Permits the platform to handle architecture-specific requirements when > + * device features are finalized. This is the default implementati...

...ote: > On Thu, 9 Jul 2020 10:39:19 +0200 > Pierre Morel <pmorel at linux.ibm.com> wrote: > > > If protected virtualization is active on s390, the virtio queues are > > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > > negotiated. Use the new arch_validate_virtio_features() interface to > > fail probe if that's not the case, preventing a host error on access > > attempt Punctuation at the end? Also 'that's not the case' refers to the negation 'VIRTIO_F_IOMMU_PLATFORM has been negotiated', arch_validate_virtio_features() is how...

...git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index a977e32a88f2..c4e14d46a5b6 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -167,6 +167,21 @@ void virtio_add_status(struct virtio_device *dev, unsigned int status) } EXPORT_SYMBOL_GPL(virtio_add_status); +/* + * arch_validate_virtio_features - provide arch specific hook when finalizing + * features for VIRTIO device dev + * @dev: the VIRTIO device being added + * + * Permits the platform to handle architecture-specific requirements when + * device features are finalized. This is the default implementation. + * Architecture impl...

On 14.07.20 13:38, Pierre Morel wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's not the case, preventing a host error on access > attempt. > > Signed-off-by: Pierre Morel <pmorel at linux.ibm.com> > Reviewed-by: Cornelia Huck <cohuck at redhat.com> > Acked-by: Halil Pasic <pasic at linux.ibm.com>...

...features for VIRTIO device dev + * @dev: the VIRTIO device being added + * + * Permits the platform to provide architecture specific functionality when + * devices features are finalized. This is the default implementation. + * Architecture implementations can override this. + */ + +int __weak arch_validate_virtio_features(struct virtio_device *dev) +{ + return 0; +} + int virtio_finalize_features(struct virtio_device *dev) { int ret = dev->config->finalize_features(dev); @@ -176,6 +191,10 @@ int virtio_finalize_features(struct virtio_device *dev) if (ret) return ret; + ret = arch_validate_virtio_f...