search for: arcfilter

...FWIW, here is what I do, and I know not > everyone wants to use `arc`. Ina script this could potentially reduce > the pain. Again, this is not meant to tell you it is simple or your > problems are not real. > > arc patch DXXXX > git pull --rebase origin master > arc amend > arcfilter // see below > git llvm push master > > > arcfilter () { git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:/' | git commit --amend -F - } Thanks, this indeed solves some of my problems, howe...

...now not >> everyone wants to use `arc`. Ina script this could potentially reduce >> the pain. Again, this is not meant to tell you it is simple or your >> problems are not real. >> >> arc patch DXXXX >> git pull --rebase origin master >> arc amend >> arcfilter // see below >> git llvm push master >> >> >> arcfilter () { git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:/' | git commit --amend -F - } > > Thanks, this indeed sol...

...hall we mention on https://llvm.org/docs/DeveloperPolicy.html that >> developers are recommended to delete metadata tags before committing? > > > That's be great! > I suspect we can provide a bash function to add to one's .bashrc to make > it trivial: > > function arcfilter() { git log -1 --pretty=%B | awk '/Reviewers: /{p=1; > sub(/Reviewers: .*Differential Revision: /, "")}; /Differential Revision: > /{p=0;}; !p' | git commit --amend -F - ; } > > Just running `arcfilter` before pushing will filter the commit it out > automatically...

...use `arc`. Ina script this could potentially reduce > >> the pain. Again, this is not meant to tell you it is simple or your > >> problems are not real. > >> > >> arc patch DXXXX > >> git pull --rebase origin master > >> arc amend > >> arcfilter // see below > >> git llvm push master > >> > >> > >> arcfilter () { git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:/' | git commit --amend -F - } > > > &...

Many git commits in the monorepo look like the following: [Tag0][Tag1] Title line Summary: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque mauris neque, porta nec tristique at, sagittis vel nisi. Fusce pharetra nunc et mauris consequat venenatis. Reviewers: username0, username1 Reviewed By: username0 Subscribers: username2, username3,

Hi, I know there has been significant discussion about "moving" from Phabricator to GitHub reviews and pull requests, etc. I'm not suggesting that we do anything in terms of global LLVM policy. However, as a maintainer of libc++, I commit __a lot__ of other people's code for them. It would be a huge time saver for me if I could nicely suggest to contributors (not force them) to

I also find the "Reviewed by" tag useful (as well as the review link), for the same reasons. In fact, I don't even use arcanist to push commits, so I do it all by hand, and only include the "Reviewed by" and "Differential Revision" tags. On Fri, 27 Dec 2019 at 20:55, David Blaikie via llvm-dev < llvm-dev at lists.llvm.org> wrote: > I don't think