Displaying 2 results from an estimated 2 matches for "arcanistdiffworkflow".
2020 Apr 09
3
Delete Phabricator metadata tags before committing
...sage from the server,
I assumed so too until I went digging for it. Seems the client-side stuff
only deals with the structured data, and calls out to the server to
construct the raw text when needed:
https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757
> we could do some
> additional things:
>
> * Remove "Summary:" in front of message
> * Line break after 72 columns
> * Convert summary markdown formatting to plain texts (e.g. remove
> backticks; I don't know any git client that renders as markdown)...
2020 Apr 09
3
Delete Phabricator metadata tags before committing
Can we fix this in reviews.llvm.org's fork of phab?
https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php
Seems straightforward(-ish) to drop the relevant fields there, that way
`arc land` automatically DTRT.
Jon
On Fri, Dec 27, 2019 at 11:30 PM Mehdi AMINI via llvm-dev