search for: aprantl

...DAG already has transferDbgValues which can move dbgvalue to the cast source, I think that we can just call it where the truncate is optimized away. That sounds reasonable, yes. Casts are effectively transparent for debug info purposes. -- adrian > > Thanks, > Sejong > > From: aprantl at apple.com <mailto:aprantl at apple.com> <aprantl at apple.com <mailto:aprantl at apple.com>> > Sent: Monday, April 30, 2018 2:59 PM > To: Se Jong Oh <sejooh at microsoft.com <mailto:sejooh at microsoft.com>> > Cc: jdevlieghere at apple.com <mailto:jdevl...

...nks, Adrian > On May 11, 2016, at 2:52 PM, Francois Pichet <pichet2000 at gmail.com> wrote: > > In retrospect I totally agree with you. I am looking at LiveDebugValue again to see if I can improve certain specific cases. > > On Wed, May 11, 2016 at 5:14 PM, Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: > >> On May 11, 2016, at 2:09 PM, Francois Pichet <pichet2000 at gmail.com <mailto:pichet2000 at gmail.com>> wrote: >> >> Good point. >> >> Currently yes a DEBUG_VALUE "x", vreg0 wi...

Can't say I know much about -fdebug-prefix-map, but... On Thu, Nov 29, 2018 at 1:07 PM Adrian Prantl <aprantl at apple.com> wrote: > Thanks for the feedback! Closely-related follow-up question: Is *this* a > bug? > > llvm/tools/clang/test/CodeGen/debug-prefix-map.c:33:27: > // CHECK-COMPILATION-DIR: !DIFile(filename: > "/var/empty{{[/\\]}}Inputs/stdio.h", directory: "/v...

For cast instructions, llvm::salvageDebugInfo() simply makes dbg.value point to the source of the cast. Since SelectionDAG already has transferDbgValues which can move dbgvalue to the cast source, I think that we can just call it where the truncate is optimized away. Thanks, Sejong From: aprantl at apple.com <aprantl at apple.com> Sent: Monday, April 30, 2018 2:59 PM To: Se Jong Oh <sejooh at microsoft.com> Cc: jdevlieghere at apple.com; Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; pidgeot18 at gmail.com Subject: Re: [llvm-dev] [SelectionDAG] DbgValue node...

...ust be something missing from your example. LiveDebugValues should propagate the DBG_VALUE in this case. Are you sure that R5 isn’t clobbered or regmask’ed by any instruction, and that there is no conflicting DBG_VALUE? -- adrian > > > On Wed, May 11, 2016 at 5:53 PM, Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: > The most obvious place where it is lacking at the moment is that it only supports DBG_VALUEs in registers. Adding support for constant values, memory locations, and fp constants would be a big win! > > thanks, > Adrian >...

> On Apr 30, 2018, at 2:57 PM, Se Jong Oh <sejooh at microsoft.com> wrote: > > Thanks! It looks like SelectionDAG::salvageDebugInfo handles only addition with constant. You can look at llvm::salvageDebugInfo() for examples on how to handle other situations. -- adrian -------------- next part -------------- An HTML attachment was scrubbed... URL:

> On 2015-Jan-14, at 11:26, Adrian Prantl <aprantl at apple.com> wrote: > > >> On Jan 14, 2015, at 11:12 AM, David Blaikie <dblaikie at gmail.com> wrote: >> >> >> >> On Wed, Jan 14, 2015 at 11:04 AM, Adrian Prantl <aprantl at apple.com> wrote: >> One small request: Omitting the column fi...

...user may know over which path the control flow arrived at the current break point, but these are far in between.) That said, I’m very open to improvements to the quality and correctness, so please don’t feel discouraged :-) -- adrian > > On Wed, May 11, 2016 at 4:43 PM, Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: > > > On May 11, 2016, at 1:12 PM, Francois Pichet <pichet2000 at gmail.com <mailto:pichet2000 at gmail.com>> wrote: > > > > Hello, > > > > Regarding the problem of debug range for optimized co...

...en chooses which mode to run based on which directives are present and whether a debugger to run the corresponding fragment in is found. This way you could have one or both directives in a file, and we'd run whichever version(s) are appropriate On Thu, Sep 7, 2017 at 12:19 PM Adrian Prantl <aprantl at apple.com> wrote: > On Sep 7, 2017, at 12:11 PM, Adrian Prantl <aprantl at apple.com> wrote: > > > On Sep 7, 2017, at 12:01 PM, Zachary Turner <zturner at google.com> wrote: > > > > On Thu, Sep 7, 2017 at 11:49 AM Adrian Prantl <aprantl at apple.com>...

> On Mar 29, 2018, at 10:55 AM, paul.robinson at sony.com wrote: > > > >> -----Original Message----- >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of via >> llvm-dev >> Sent: Thursday, March 29, 2018 1:54 PM >> To: aprantl at apple.com; hsiangkai at gmail.com >> Cc: llvm-dev at lists.llvm.org >> Subject: Re: [llvm-dev] [RFC] Generate Debug Information for Labels in >> Function >> >>> Based on that I think it might be sufficient to have a flag on an IR >> label >>> that...

...example is produced by yet another pass and I will further debug it there... > > Nevertheless, should it not the deep copy of debug locations (once it has created the new DICompileUnit) updated the llvm.dbg.cu in this case? > > Sergei > > -----Original Message----- > From: aprantl at apple.com [mailto:aprantl at apple.com] > Sent: Monday, June 19, 2017 5:00 PM > To: Sergei Larin <slarin at codeaurora.org> > Cc: llvm-dev <llvm-dev at lists.llvm.org>; Keno Fischer <keno at juliacomputing.com> > Subject: Re: [llvm-dev] CloneFunctionInto produces i...

> -----Original Message----- > From: aprantl at apple.com [mailto:aprantl at apple.com] > Sent: Thursday, March 29, 2018 2:23 PM > To: Robinson, Paul > Cc: hsiangkai at gmail.com; llvm-dev at lists.llvm.org > Subject: Re: [llvm-dev] [RFC] Generate Debug Information for Labels in > Function > > > > > On Mar 29,...

On Thu, Sep 7, 2017 at 11:41 AM Adrian Prantl <aprantl at apple.com> wrote: > > > On Sep 7, 2017, at 11:23 AM, Zachary Turner <zturner at google.com> wrote: > > How do you run it? > > The repository is supposed to be cloned into llvm/tools/clang/test and > will then appear as part of check-clang. > > > It...

- old Keno +current Keno > On Jun 19, 2017, at 2:59 PM, Adrian Prantl <aprantl at apple.com> wrote: > > In your example the instructions in the cloned function have debug locations belonging to a different function, and the function itself is missing a DISubprogram metadata attachment. > >> (lldb) p OldFunc->dump() >> >> ; Function Attrs: n...

Thanks! It looks like SelectionDAG::salvageDebugInfo handles only addition with constant. Sejong From: aprantl at apple.com <aprantl at apple.com> Sent: Monday, April 30, 2018 1:53 PM To: Se Jong Oh <sejooh at microsoft.com> Cc: jdevlieghere at apple.com; Vedant Kumar <vsk at apple.com>; llvm-dev at lists.llvm.org; pidgeot18 at gmail.com Subject: Re: [llvm-dev] [SelectionDAG] DbgValue node...

> On Sep 7, 2017, at 12:01 PM, Zachary Turner <zturner at google.com> wrote: > > > > On Thu, Sep 7, 2017 at 11:49 AM Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: >> On Sep 7, 2017, at 11:37 AM, Zachary Turner via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> To be clear, the tests I'm proposing will have no resemblance what...

On Wed, Jan 14, 2015 at 11:04 AM, Adrian Prantl <aprantl at apple.com> wrote: > One small request: Omitting the column field from MDLocation if it is 0 is > fine, because it won’t make it into the line table. Omitting the line if it > is 0 is not, because it gives the wrong impression that the line is being > ignored, which is not the cas...

...; Sent: Thursday, March 15, 2018 8:43 AM > To: Se Jong Oh <sejooh at microsoft.com <mailto:sejooh at microsoft.com>> > Cc: Vedant Kumar <vsk at apple.com <mailto:vsk at apple.com>>; llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>; Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>>; pidgeot18 at gmail.com <mailto:pidgeot18 at gmail.com> > Subject: Re: [llvm-dev] [SelectionDAG] DbgValue nodes aren't transferred > > > >> On Mar 14, 2018, at 7:55 PM, Se Jong Oh <sejooh at microsoft.com> wro...

> On Jan 19, 2015, at 10:34 AM, David Blaikie <dblaikie at gmail.com> wrote: > > > > On Mon, Jan 19, 2015 at 10:29 AM, Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: > >> On Jan 19, 2015, at 10:26 AM, Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: >> >> >>> On Jan 19, 2015, at 10:08 AM, David Blaikie <dblaikie at gmail.com <m...

> On May 6, 2016, at 4:01 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > > >> On May 6, 2016, at 3:53 PM, Adrian Prantl <aprantl at apple.com> wrote: >> >>> >>> On May 6, 2016, at 3:48 PM, Adrian Prantl via llvm-dev <llvm-dev at lists.llvm.org> wrote: >>> >>>> >>>> On May 6, 2016, at 3:40 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: >>>...