search for: applyfixupfinal

On LLD mach/o x86_64 LLD calls dataInCodeTransitionStart and dataInCodeTransitionEnd, which aren't implemented (and thus return the defautl value 0), later in applyFixupFinal it reaches the default: unreachable causing miscompiles depending on the optimizer. Attached is a simple patch that fixes this. It also fixes the read8 method, as object files inside .a files aren't 8 byte aligned when memory mapped. -------------- next part -------------- An embedded and ch...

...On Tue, Jul 10, 2018 at 3:40 AM, Carlo Kok via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> On LLD mach/o x86_64 LLD calls dataInCodeTransitionStart and >> dataInCodeTransitionEnd, which aren't implemented (and thus return the >> defautl value 0), later in applyFixupFinal it reaches the default: >> unreachable causing miscompiles depending on the optimizer. >> >> Attached is a simple patch that fixes this. >> >> It also fixes the read8 method, as object files inside .a files aren't 8 >> byte aligned when memory mapped. >&gt...

...b/ReaderWriter/MachO/ArchHandler_x86_64.cpp b/deps/lld/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp index d687ca5d..07958da4 100644 --- a/deps/lld/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp +++ b/deps/lld/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp @@ -617,7 +617,6 @@ void ArchHandler_x86_64::applyFixupFinal( // Fall into llvm_unreachable(). break; } - llvm_unreachable("invalid x86_64 Reference Kind"); } void ArchHandler_x86_64::applyFixupRelocatable(const Reference &ref, commit fa45407e78c7a20281bf063f659d74f86c127ea1 Author: Andrew Kelley <superjoe30 at gmail.com&g...

Hi, I've tagged the 5.0.1-rc2 release, go ahead and start testing and report your results. -Tom