Displaying 20 results from an estimated 24 matches for "append_list".
Did you mean:
append_line
Re: [PATCH v2 5/5] launch: direct: Disable qemu locking when opening drives readonly (RHBZ#1417306).
2017 Sep 12
1
Re: [PATCH v2 5/5] launch: direct: Disable qemu locking when opening drives readonly (RHBZ#1417306).
On Tuesday, 12 September 2017 14:29:16 CEST Richard W.M. Jones wrote:
> @@ -255,11 +256,13 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
> }
> else {
> /* Writable qcow2 overlay on top of read-only drive. */
> - append_list_format ("file=%s", drv->overlay);
> + append_list_format ("file.file.filename=%s", drv->overlay);
> + append_list ("file.driver=qcow2");
> append_list ("cache=unsafe");
> - append_list ("format=qcow2");
> if (...
2017 May 17
7
[PATCH 1/5] s390x: launch: libvirt: Use <console> device sclp for appliance debug messages (RHBZ#1376547).
Thanks: Cole Robinson, Dan Horak, Thomas Huth.
---
lib/launch-libvirt.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c
index f66c8e0ef..4adb2cfb3 100644
--- a/lib/launch-libvirt.c
+++ b/lib/launch-libvirt.c
@@ -1359,6 +1359,7 @@ construct_libvirt_xml_devices (guestfs_h *g,
return -1;
}
+#ifndef __s390x__
/*
2017 May 17
0
[PATCH 5/5] s390x: launch: direct: Use virtio-*-ccw on this architecture.
...*datav, const char *arg)
* when needing entropy.
*/
if (guestfs_int_qemu_supports_device (g, data->qemu_data,
- "virtio-rng-pci")) {
+ VIRTIO_RNG)) {
start_list ("-object") {
append_list ("rng-random");
append_list ("filename=/dev/urandom");
append_list ("id=rng0");
} end_list ();
start_list ("-device") {
- append_list ("virtio-rng-pci");
+ append_list (VIRTIO_RNG);
append_list ("rng=rng...
2018 Jan 17
1
[PATCH] launch: direct: Use old-style file= and format= parameters when not disabling locking (RHBZ#1503497).
...unch-direct.c b/lib/launch-direct.c
index aa4139359..47e8f37de 100644
--- a/lib/launch-direct.c
+++ b/lib/launch-direct.c
@@ -255,17 +255,28 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
}
else {
/* Writable qcow2 overlay on top of read-only drive. */
- append_list_format ("file.file.filename=%s", drv->overlay);
- append_list ("file.driver=qcow2");
- append_list ("cache=unsafe");
- if (drv->disk_label)
- append_list_format ("serial=%s", drv->disk_label);
-
- /* Add the file-specific locking opt...
2017 Sep 05
4
[PATCH] lib: direct: Disable qemu locking when opening drives
Incomplete fix for https://bugzilla.redhat.com/show_bug.cgi?id=1417306
The full fix is waiting for a libvirt change, but this can still go
upstream.
Rich.
2017 Apr 27
4
[PATCH 0/4] common: Add a simple mini-library for handling qemu command and config files.
Currently we have an OCaml library for generating the qemu command
line (used only by ‘virt-v2v -o qemu’). However we also generate a
qemu command line in ‘lib/launch-direct.c’, and we might in future
need to generate a ‘-readconfig’-compatible configuration file if we
want to go beyond 10,000 drives for scalability testing.
Therefore this patch series reimplements the qemu command line code as
2017 Sep 12
0
[PATCH v2 5/5] launch: direct: Disable qemu locking when opening drives readonly (RHBZ#1417306).
...qemu_data *qemu_data; /* qemu -help output etc. */
char guestfsd_sock[UNIX_PATH_MAX]; /* Path to daemon socket. */
@@ -255,11 +256,13 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
}
else {
/* Writable qcow2 overlay on top of read-only drive. */
- append_list_format ("file=%s", drv->overlay);
+ append_list_format ("file.file.filename=%s", drv->overlay);
+ append_list ("file.driver=qcow2");
append_list ("cache=unsafe");
- append_list ("format=qcow2");
if (drv->disk_label)...
2018 Sep 03
3
[PATCH] ppc64le: Use -machine cap-htm=off unconditionally
Unfortunately I was not able to test this because I don't
currently have access to a P9 machine.
Rich.
2020 Feb 06
1
Re: [PATCH v2] launch: add support for autodetection of appliance image format
...ed, 25 insertions(+), 7 deletions(-)
>
> diff --git a/lib/launch-direct.c b/lib/launch-direct.c
> index 0be662e25..b9b54857a 100644
> --- a/lib/launch-direct.c
> +++ b/lib/launch-direct.c
> @@ -592,7 +592,9 @@ launch_direct (guestfs_h *g, void *datav, const char *arg)
> append_list ("id=appliance");
> append_list ("cache=unsafe");
> append_list ("if=none");
> +#ifndef APPLIANCE_FMT_AUTO
> append_list ("format=raw");
> +#endif
> } end_list ();
> start_list ("-device") {
>...
2017 Sep 05
1
Re: [PATCH] lib: direct: Disable qemu locking when opening drives readonly.
...ch-direct.c
> index 3b848165c..e5465539d 100644
> --- a/lib/launch-direct.c
> +++ b/lib/launch-direct.c
> @@ -221,8 +221,11 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
> file = guestfs_int_drive_source_qemu_param (g, &drv->src);
> append_list_format ("file=%s", file);
>
> - if (drv->readonly)
> + if (drv->readonly) {
> append_list ("snapshot=on");
> + if (guestfs_int_version_ge (&data->qemu_version, 2, 10, 0))
> + append_list ("locking=off");
> +...
2018 Sep 03
1
Re: [PATCH] ppc64le: Use -machine cap-htm=off unconditionally (RHBZ#1614948).
...h-direct.c b/lib/launch-direct.c
> index 47e8f37de..94dd995c6 100644
> --- a/lib/launch-direct.c
> +++ b/lib/launch-direct.c
> @@ -523,6 +523,9 @@ launch_direct (guestfs_h *g, void *datav, const char *arg)
> #ifdef __aarch64__
> if (has_kvm && !force_tcg)
> append_list ("gic-version=host");
> +#endif
> +#ifdef __powerpc64__
> + append_list ("cap-htm=off");
> #endif
Which version of qemu was this introduced in?
> diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c
> index 48404ef93..53284fc08 100644
> --- a/lib/l...
2018 Sep 03
2
[PATCH v3] ppc64le: Use -machine cap-htm=off unconditionally
Of course I mean state=off (not <htm state=on>) ...
Rich.
2017 Sep 05
0
[PATCH] lib: direct: Disable qemu locking when opening drives readonly.
...lib/launch-direct.c b/lib/launch-direct.c
index 3b848165c..e5465539d 100644
--- a/lib/launch-direct.c
+++ b/lib/launch-direct.c
@@ -221,8 +221,11 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
file = guestfs_int_drive_source_qemu_param (g, &drv->src);
append_list_format ("file=%s", file);
- if (drv->readonly)
+ if (drv->readonly) {
append_list ("snapshot=on");
+ if (guestfs_int_version_ge (&data->qemu_version, 2, 10, 0))
+ append_list ("locking=off");
+ }
append_list_format ("...
2017 Sep 12
0
Re: [PATCH] lib: direct: Disable qemu locking when opening drives readonly.
...848165c..e5465539d 100644
> > --- a/lib/launch-direct.c
> > +++ b/lib/launch-direct.c
> > @@ -221,8 +221,11 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
> > file = guestfs_int_drive_source_qemu_param (g, &drv->src);
> > append_list_format ("file=%s", file);
> >
> > - if (drv->readonly)
> > + if (drv->readonly) {
> > append_list ("snapshot=on");
> > + if (guestfs_int_version_ge (&data->qemu_version, 2, 10, 0))
> > + append_list (&qu...
2017 Nov 23
0
[PATCH] launch: direct: Omit locking option for non-file disks (RHBZ#1516094)
...+-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/launch-direct.c b/lib/launch-direct.c
index 87ac121c7558..678c8c68d59d 100644
--- a/lib/launch-direct.c
+++ b/lib/launch-direct.c
@@ -260,7 +260,11 @@ add_drive_standard_params (guestfs_h *g, struct backend_direct_data *data,
append_list ("cache=unsafe");
if (drv->disk_label)
append_list_format ("serial=%s", drv->disk_label);
- if (data->qemu_mandatory_locking)
+
+ /* Add the file-specific locking option only for files, as qemu
+ * won't accept options unknown to the block driv...
2018 Sep 03
0
[PATCH] ppc64le: Use -machine cap-htm=off unconditionally (RHBZ#1614948).
...sertions(+)
diff --git a/lib/launch-direct.c b/lib/launch-direct.c
index 47e8f37de..94dd995c6 100644
--- a/lib/launch-direct.c
+++ b/lib/launch-direct.c
@@ -523,6 +523,9 @@ launch_direct (guestfs_h *g, void *datav, const char *arg)
#ifdef __aarch64__
if (has_kvm && !force_tcg)
append_list ("gic-version=host");
+#endif
+#ifdef __powerpc64__
+ append_list ("cap-htm=off");
#endif
append_list_format ("accel=%s", !force_tcg ? "kvm:tcg" : "tcg");
} end_list ();
diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c
index 4840...
2018 Sep 03
1
[PATCH v2] ppc64le: Use -machine cap-htm=off unconditionally
v1 was here:
https://www.redhat.com/archives/libguestfs/2018-September/thread.html#00000
v2:
- Make conditional on qemu >= 2.11.2 and libvirt >= 4.6.0.
- Fix the libvirt XML to match what went upstream.
Still untested.
Rich.
2018 Sep 03
0
[PATCH v3] ppc64le: Use -machine cap-htm=off unconditionally (RHBZ#1614948).
...ertions(+)
diff --git a/lib/launch-direct.c b/lib/launch-direct.c
index 47e8f37de..e99c33347 100644
--- a/lib/launch-direct.c
+++ b/lib/launch-direct.c
@@ -523,6 +523,10 @@ launch_direct (guestfs_h *g, void *datav, const char *arg)
#ifdef __aarch64__
if (has_kvm && !force_tcg)
append_list ("gic-version=host");
+#endif
+#ifdef __powerpc64__
+ if (guestfs_int_version_ge (&data->qemu_version, 2, 11, 2))
+ append_list ("cap-htm=off");
#endif
append_list_format ("accel=%s", !force_tcg ? "kvm:tcg" : "tcg");
} end_li...
2017 Sep 12
9
[PATCH v2 0/5] launch: direct: Disable qemu locking when opening drives readonly (RHBZ#1417306)
Patches 1-4 are almost the same as they are when previously posted
here:
https://www.redhat.com/archives/libguestfs/2017-September/msg00039.html
Patch 5 actually uses the mandatory locking test to turn off locking
in the narrow case where a drive is opened readonly, and then only for
the drive being inspected.
Passes ordinary tests (‘check-direct’ and ‘check-valgrind-direct’).
Rich.
2019 Oct 29
2
[PATCH] fish: add option --blocksize for disks
...tocol.h"
#include "qemuopts.h"
+int blocksize = 0;
+
/* Per-handle data. */
struct backend_direct_data {
pid_t pid; /* Qemu PID. */
@@ -315,6 +317,8 @@ add_drive (guestfs_h *g, struct backend_direct_data *data,
start_list ("-device") {
append_list ("scsi-hd");
append_list_format ("drive=hd%zu", i);
+ append_list_format ("physical_block_size=%d", blocksize);
+ append_list_format ("logical_block_size=%d", blocksize);
if (drv->disk_label)
append_list_format ("seria...