search for: append_lin

This appends a single line to a file, with some cleverness involving guessing the right line endings to use. Also adds a test. --- builder/test-virt-builder.sh | 57 +++++++++++++++++++++++++++++++++++- customize/Makefile.am | 2 ++ customize/append_line.ml | 70 ++++++++++++++++++++++++++++++++++++++++++++ customize/append_line.mli | 20 +++++++++++++ customize/customize_run.ml | 11 +++++++ generator/customize.ml | 34 +++++++++++++++++++++ 6 files changed, 193 insertions(+), 1 deletion(-) create mode 100644 customize/append_line...

Doing this allows us to remove the Customize_utils module completely, since it becomes empty. Rich.

...der/index.ml | 19 ++++--------------- builder/index_parser.ml | 3 +-- builder/list_entries.ml | 27 +++++++-------------------- builder/simplestreams_parser.ml | 3 +-- common/mltools/curl.ml | 4 ++-- common/mlvisit/visit_tests.ml | 4 ++-- customize/append_line.ml | 4 ++-- customize/customize_main.ml | 4 +--- daemon/inspect.ml | 2 +- daemon/inspect_fs.ml | 7 +++---- daemon/inspect_types.ml | 9 ++++----- dib/output_format.ml | 2 +- generator/GObject.ml | 15 +++++++-------- gene...

...+++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/customize/customize_run.ml b/customize/customize_run.ml index 5564684b4..3dcf755eb 100644 --- a/customize/customize_run.ml +++ b/customize/customize_run.ml @@ -27,7 +27,9 @@ open Customize_cmdline open Password open Append_line -let run (g : Guestfs.guestfs) root (ops : ops) = +module G = Guestfs + +let run (g : G.guestfs) root (ops : ops) = (* Is the host_cpu compatible with the guest arch? ie. Can we * run commands in this guest? *) @@ -89,7 +91,7 @@ exec >>%s 2>&1 debug "running co...

...ommon/mltools/tools_utils_tests.ml common/mltools/urandom.ml common/mltools/xpath_helpers.ml common/mlutils/c_utils.ml -common/mlutils/c_utils_unit_tests.ml common/mlutils/unix_utils.ml common/mlv2v/uefi.ml common/mlvisit/visit.ml -common/mlvisit/visit_tests.ml common/mlxml/xml.ml customize/append_line.ml customize/crypt.ml -- 2.24.1

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

Miscellaneous refactoring, but the main one is to rename mllib/ as common/mltools/ Rich.

This patch series adds a new virt-sysprep operation to offline unenroll a guest from FreeIPA. It does so by removing some configuration files and certificates. It requires a change in libguestfs-common before the series is applied. Pino Toscano (4): customize: port do_run to run_in_guest_command sysprep: add a update_system_ca_store side effect sysprep: ca-certificates: request system CA

...t; common/mlstdutils}/stringMap.ml | 0 {mllib => common/mlstdutils}/stringMap.mli | 0 configure.ac | 3 +- customize/Makefile.am | 8 +- customize/SELinux_relabel.ml | 3 +- customize/append_line.ml | 1 + customize/customize_main.ml | 3 +- customize/customize_run.ml | 3 +- customize/firstboot.ml | 1 + customize/hostname.ml | 1 + customize/password.ml...

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

I got a little way into this. The two attached patches are preliminary work. My proposed split is: libguestfs.git common -> git submodule libguestfs-common.git generator/ lib/ all language bindings C based tools (eg. virt-df, virt-edit, guestfish) guestfs-tools.git common -> git submodule libguestfs-common.git

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

If the connection is not local, paths of disks will refer to the remote host, which were mistakenly handled as local paths (in the best case failing to open a non-existing disk, and in the worst case opening a different disk!). In case the disks are remote resources like ssh or ceph, nothing guarantees that the hostname can be reached from the local machine, or even that it is actually the same on

Hopefully this time ...

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

...A 02110-1301 USA. + *) + +val libdir : string +(** The configure value [@libdir@] (fully expanded into a path). *) diff --git a/customize/Makefile.am b/customize/Makefile.am index 9e82039b5..18f4dce44 100644 --- a/customize/Makefile.am +++ b/customize/Makefile.am @@ -38,6 +38,7 @@ SOURCES_MLI = \ append_line.mli \ crypt.mli \ customize_cmdline.mli \ + customize_main.mli \ customize_run.mli \ firstboot.mli \ hostname.mli \ diff --git a/customize/customize_main.mli b/customize/customize_main.mli new file mode 100644 index 000000000..9da42fded --- /dev/null +++ b/customize/customize_main.mli @@...

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 Thanks: Tomáš Golembiovský --- v2v/virt-v2v.pod | 38 ++++++++++++++++++++++++++------------ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..0943bf305 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,32 @@ that

See this bug for background information: https://bugzilla.redhat.com/show_bug.cgi?id=1350465 --- v2v/virt-v2v.pod | 39 +++++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/v2v/virt-v2v.pod b/v2v/virt-v2v.pod index e68d75cf8..93d1a9ecd 100644 --- a/v2v/virt-v2v.pod +++ b/v2v/virt-v2v.pod @@ -1909,18 +1909,33 @@ that guest through the RHV-M UI,

This works reliably for me ... Rich.