search for: ao_wav

As promised in the last message, this really tiny patch fixed two bugs: 1) On any given execution of ao_wav_play() only half of the samples get swapped. 2) Opening and closing the driver leaks memory. Please commit soon. Bug #1 is major-bad. --- Stan Seibert <HR NOSHADE> <UL> <LI>TEXT/PLAIN attachment: ao_wav_c.patch </UL> -------------- next part -------------- A non-text...

...h =================================================================== RCS file: /usr/local/cvsroot/ao/include/ao/ao.h,v retrieving revision 1.12 diff -u -r1.12 ao.h --- include/ao/ao.h 2001/05/06 00:13:59 1.12 +++ include/ao/ao.h 2001/05/09 01:39:18 @@ -76,6 +76,7 @@ #define AO_NULL 0 #define AO_WAV 1 #define AO_RAW 2 +#define AO_AU 3 /* --- Functions --- */ Index: src/Makefile.am =================================================================== RCS file: /usr/local/cvsroot/ao/src/Makefile.am,v retrieving revision 1.5 diff -u -r1.5 Makefile.am --- src/Makefile.am 2001/05/0...

...trcmp(value, "native")) internal->byte_order = AO_FMT_NATIVE; else if (!strcmp(value, "big")) @@ -91,7 +94,8 @@ internal->byte_order = AO_FMT_LITTLE; else return 0; /* Bad option value */ - } + } else + return 0; return 1; } diff -ur libao-0.8.5/src/ao_wav.c libao-0.8.5.new/src/ao_wav.c --- libao-0.8.5/src/ao_wav.c 2001-09-05 21:34:12.000000000 +0200 +++ libao-0.8.5.new/src/ao_wav.c 2004-10-22 12:58:25.000000000 +0200 @@ -87,6 +87,7 @@ "wav", "Aaron Holtzman <aholtzma@ess.engr.uvic.ca>", "Sends output to a .wav fi...

I'm also working on writing the raw driver I mentioned in the last email, but noticed that Jack has rearranged some of the guts of ao since I last looked at it. In ao/include/ao/ao.h you define AO_NULL and AO_WAV to be 0 and 1, respectively. If I want to add a raw driver that is compiled into the main library, can I just add #define AO_RAW 2 and then modify ao_initialize to put ao_raw into the driver tree? --- Stan Seibert --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project h...

...s Only in libao-0.8.2-new/src: Makefile Only in libao-0.8.2-new/src: ao_au.lo Only in libao-0.8.2-new/src: ao_au.o Only in libao-0.8.2-new/src: ao_null.lo Only in libao-0.8.2-new/src: ao_null.o Only in libao-0.8.2-new/src: ao_raw.lo Only in libao-0.8.2-new/src: ao_raw.o Only in libao-0.8.2-new/src: ao_wav.lo Only in libao-0.8.2-new/src: ao_wav.o Only in libao-0.8.2-new/src: audio_out.lo Only in libao-0.8.2-new/src: audio_out.o Only in libao-0.8.2-new/src: config.lo Only in libao-0.8.2-new/src: config.o Only in libao-0.8.2-new/src: libao.la Only in libao-0.8.2-new/src/plugins: Makefile Only in libao-...

...id *handle; - handle = dlopen(plugin_file, RTLD_NOW); + handle = dlopen(plugin_file, DL_LAZY); if (handle) { dt = (driver_tree_t *)malloc(sizeof(driver_tree_t)); if (!dt) return NULL; $NetBSD: patch-ad,v 1.1 2001/03/16 10:10:35 wiz Exp $ --- src/ao_wav.c.orig Sat Feb 24 02:31:46 2001 +++ src/ao_wav.c @@ -221,7 +221,7 @@ /* Swap the bytes into the swap buffer (so we don't mess up the output_samples buffer) */ - for(i = 0; i < num_bytes/2; i+=2) { + for(i = 0; i < num_bytes; i+=2) {...

...d the byte-order changes that don't make sense. (Thanks Michael for pointing out the error!) As for the byte-order changes, since some output modules don't have the option to set the sample byte-order, I would like to standardize libao and ogg123 on native byte-order. Will this break the ao_wav.c patches you just submitted, Michael? If there aren't any objections, I'll send the patch to fix the byte-order problem on Monday. --- Stan Seibert Index: vorbis-tools/libao/ao_alsa.c =================================================================== RCS file: /usr/local/cvsroo...

I'm reordering the code in ao_wav.c that writes wav files to prevent the problem we had earlier. If ogg123 was improperly terminated (Segfault, kill -9, etc.), the output wav file was not even recognizable because the header was totally blank. I have found that at the start of playback (from libao's perspective), I know all...

...ts, which make some compilers choke (e.g., sun Forte 6). Although C++-style comments are now part of the C standard, it will take a while for vendors to catch up. To be as portable as possible, C++ style comments should not be used in C code for a while yet. The same thing also happens on ao/src/ao_wav.c lines 147, 181. --> Solution: change (ao/src/audio_out.c:284,307) and (ao/src/ao_wav.c:147,181) to use C-style comments. vorbis-tools module =================== - vorbis-tools/vorbiscomment/vorbiscomment.c line 208 has a C++ style comment. --> Solution: change vorbis-tools/vorbiscom...