search for: any_layout

On Mon, Jan 26, 2015 at 10:35:17PM -0800, Nicholas A. Bellinger wrote: > Hi MST & Paolo, > > So I'm currently working on vhost-scsi support for ANY_LAYOUT, and > wanted to verify some assumptions based upon your earlier emails.. > > *) When ANY_LAYOUT is negotiated by vhost-scsi, it's expected that > virtio-scsi request + response headers will (always..?) be within a > single iovec. Do you mean a single struct iovec - as opposed...

On Mon, Jan 26, 2015 at 10:35:17PM -0800, Nicholas A. Bellinger wrote: > Hi MST & Paolo, > > So I'm currently working on vhost-scsi support for ANY_LAYOUT, and > wanted to verify some assumptions based upon your earlier emails.. > > *) When ANY_LAYOUT is negotiated by vhost-scsi, it's expected that > virtio-scsi request + response headers will (always..?) be within a > single iovec. Do you mean a single struct iovec - as opposed...

ANY_LAYOUT is a compatibility feature. It's implied for VERSION_1 devices, and non-transitional devices might not offer it. Change code to behave accordingly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)...

ANY_LAYOUT is a compatibility feature. It's implied for VERSION_1 devices, and non-transitional devices might not offer it. Change code to behave accordingly. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)...

On 2018?06?08? 12:46, Michael S. Tsirkin wrote: > On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: >> This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if >> a userpsace want to enable VRITIO_F_ANY_LAYOUT, >> VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will >> break networking. > What breaks networking exactly? VHOST_NET supported ANY_LAYOUT > from day one. For this reason it does not need...

On 2018?06?08? 12:46, Michael S. Tsirkin wrote: > On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: >> This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if >> a userpsace want to enable VRITIO_F_ANY_LAYOUT, >> VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will >> break networking. > What breaks networking exactly? VHOST_NET supported ANY_LAYOUT > from day one. For this reason it does not need...

...10:12, Michael S. Tsirkin wrote: > On Fri, Jun 08, 2018 at 01:07:09PM +0800, Jason Wang wrote: >> >> On 2018?06?08? 12:46, Michael S. Tsirkin wrote: >>> On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: >>>> This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if >>>> a userpsace want to enable VRITIO_F_ANY_LAYOUT, >>>> VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will >>>> break networking. >>> What breaks networking exactly? VHOST_NET supported ANY_LAYOUT >>> from da...

From: "Michael S. Tsirkin" <mst at redhat.com> Date: Wed, 15 Jul 2015 15:26:19 +0300 > ANY_LAYOUT is a compatibility feature. It's implied > for VERSION_1 devices, and non-transitional devices > might not offer it. Change code to behave accordingly. > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Applied.

On Fri, Jun 08, 2018 at 01:07:09PM +0800, Jason Wang wrote: > > > On 2018?06?08? 12:46, Michael S. Tsirkin wrote: > > On Fri, Jun 08, 2018 at 11:50:42AM +0800, Jason Wang wrote: > > > This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if > > > a userpsace want to enable VRITIO_F_ANY_LAYOUT, > > > VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will > > > break networking. > > What breaks networking exactly? VHOST_NET supported ANY_LAYOUT > > from day one. For t...

On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > Wire up virtio-blk to provide different feature bit sets depending > on whether legacy or v1.0 has been requested. > > Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> So we need some way for devices to tell transports not to negotiate rev 1. Does clearing VERSION_1 have this effect? > --- > hw/block/virtio-blk.c | 19 +++++++++++++++++++ > 1 file changed, 19 inser...

On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > Wire up virtio-blk to provide different feature bit sets depending > on whether legacy or v1.0 has been requested. > > Note that VERSION_1 is still disabled due to missing ANY_LAYOUT support. > > Signed-off-by: Cornelia Huck <cornelia.huck at de.ibm.com> So we need some way for devices to tell transports not to negotiate rev 1. Does clearing VERSION_1 have this effect? > --- > hw/block/virtio-blk.c | 19 +++++++++++++++++++ > 1 file changed, 19 inser...

This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if a userpsace want to enable VRITIO_F_ANY_LAYOUT, VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will break networking. Fixing this by safely removing VHOST_NET_F_VIRTIO_NET_HDR support. There should be very few or even no userspace can use this. Further cleanups cou...

This feature bit is duplicated with VIRTIO_F_ANY_LAYOUT, this means if a userpsace want to enable VRITIO_F_ANY_LAYOUT, VHOST_NET_F_VIRTIO_NET_HDR will be implied too. This is wrong and will break networking. Fixing this by safely removing VHOST_NET_F_VIRTIO_NET_HDR support. There should be very few or even no userspace can use this. Further cleanups cou...

...er to the number of protection bytes in the command. > This resulted in vhost_scsi mis-calculating the size of the protection > SGL in vhost_scsi_calc_sgls(), and including both the protection and > data SG entries in the protection SGL. > > Fixes: 09b13fa8c1a1 ("vhost/scsi: Add ANY_LAYOUT support in vhost_scsi_handle_vq") > Signed-off-by: Greg Edwards <gedwards at ddn.com> Any thoughts on this patch? > --- > drivers/vhost/scsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c &g...

On Thu, 27 Nov 2014 18:18:25 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Thu, Nov 27, 2014 at 05:06:51PM +0100, Cornelia Huck wrote: > > So we should have a per-device callback into the transport layer, say > > check_legacy()? > > I would just have 2 masks: legacy_features and features. But these belong to the device type and the transport

On Thu, 27 Nov 2014 18:18:25 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Thu, Nov 27, 2014 at 05:06:51PM +0100, Cornelia Huck wrote: > > So we should have a per-device callback into the transport layer, say > > check_legacy()? > > I would just have 2 masks: legacy_features and features. But these belong to the device type and the transport

...e layouts >> > and devices came to rely on it, despite this specification >> > wording. It is thus recommended that drivers be conservative in >> > their assumptions, unless specific device features indicate that >> > general layout is permitted using VIRTIO_F_ANY_LAYOUT. In >> > addition, some implementations may have large-but-reasonable >> > restrictions on total descriptor size (such as based on IOV_MAX >> > in the host OS). This has not been a problem in practice: little >> > sympathy will be given to drivers which create un...

...e layouts >> > and devices came to rely on it, despite this specification >> > wording. It is thus recommended that drivers be conservative in >> > their assumptions, unless specific device features indicate that >> > general layout is permitted using VIRTIO_F_ANY_LAYOUT. In >> > addition, some implementations may have large-but-reasonable >> > restrictions on total descriptor size (such as based on IOV_MAX >> > in the host OS). This has not been a problem in practice: little >> > sympathy will be given to drivers which create un...

Include all endian conversions as required by virtio 1.0. Don't set virtio 1.0 yet, since that requires ANY_LAYOUT which we don't yet support. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/scsi.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index a17f118..01c01cb 100644 --- a/drivers...

Include all endian conversions as required by virtio 1.0. Don't set virtio 1.0 yet, since that requires ANY_LAYOUT which we don't yet support. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- drivers/vhost/scsi.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index a17f118..01c01cb 100644 --- a/drivers...