search for: amsden

...mi_basic_apic_ops; > > > > Yinghai, Looking more closely at this, based on my understanding this might be > > wrong for VMI. Correct patch should be as follows. Any comments? > > so you mean icr related will still use default native member? > > YH Nacked-by: Zachary Amsden <zach at vmware.com> What are you doing here and why aren't you cc-ing the maintainers? Thanks, Zach

...mi_basic_apic_ops; > > > > Yinghai, Looking more closely at this, based on my understanding this might be > > wrong for VMI. Correct patch should be as follows. Any comments? > > so you mean icr related will still use default native member? > > YH Nacked-by: Zachary Amsden <zach at vmware.com> What are you doing here and why aren't you cc-ing the maintainers? Thanks, Zach

As suggested by Andi Kleen, don't allocate a GDT page if there is already one present. Needed for CPU hotplug. Signed-off-by: Zachary Amsden <zach@vmware.com> Index: linux-2.6.14-rc1/arch/i386/kernel/smpboot.c =================================================================== --- linux-2.6.14-rc1.orig/arch/i386/kernel/smpboot.c 2005-09-20 20:38:22.000000000 -0700 +++ linux-2.6.14-rc1/arch/i386/kernel/smpboot.c 2005-09-28 12:54:08...

As suggested by Andi Kleen, don't allocate a GDT page if there is already one present. Needed for CPU hotplug. Signed-off-by: Zachary Amsden <zach@vmware.com> Index: linux-2.6.14-rc1/arch/i386/kernel/smpboot.c =================================================================== --- linux-2.6.14-rc1.orig/arch/i386/kernel/smpboot.c 2005-09-20 20:38:22.000000000 -0700 +++ linux-2.6.14-rc1/arch/i386/kernel/smpboot.c 2005-09-28 12:54:08...

S.Çağlar Onur wrote: > 17 Eki 2006 Sal 01:21 tarihinde, S.Çağlar Onur şunları yazmıştı: > >> 17 Eki 2006 Sal 01:17 tarihinde, Zachary Amsden şunları yazmıştı: >> >>> My nasty quick patch might not apply - the only tree I've got is a very >>> hacked 2.6.18-rc6-mm1+local-patches thing, but the fix should be obvious >>> enough. >>> >> Ok, I'll test and report back... >&...

S.Çağlar Onur wrote: > 17 Eki 2006 Sal 01:21 tarihinde, S.Çağlar Onur şunları yazmıştı: > >> 17 Eki 2006 Sal 01:17 tarihinde, Zachary Amsden şunları yazmıştı: >> >>> My nasty quick patch might not apply - the only tree I've got is a very >>> hacked 2.6.18-rc6-mm1+local-patches thing, but the fix should be obvious >>> enough. >>> >> Ok, I'll test and report back... >&...

...on't put unexplained comments about kmalloc in code which doesn't do dynamic allocation. And you don't leave stray warnings around for no good reason. Also, when possible, it is better to use block scoped variables because gcc can sometime generate better code. Signed-off-by: Zachary Amsden <zach@vmware.com> diff -r ed741f57dae8 arch/i386/kernel/cpu/mcheck/p4.c --- a/arch/i386/kernel/cpu/mcheck/p4.c Fri Apr 06 14:29:52 2007 -0700 +++ b/arch/i386/kernel/cpu/mcheck/p4.c Fri Apr 06 14:43:24 2007 -0700 @@ -124,12 +124,9 @@ static void intel_init_thermal(struct cp /* P4/Xeon Ex...

...on't put unexplained comments about kmalloc in code which doesn't do dynamic allocation. And you don't leave stray warnings around for no good reason. Also, when possible, it is better to use block scoped variables because gcc can sometime generate better code. Signed-off-by: Zachary Amsden <zach@vmware.com> diff -r ed741f57dae8 arch/i386/kernel/cpu/mcheck/p4.c --- a/arch/i386/kernel/cpu/mcheck/p4.c Fri Apr 06 14:29:52 2007 -0700 +++ b/arch/i386/kernel/cpu/mcheck/p4.c Fri Apr 06 14:43:24 2007 -0700 @@ -124,12 +124,9 @@ static void intel_init_thermal(struct cp /* P4/Xeon Ex...

I booted into X11 and have networking working and a kernel compile = running. SMP and PAE should be less than a day away. This completes = the proof of concept, I believe ;) I didn't cc LKML since I didn't want to spam them with graphics. Very = controversial graphics. Hopefully you appreciate the humor. Zach -------------- next part -------------- A non-text attachment was

Add 5-argument handling for paravirt ops patching of PAE functions. Signed-off-by: Zachary Amsden <zach@vmware.com> diff -r dbe11208916f include/asm-i386/paravirt.h --- a/include/asm-i386/paravirt.h Thu Apr 19 11:40:55 2007 -0700 +++ b/include/asm-i386/paravirt.h Thu Apr 19 12:04:16 2007 -0700 @@ -308,10 +308,9 @@ unsigned paravirt_patch_insns(void *site * return value handling from wi...

Add 5-argument handling for paravirt ops patching of PAE functions. Signed-off-by: Zachary Amsden <zach@vmware.com> diff -r dbe11208916f include/asm-i386/paravirt.h --- a/include/asm-i386/paravirt.h Thu Apr 19 11:40:55 2007 -0700 +++ b/include/asm-i386/paravirt.h Thu Apr 19 12:04:16 2007 -0700 @@ -308,10 +308,9 @@ unsigned paravirt_patch_insns(void *site * return value handling from wi...

...ing kernel static data with GDTs for not-present processors. This could be adapted to drop and reallocate GDTs for CPU hotplug if desired, although the space savings (1 page) are dubious, so I have not implemented that at this time. Testing: 4 way SMP boot-halts, kernel compiles, stress. Zachary Amsden <zach@vmware.com>

...ing kernel static data with GDTs for not-present processors. This could be adapted to drop and reallocate GDTs for CPU hotplug if desired, although the space savings (1 page) are dubious, so I have not implemented that at this time. Testing: 4 way SMP boot-halts, kernel compiles, stress. Zachary Amsden <zach@vmware.com>

Given all the discussion, let's just require NO_HZ when CONFIG_PARAVIRT. Anyone object? Signed-off-by: Chris Wright <chrisw@sous-sol.org> --- --- a/arch/i386/Kconfig Mon Mar 12 11:07:45 2007 -0700 +++ b/arch/i386/Kconfig Mon Mar 12 16:53:14 2007 -0700 @@ -208,7 +208,7 @@ endchoice config PARAVIRT bool "Paravirtualization support (EXPERIMENTAL)" - depends on EXPERIMENTAL

Given all the discussion, let's just require NO_HZ when CONFIG_PARAVIRT. Anyone object? Signed-off-by: Chris Wright <chrisw@sous-sol.org> --- --- a/arch/i386/Kconfig Mon Mar 12 11:07:45 2007 -0700 +++ b/arch/i386/Kconfig Mon Mar 12 16:53:14 2007 -0700 @@ -208,7 +208,7 @@ endchoice config PARAVIRT bool "Paravirtualization support (EXPERIMENTAL)" - depends on EXPERIMENTAL

At the moment, all the places where the LDT are set in the kernel are of the form: set_ldt_desc(cpu, segments, count); load_LDT_desc(); (two instances in asm-i386/desc.h). set_ldt_desc() sets an LDT descriptor in the GDT, and load_LDT_desc() is basically just lldt. These map to the write_gdt_entry and load_ldt_desc paravirt ops. This doesn't work well for Xen, because you set

In general, I/O in a virtual guest is subject to performance problems. = The I/O can not be completed physically, but must be virtualized. This = means trapping and decoding port I/O instructions from the guest OS. = Not only is the trap for a #GP heavyweight, both in the processor and = the hypervisor (which usually has a complex #GP path), but this forces = the hypervisor to decode the

In general, I/O in a virtual guest is subject to performance problems. = The I/O can not be completed physically, but must be virtualized. This = means trapping and decoding port I/O instructions from the guest OS. = Not only is the trap for a #GP heavyweight, both in the processor and = the hypervisor (which usually has a complex #GP path), but this forces = the hypervisor to decode the

Looks to me like the first series of patches should be OK to post now. I propose that: 001-apply-to-page-range.patch 001a-reboot-use-struct.patch 002-sync-bitops.patch 003-remove-ring0-assumptions.patch 004-abstract-asm.patch 005-cpuid-cleanup.patch unfix-fixmap.patch fixmap-bootparam.patch remove-read-hazard-from-cow.patch pte-clear-not-present.patch

In compat mode, the return value here was uninitialized. Signed-off-by: Zachary Amsden <zach@vmware.com> diff -r 1fda49a076ed arch/i386/kernel/sysenter.c --- a/arch/i386/kernel/sysenter.c Fri Apr 06 14:25:09 2007 -0700 +++ b/arch/i386/kernel/sysenter.c Fri Apr 06 14:27:31 2007 -0700 @@ -254,7 +254,7 @@ int arch_setup_additional_pages(struct l { struct mm_struct *mm = curren...