search for: alwaysbreaktemplatedeclarations

Hi guys, Is the current setting of `AlwaysBreakTemplateDeclarations: false` for LLVMStyle intentional? What was the rationale? Some rough counts on the LLVM codebase: same-line: $ git grep -E 'template.*(class|struct).*{' -- '*.h' '*.cpp' | wc -l 214 (most of them are tiny traits classes, like isPodLike or DenseMapInfo) not-same-line: $...

...ed i = 0, e = Uv.size(); i != e; ++i) use(i); } -------------- I would prefer that two pieces of code with similar logical structure to be similarly formatted, as much as reasonable, and I think that always breaking on template declarations is reasonable. clang-format has an option for this (`AlwaysBreakTemplateDeclarations`), but we don't have it enabled currently for LLVM style. Daniel Jasper informs me that the current setting is a carry-over from before the setting was introduced, where it was effectively always "false" (the current setting for LLVM style). I hate to bring up such a microscopic issu...

...use(i); > } > -------------- > > I would prefer that two pieces of code with similar logical structure to be > similarly formatted, as much as reasonable, and I think that always breaking > on template declarations is reasonable. > > clang-format has an option for this (`AlwaysBreakTemplateDeclarations`), but > we don't have it enabled currently for LLVM style. Daniel Jasper informs me > that the current setting is a carry-over from before the setting was > introduced, where it was effectively always "false" (the current setting for > LLVM style). > > I hate to bri...

~~~ Not to be applied, for discussion only ~~~ I think we need some kind of "checkpatch" script to catch all the annoying, nitpicky code style issues that submitters trip up on. I looked at a few scripts that exist, primarily the ones from Linux and qemu (massive and complicated), and libvirt (small and sane). There are a couple of problems: (1) Linux/qemu-style checkpatch only

See previous version: https://www.redhat.com/archives/libguestfs/2016-April/msg00021.html The formatting in this second version isn't too bad. Still a few corner cases to sort out. Rich.