search for: aloni

On Sun, Aug 18, 2013 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > On Sun, Aug 18, 2013 at 11:48:56AM +0300, Dan Aloni wrote: > > On 3.10.7 and x86_64, as a result of sizeof(struct vhost_scsi) being > > 2152960 bytes the allocation failed once on my development machine. > > > > Saw it would be prudent to split the bulk of it, which is the vqs array > > into separately allocated parts....

On Sun, Aug 18, 2013 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > On Sun, Aug 18, 2013 at 11:48:56AM +0300, Dan Aloni wrote: > > On 3.10.7 and x86_64, as a result of sizeof(struct vhost_scsi) being > > 2152960 bytes the allocation failed once on my development machine. > > > > Saw it would be prudent to split the bulk of it, which is the vqs array > > into separately allocated parts....

As vhost scsi device struct is large, if the device is created on a busy system, kzalloc() might fail, so this patch does a fallback to vzalloc(). As vmalloc() adds overhead on data-path, add __GFP_REPEAT to kzalloc() flags to do this fallback only when really needed. Reported-by: Dan Aloni <alonid at stratoscale.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I put this on my vhost fixes branch, intend to merge for 3.12. Dan, could you please confirm this works for you? drivers/vhost/scsi.c | 41 +++++++++++++++++++++++++++-------------- 1 file changed,...

As vhost scsi device struct is large, if the device is created on a busy system, kzalloc() might fail, so this patch does a fallback to vzalloc(). As vmalloc() adds overhead on data-path, add __GFP_REPEAT to kzalloc() flags to do this fallback only when really needed. Reported-by: Dan Aloni <alonid at stratoscale.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- I put this on my vhost fixes branch, intend to merge for 3.12. Dan, could you please confirm this works for you? drivers/vhost/scsi.c | 41 +++++++++++++++++++++++++++-------------- 1 file changed,...

...device struct is large, if the device is > created on a busy system, kzalloc() might fail, so this patch does a > fallback to vzalloc(). > As vmalloc() adds overhead on data-path, add __GFP_REPEAT > to kzalloc() flags to do this fallback only when really needed. > Reported-by: Dan Aloni <alonid at stratoscale.com> > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > --- > I put this on my vhost fixes branch, intend to merge for 3.12. > Dan, could you please confirm this works for you? > drivers/vhost/scsi.c | 41 +++++++++++++++++++++++++++------...

Hi, --- background ---------------------------------------------------- * what the makedumpfile is: To shorten the size of the dumpfile and the time of creating the dumpfile, makedumpfile copies only the necessary pages for analysis to the dumpfile from /proc/vmcore. You can specify the kind of unnecessary pages with dump_level. If you want to shorten the size further, enable the