search for: allowreplace

...tance(StringRef other, unsigned maxEditDistance) and replace the two uses of edit_distance in Sema\SemaLookup.cpp with it. I would much rather just replace edit_distance completely. Compiler writers aren't string-savvy enough to pick between the two algorithms :) > I have ditched the "AllowReplace" argument since it further complicated the logic of an already ~150 lines method for no obvious gain (as far as I could see) and I have also explicited the computations a bit by using named temporaries. Okay. I can't imagine why anyone would want to turn off replacement anyway. > Unfo...

...used in FileCheck and was a bit wary of any side-effect I might introduce there. I have thus created a new method: unsigned StringRef::levenshtein_distance(StringRef other, unsigned maxEditDistance) and replace the two uses of edit_distance in Sema\SemaLookup.cpp with it. I have ditched the "AllowReplace" argument since it further complicated the logic of an already ~150 lines method for no obvious gain (as far as I could see) and I have also explicited the computations a bit by using named temporaries. Unfortunately I have only a Windows machine at hand for the moment and the tests don't...