search for: allow_disk_format_probing

...name); static void selinux_warning (guestfs_h *g, const char *func, const char *selinux_op, const char *data); #endif +/* Return drv->src.format, but if it is NULL, autodetect the format. + * + * libvirt has disabled the feature of detecting the disk format, + * unless the administrator sets allow_disk_format_probing=1 in + * qemu.conf. There is no way to detect if this option is set, so we + * have to do format detection here using qemu-img and pass that to + * libvirt. + * + * This can still be a security issue, so in most cases it is + * recommended the users pass the format to libguestfs which will + * fai...

I had test the command virsh blockcommit, but it failed, with the libvirt version 1.1.0, and qemu version 1.6.0. Is this feature being developing? Thanks root at cvk-31:/vms/images# virsh -v 1.1.0 root at cvk-31:/vms/images# qemu-img -V qemu-img version 1.6.0, Copyright (c) 2004-2008 Fabrice Bellard usage: qemu-img command [command options] root at cvk-31:/vms/images# virsh blockcommit Vmtest

...ailed, with the libvirt version 1.1.0, and qemu version 1.6.0. > Is this feature being developing? Thanks The feature is supported, but you have to use it correctly. In particular, your backing chain MUST label the backing format of all backing files in the image metadata, or you must set 'allow_disk_format_probing' to 1 in /etc/libvirt/qemu.conf (be aware that doing so is a security risk if you use any raw images and have untrustworthy guests). > root@cvk-31:/vms/images# virsh blockcommit Vmtest /vms/images/Vmtest1 --base /vms/image > s/Vmtest1_base --top /vms/images/Vmtest1_base_1 --wait --verbos...

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

...tribute (xo, BAD_CAST "type", BAD_CAST drv_priv->format)); } - else { + else if (drv_priv->protocol == drive_protocol_file) { /* libvirt has disabled the feature of detecting the disk format, * unless the administrator sets allow_disk_format_probing=1 in * qemu.conf. There is no way to detect if this option is set, so we @@ -1129,15 +1170,14 @@ construct_libvirt_xml_disk (guestfs_h *g, * the users pass the format to libguestfs which will faithfully pass * that to libvirt and this function won't be used. */ - for...