Displaying 7 results from an estimated 7 matches for "allow_discards".
2020 Jan 22
2
Re: [PATCH] mltools, options: support --allow-discards when decrypting LUKS devices
On Wed, Jan 22, 2020 at 10:14:38AM +0100, Jan Synacek wrote:
> -val inspect_decrypt : Guestfs.guestfs -> key_store -> unit
> +val inspect_decrypt : Guestfs.guestfs -> ?allow_discards:bool -> key_store -> unit
>
> (** Simple implementation of decryption: look for any [crypto_LUKS]
> partitions and decrypt them, then rescan for VGs. This only works
> for Fedora whole-disk encryption. *)
Documentation here needs a short explanation of what the
new al...
2020 Jan 22
0
[PATCH] mltools, options: support --allow-discards when decrypting LUKS devices
...ternal c_rfc3339_date_time_string : unit -> string = "guestfs_int_mllib_rfc3339_date_time_string"
@@ -650,7 +650,7 @@ let is_btrfs_subvolume g fs =
if g#last_errno () = Guestfs.Errno.errno_EINVAL then false
else raise exn
-let inspect_decrypt g ks =
+let inspect_decrypt g ?(allow_discards = false) ks =
(* Turn the keys in the key_store into a simpler struct, so it is possible
* to read it using the C API.
*)
@@ -664,7 +664,7 @@ let inspect_decrypt g ks =
* function.
*)
c_inspect_decrypt g#ocaml_handle (Guestfs.c_pointer g#ocaml_handle)
- keys_as_list
+ ke...
2020 Jan 27
3
[PATCH v2 1/2] mltools, options: support --allow-discards when decrypting LUKS devices
...ternal c_rfc3339_date_time_string : unit -> string = "guestfs_int_mllib_rfc3339_date_time_string"
@@ -650,7 +650,7 @@ let is_btrfs_subvolume g fs =
if g#last_errno () = Guestfs.Errno.errno_EINVAL then false
else raise exn
-let inspect_decrypt g ks =
+let inspect_decrypt g ?(allow_discards = false) ks =
(* Turn the keys in the key_store into a simpler struct, so it is possible
* to read it using the C API.
*)
@@ -664,7 +664,7 @@ let inspect_decrypt g ks =
* function.
*)
c_inspect_decrypt g#ocaml_handle (Guestfs.c_pointer g#ocaml_handle)
- keys_as_list
+ ke...
2020 Jan 22
0
Re: [PATCH] mltools, options: support --allow-discards when decrypting LUKS devices
On Wed, Jan 22, 2020 at 10:50 AM Richard W.M. Jones <rjones@redhat.com>
wrote:
> On Wed, Jan 22, 2020 at 10:14:38AM +0100, Jan Synacek wrote:
> > -val inspect_decrypt : Guestfs.guestfs -> key_store -> unit
> > +val inspect_decrypt : Guestfs.guestfs -> ?allow_discards:bool ->
> key_store -> unit
> >
> > (** Simple implementation of decryption: look for any [crypto_LUKS]
> > partitions and decrypt them, then rescan for VGs. This only works
> > for Fedora whole-disk encryption. *)
>
> Documentation here needs a sh...
2020 Jan 21
12
[PATCH 0/1] WIP: Support LUKS-encrypted partitions
The following patch attempts to implement sparsification of
LUKS-encrypted partitions. It uses lsblk to pair the underlying LUKS
block device with its mapped name. Also, --allow-discards was added
by default to luks_open().
There are several potential issues that I can think of:
1) If and entire device is encrypted (not just one of more partitions),
the lsblk trick might not work.
2) The
2020 Jan 27
0
[PATCH v2 2/2] sparsify: support LUKS-encrypted partitions
...ce.ml
index 7da83dafd..ade3c6843 100644
--- a/sparsify/in_place.ml
+++ b/sparsify/in_place.ml
@@ -62,7 +62,7 @@ let run disk format ignores zeroes ks =
error ~exit_code:3 (f_"discard/trim is not supported");
(* Decrypt the disks. *)
- inspect_decrypt g ks;
+ inspect_decrypt g ~allow_discards:true ks;
(* Discard non-ignored filesystems that we are able to mount, and
* selected swap partitions.
--
2.24.1
2020 Jan 22
3
[PATCH 1/1] sparsify: support LUKS-encrypted partitions
...ce.ml
index 7da83dafd..ade3c6843 100644
--- a/sparsify/in_place.ml
+++ b/sparsify/in_place.ml
@@ -62,7 +62,7 @@ let run disk format ignores zeroes ks =
error ~exit_code:3 (f_"discard/trim is not supported");
(* Decrypt the disks. *)
- inspect_decrypt g ks;
+ inspect_decrypt g ~allow_discards:true ks;
(* Discard non-ignored filesystems that we are able to mount, and
* selected swap partitions.
--
2.24.1