search for: alias_begin

...look like STL ones should use similar names for the methods (begin(), push_back(), etc...). But different parts of llvm have different opinions on how to handle the related case of classes that are not STL like, but have multiple collections that can be iterated over. * llvm/IR uses global_begin, alias_begin, etc. I.E., singular name + _begin(). * llvm/Object uses begin_symbols, begin_sections, etc. I.E, begin_ + plural name. * others (YAML, LoopIterator) use beginSequence, beginFlowSequence, etc. I would like to propose adding the the format used by llvm/IR to the coding standard since it seems to be...

...ilar names for the methods (begin(), > push_back(), etc...). > > But different parts of llvm have different opinions on how to handle > the related case of classes that are not STL like, but have multiple > collections that can be iterated over. > > * llvm/IR uses global_begin, alias_begin, etc. I.E., singular name + > _begin(). > * llvm/Object uses begin_symbols, begin_sections, etc. I.E, begin_ + > plural name. > * others (YAML, LoopIterator) use beginSequence, beginFlowSequence, etc. > > I would like to propose adding the the format used by llvm/IR to the > co...

...ar names for the methods (begin(), > push_back(), etc...). > > But different parts of llvm have different opinions on how to handle > the related case of classes that are not STL like, but have multiple > collections that can be iterated over. > > * llvm/IR uses global_begin, alias_begin, etc. I.E., singular name + _begin(). > * llvm/Object uses begin_symbols, begin_sections, etc. I.E, begin_ + > plural name. > * others (YAML, LoopIterator) use beginSequence, beginFlowSequence, etc. > > I would like to propose adding the the format used by llvm/IR to the > coding...

On Thu, Jun 4, 2015 at 3:58 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > > > Personally, I think the right approach is to add a bool to > createGlobalDCEPass defaulting to true named something like > IsAfterInlining. In most standard pass pipelines, GlobalDCE runs after > inlining for obvious reasons, so the default makes sense. The special case > is

On Thu, Jun 4, 2015 at 5:33 PM, Reid Kleckner <rnk at google.com> wrote: > On Thu, Jun 4, 2015 at 5:17 PM, Teresa Johnson <tejohnson at google.com> wrote: >> >> Agreed. Although I assume you mean invoke the new pass under a >> ThinLTO-only option so that avail extern are not dropped in the >> compile pass before the LTO link? > > > No, this pass

...(); I != E; ++I) { + if (!I->hasAvailableExternallyLinkage()) + continue; + if (!I->isDeclaration()) + I->deleteBody(); + I->removeDeadConstantUsers(); + NumFunctions++; + } + + // Drop targets of available externally aliases. + for (Module::alias_iterator I = M.alias_begin(), E = M.alias_end(); I != E; + ++I) { + if (!I->hasAvailableExternallyLinkage()) + continue; + I->setAliasee(nullptr); + I->removeDeadConstantUsers(); + NumAliases++; + } + + return Changed; +} Index: lib/Transforms/IPO/PassManagerBuilder.cpp =====================...