Displaying 5 results from an estimated 5 matches for "aicommander".
2014 Nov 06
2
[PATCH] float_cast: Fix MSVC ARM build
Yeah that's the one.
On Nov 6, 2014 1:23 PM, "Tristan Matthews" <le.businessman at gmail.com> wrote:
> On Thu, Nov 6, 2014 at 4:20 PM, Cameron Gutman <aicommander at gmail.com>
> wrote:
> > _WIN32, WIN32, WIN64, and _WIN64 are the wrong definitions to be gating
> this
> > on in the first place. They aren't at all meant to be x86/x86-64
> specific.
> > At best, they're 32-bit/64-bit specific, but that's not the intend...
2014 Nov 06
0
[PATCH] float_cast: Fix MSVC ARM build
...6/11/14 04:26 PM, Cameron Gutman wrote:
> Yeah that's the one.
>
> On Nov 6, 2014 1:23 PM, "Tristan Matthews" <le.businessman at gmail.com
> <mailto:le.businessman at gmail.com>> wrote:
>
> On Thu, Nov 6, 2014 at 4:20 PM, Cameron Gutman
> <aicommander at gmail.com <mailto:aicommander at gmail.com>> wrote:
> > _WIN32, WIN32, WIN64, and _WIN64 are the wrong definitions to be
> gating this
> > on in the first place. They aren't at all meant to be x86/x86-64
> specific.
> > At best, they'r...
2014 Nov 06
2
[PATCH] float_cast: Fix MSVC ARM build
_WIN32, WIN32, WIN64, and _WIN64 are the wrong definitions to be gating
this on in the first place. They aren't at all meant to be x86/x86-64
specific. At best, they're 32-bit/64-bit specific, but that's not the
intended use in the code. The correct definitions are _M_IX86 and _M_X64,
as Martin said.
I sent a patch to this ML that fixed these a few months ago but it was
2014 Nov 06
0
[PATCH] float_cast: Fix MSVC ARM build
On Thu, Nov 6, 2014 at 4:20 PM, Cameron Gutman <aicommander at gmail.com> wrote:
> _WIN32, WIN32, WIN64, and _WIN64 are the wrong definitions to be gating this
> on in the first place. They aren't at all meant to be x86/x86-64 specific.
> At best, they're 32-bit/64-bit specific, but that's not the intended use in
> the code. The c...
2014 Apr 07
0
MSVC ARM compilation issue with patch
I?ve been working on a Windows Phone 8 app that uses libopus for audio decoding. I used the included MSVC project files by switching the toolchain to WP8?s.
I ran into a compilation issue in float_cast.h where it was trying to use the MSVC x86 code path (with x86 assembly). This was because WIN32 and _WIN32 are defined in ARM projects for WP8 libraries (for source compatibility reasons I assume).