search for: ahern

...s the case of XDP. Fixes: 3f93522ffab2d ("virtio-net: switch off offloads on demand if possible on XDP set") Reported-by: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Pavel Popa <pashinho1990 at gmail.com> Cc: David Ahern <dsahern at gmail.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 3e2c041d76ac..9b5ace538824 100644 --- a/drivers/n...

...s the case of XDP. Fixes: 3f93522ffab2d ("virtio-net: switch off offloads on demand if possible on XDP set") Reported-by: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Jesper Dangaard Brouer <brouer at redhat.com> Cc: Pavel Popa <pashinho1990 at gmail.com> Cc: David Ahern <dsahern at gmail.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 3e2c041d76ac..9b5ace538824 100644 --- a/drivers/n...

Hi: The openssh suite of commands have an option to specify address (e.g, ListenAddress for sshd) but I do not see support for bind-to-interface. The motivating use case for me is using openssh commands (sshd, ssh, scp, sftp) with the recent VRF capability added to the Linux kernel. The VRF design relies on the bind-to-interface option to select the correct routing tables. Before I started

On 11/23/15 4:50 PM, Damien Miller wrote: > On Sun, 22 Nov 2015, David Ahern wrote: > >> Hi: >> >> The openssh suite of commands have an option to specify address (e.g, >> ListenAddress for sshd) but I do not see support for bind-to-interface. >> >> The motivating use case for me is using openssh commands (sshd, ssh, scp, >> sftp...

David Ahern <dsahern at gmail.com> writes: > On 2/4/19 3:53 AM, Jesper Dangaard Brouer wrote: >> On Sat, 2 Feb 2019 14:27:26 -0700 >> David Ahern <dsahern at gmail.com> wrote: >> >>> On 1/31/19 1:15 PM, Jesper Dangaard Brouer wrote: >>>>> >>>&...

From: David Ahern <dsahern at gmail.com> Date: Wed, 4 Apr 2018 11:21:54 -0600 > It is a netdev so there is no reason to have a separate ip command to > inspect it. 'ip link' is the right place. I agree on this. What I really don't understand still is the use case... really. So there are c...

From: David Ahern <dsahern at gmail.com> Date: Wed, 4 Apr 2018 11:21:54 -0600 > It is a netdev so there is no reason to have a separate ip command to > inspect it. 'ip link' is the right place. I agree on this. What I really don't understand still is the use case... really. So there are c...

Hi: Please review the patches that tries to fix sevreal issues of virtio-net mergeable XDP. Thanks Jason Wang (4): virtio-net: correctly redirect linearized packet virtio-net: correctly transmit XDP buff after linearizing virtio-net: reset num_buf to 1 after linearizing packet virito-net: fix leaking page for gso packet during mergeable XDP drivers/net/virtio_net.c | 21

In realpath.c at line 182 left_len = strlcat(symlink, left, sizeof(left)); should be left_len = strlcat(symlink, left, sizeof(symlink)); It's a benign issue because both arrays are the same size. And I can't imagine that ever changing. But it's inconsistent, not to mention throwing compiler warnings on OS X.

On Wed, Apr 4, 2018 at 10:21 AM, David Ahern <dsahern at gmail.com> wrote: > On 4/4/18 1:36 AM, Siwei Liu wrote: >> On Tue, Apr 3, 2018 at 6:04 PM, David Ahern <dsahern at gmail.com> wrote: >>> On 4/3/18 9:42 AM, Jiri Pirko wrote: >>>>> >>>>> There are other use cases that want to hi...

...zed packet was redirected by XDP, we should not go for the err path which will try to pop buffers for the next packet and increase the drop counter. Fixing this by just drop the page refcnt for the original page. Fixes: 186b3c998c50 ("virtio-net: support XDP_REDIRECT") Reported-by: David Ahern <dsahern at gmail.com> Tested-by: David Ahern <dsahern at gmail.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 77042...

David Ahern <dsahern at gmail.com> writes: > On 4/18/19 8:24 AM, Toke H?iland-J?rgensen wrote: >>>> >>> >>> Understood. Hopefully in March I will get some time to come back to this >>> and propose an idea on what I would like to see - namely, the admin has >&...

David Ahern <dsahern at gmail.com> writes: > On 4/18/19 8:24 AM, Toke H?iland-J?rgensen wrote: >>>> >>> >>> Understood. Hopefully in March I will get some time to come back to this >>> and propose an idea on what I would like to see - namely, the admin has >&...

...meout: wait_process() could call check_timeout() before calling msleep(). When the timeout has been exceeded, rsync would call _exit_cleanup and kill_all would take care of the child. You could make this check optional so that only calls from client_run do the check. just a thought. -- david ahern

...30PM +0900, Toshiaki Makita wrote: >>>> Previously virtnet_xdp_xmit() did not account for device tx counters, >>>> which caused confusions. >>>> To be consistent with SKBs, account them on freeing xdp_frames. >>>> >>>> Reported-by: David Ahern <dsahern at gmail.com> >>>> Signed-off-by: Toshiaki Makita <makita.toshiaki at lab.ntt.co.jp> >>> >>> Well we count them on receive so I guess it makes sense for consistency >>> >>> Acked-by: Michael S. Tsirkin <mst at redhat.com>...

Hi: Please review the patches that tries to fix sevreal issues of virtio-net mergeable XDP. Changes from V1: - check against 1 before decreasing instead of resetting to 1 - typoe fixes Jason Wang (4): virtio-net: correctly redirect linearized packet virtio-net: correctly transmit XDP buff after linearizing virtio-net: correctly check num_buf during err path virtio-net: fix leaking page

...run posttransfer script = /some/other/command The commands are exec'd (not run through system() or popen()) and the inputs are the list of files (and directories) that are being synched (from struct file_list *flist). If the pretransfer script fails the synch is stopped. -- david ahern -------------- next part -------------- Only in rsync-2.5.6: config.h Only in rsync-2.5.6: config.log Only in rsync-2.5.6: config.status Common subdirectories: rsync-2.5.6.orig/doc and rsync-2.5.6/doc diff --exclude='*.o' -b --context rsync-2.5.6.orig/errcode.h rsync-2.5.6/errcode.h *** rsy...

On Tue, Apr 3, 2018 at 6:04 PM, David Ahern <dsahern at gmail.com> wrote: > On 4/3/18 9:42 AM, Jiri Pirko wrote: >>> >>> There are other use cases that want to hide a device from userspace. I >> >> What usecases do you have in mind? > > As mentioned in a previous response some kernel drivers creat...

On Tue, Apr 3, 2018 at 6:04 PM, David Ahern <dsahern at gmail.com> wrote: > On 4/3/18 9:42 AM, Jiri Pirko wrote: >>> >>> There are other use cases that want to hide a device from userspace. I >> >> What usecases do you have in mind? > > As mentioned in a previous response some kernel drivers creat...

From: David Ahern <dsahern at gmail.com> Date: Wed, 4 Apr 2018 11:37:52 -0600 > Networking vendors have out of tree kernel modules. Those modules use a > netdev (call it a master netdev, a control netdev, cpu port, whatever) > to pull packets from the ASIC and deliver to virtual netdevices > repre...