search for: af_packet

...18 17:41:30 tadorne kernel: task `ip' exit_signal 17 in reparent_to_init in warnings logs Oct 18 17:31:16 tadorne kernel: kernel BUG at revoke.c:307! Oct 18 17:31:16 tadorne kernel: invalid operand: 0000 Oct 18 17:31:16 tadorne kernel: CPU: 0 Oct 18 17:31:16 tadorne kernel: EIP: 0010:[af_packet:__insmod_af_packet_O/lib/modules/2.4.8-26mdk/kernel/net/pac+-616196/96] Oct 18 17:31:16 tadorne kernel: EIP: 0010:[<c90428fc>] Oct 18 17:31:16 tadorne kernel: EFLAGS: 00210286 Oct 18 17:31:16 tadorne kernel: eax: 0000001c ebx: c46b9b40 ecx: c025dddc edx: 00002a05 Oct 18 17:31:16 tado...

On Wed, Sep 23, 2015 at 07:45:08PM +0100, David Woodhouse wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the > hard-coded 'false' for little-endian. > > This restores the ABI to match 4...

On Wed, Sep 23, 2015 at 07:45:08PM +0100, David Woodhouse wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the > hard-coded 'false' for little-endian. > > This restores the ABI to match 4...

On Wed, 23 Sep 2015 19:45:08 +0100 David Woodhouse <dwmw2 at infradead.org> wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > Hi David, Oops my bad... I obviously overlooked this one when adding cross-endian support. > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the...

On Wed, 23 Sep 2015 19:45:08 +0100 David Woodhouse <dwmw2 at infradead.org> wrote: > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > accessors") accidentally changed the virtio_net header used by > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > Hi David, Oops my bad... I obviously overlooked this one when adding cross-endian support. > Since virtio_legacy_is_little_endian() is a very long identifier, > define a VIO_LE macro and use that throughout the code instead of the...

...0, Greg Kurz wrote: > On Wed, 23 Sep 2015 19:45:08 +0100 > David Woodhouse <dwmw2 at infradead.org> wrote: > > > Commit 7d82410950aa ("virtio: add explicit big-endian support to memory > > accessors") accidentally changed the virtio_net header used by > > AF_PACKET with PACKET_VNET_HDR from host-endian to big-endian. > > > > Hi David, > > Oops my bad... I obviously overlooked this one when adding cross-endian > support. > > > Since virtio_legacy_is_little_endian() is a very long identifier, > > define a VIO_LE macro and...

...on the receiving path. Cc: Rolf Neugebauer <rolf.neugebauer at docker.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/macvtap.c | 2 +- drivers/net/tun.c | 2 +- drivers/net/virtio_net.c | 2 +- include/linux/virtio_net.h | 6 +++++- net/packet/af_packet.c | 4 ++-- 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 5c26653..4026185 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -825,7 +825,7 @@ static ssize_t macvtap_put_user(struct macvtap_queue *q, return...

...on the receiving path. Cc: Rolf Neugebauer <rolf.neugebauer at docker.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/macvtap.c | 2 +- drivers/net/tun.c | 2 +- drivers/net/virtio_net.c | 2 +- include/linux/virtio_net.h | 6 +++++- net/packet/af_packet.c | 4 ++-- 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 5c26653..4026185 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -825,7 +825,7 @@ static ssize_t macvtap_put_user(struct macvtap_queue *q, return...

...is disabled, 20% or even higher improvement could be measured by netperf. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/macvtap.c | 2 ++ drivers/net/tun.c | 2 ++ drivers/net/virtio_net.c | 2 ++ include/linux/virtio_net.h | 1 + net/packet/af_packet.c | 2 ++ 5 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 6696e56..ecee0fe 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -508,6 +508,8 @@ static int macvtap_skb_to_vnet_hdr(const struct sk_buff *skb, vn...

...is disabled, 20% or even higher improvement could be measured by netperf. Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/macvtap.c | 2 ++ drivers/net/tun.c | 2 ++ drivers/net/virtio_net.c | 2 ++ include/linux/virtio_net.h | 1 + net/packet/af_packet.c | 2 ++ 5 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 6696e56..ecee0fe 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -508,6 +508,8 @@ static int macvtap_skb_to_vnet_hdr(const struct sk_buff *skb, vn...

Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The issue we are solving is that on linux guests, some apps that use recvmsg with AF_PACKET sockets, don't know how to handle CHECKSUM_PARTIAL; The interface to return the relevant information was added in 8dc4194474159660d7f37c495e3fc3f10d0db8cc, and older userspace does not use it. One important user of recvmsg with AF_PACKET is dhclient, so we add a work-around just for DHCP. Don&...

Userspace virtio server has the following hack so guests rely on it, and we have to replicate it, too: Use port number to detect incoming IPv4 DHCP response packets, and fill in the checksum for these. The issue we are solving is that on linux guests, some apps that use recvmsg with AF_PACKET sockets, don't know how to handle CHECKSUM_PARTIAL; The interface to return the relevant information was added in 8dc4194474159660d7f37c495e3fc3f10d0db8cc, and older userspace does not use it. One important user of recvmsg with AF_PACKET is dhclient, so we add a work-around just for DHCP. Don&...

...herbert@gondolin) (gcc version 2.95.4 20011002 (Debian prerelease)) #1 Tue Jan 14 00:29:06 EST 2003 [5.] Output of Oops.. message (if applicable) with symbolic information resolved (see Documentation/oops-tracing.txt) kernel BUG at transaction.c:1225! invalid operand: 0000 CPU: 0 EIP: 0010:[af_packet:__insmod_af_packet_O/lib/modules/2.4.20-k7/kernel/net/packe+-42310711/96] Tainted: P EFLAGS: 00010282 eax: 00000062 ebx: c8e416c0 ecx: c6caa000 edx: ef84c800 esi: ecce1400 edi: c2718440 ebp: ebede940 esp: c6cabcec ds: 0018 es: 0018 ss: 0018 Process dpkg (pid: 5724, stackpage=c6c...

...> }; > >> > >> #if BITS_PER_LONG > 32 > > > > So this implies anything getting GSO packets e.g. > > from userspace now needs to check IP version to > > set GSO type correctly. > > > > I think you missed some places that do this, e.g. af_packet > > sockets. > > > > I looked at af_packet sockets and they set this only in the event > vnet header has been used with a GSO type. In this case, the user > already knows the the type. Imagine you are receiving a packet: if (vnet_hdr.gso_type != VIRTIO_N...

...> }; > >> > >> #if BITS_PER_LONG > 32 > > > > So this implies anything getting GSO packets e.g. > > from userspace now needs to check IP version to > > set GSO type correctly. > > > > I think you missed some places that do this, e.g. af_packet > > sockets. > > > > I looked at af_packet sockets and they set this only in the event > vnet header has been used with a GSO type. In this case, the user > already knows the the type. Imagine you are receiving a packet: if (vnet_hdr.gso_type != VIRTIO_N...

On Fri, Apr 14, 2017 at 05:42:58AM +0300, Michael S. Tsirkin wrote: > Hi all, I wanted to raise the question of similarities between virtio > and new zero copy af_packet interfaces. > > First I would like to mention that virtio device development isn't spec > limited - spec is there to help interoperability and add peace of mind > for people worried about IPR. > > So I tend to accept patches without requiring people write it up in the > s...

On Fri, Apr 14, 2017 at 05:42:58AM +0300, Michael S. Tsirkin wrote: > Hi all, I wanted to raise the question of similarities between virtio > and new zero copy af_packet interfaces. > > First I would like to mention that virtio device development isn't spec > limited - spec is there to help interoperability and add peace of mind > for people worried about IPR. > > So I tend to accept patches without requiring people write it up in the > s...

From: David Woodhouse <dwmw2 at infradead.org> Date: Wed, 23 Sep 2015 15:44:30 +0100 > +#define VIO_LE virtio_legacy_is_little_endian() When you define a shorthand macro, the defines to a function call, make the macro have parenthesis too.

On Tue, Aug 01, 2017 at 08:54:27PM -0700, Steven Luong wrote: > * Descriptor ring: > > Guest adds descriptors with unique index values and DESC_HW set in flags. > Host overwrites used descriptors with correct len, index, and DESC_HW > clear.? Flags are always set/cleared last. > > #define DESC_HW 0x0080 > > struct desc { > ? ? ? ? __le64

From: David Woodhouse <dwmw2 at infradead.org> Date: Wed, 23 Sep 2015 15:44:30 +0100 > +#define VIO_LE virtio_legacy_is_little_endian() When you define a shorthand macro, the defines to a function call, make the macro have parenthesis too.