search for: af_hint

...-r1.1.1.1 socket.c --- socket.c 4 Mar 2003 10:29:09 -0000 1.1.1.1 +++ socket.c 4 Mar 2003 10:55:34 -0000 @@ -290,59 +290,30 @@ * @param bind_address Local address to bind, or NULL to allow it to * default. **/ -static int open_socket_in(int type, int port, const char *bind_address, - int af_hint) +static int open_socket_in(struct addrinfo *resp) { int one=1; int s; - struct addrinfo hints, *all_ai, *resp; - char portbuf[10]; - int error; - - memset(&hints, 0, sizeof(hints)); - hints.ai_family = af_hint; - hints.ai_socktype = type; - hints.ai_flags = AI_PASSIVE; - snprintf(portbuf,...

...to also permit EINVAL. Question for IPv6 experts: why check the errno code at all? Why not just loop through any time socket() returns -1? The second problem is that even if rsync is compiled with --disable-ipv6, on Linux it still attempts to open an IPv6 socket. This is because the global_opts.af_hint variable is initialized to 0, when it should be initialized to AF_INET to tell getaddrinfo() to prefer IPv4. This brings up a disadvantage with the new global_opts way of specifying global variables; by default the whole structure is now initialized to zero and there's no easy way to specify n...

On 14 Dec 2001, dwd@samba.org wrote: > open_socket_in was attempting to try all the protocols returned from > getaddrinfo(), but only if a corresponding call to socket() returned one of > three *NOSUPPORT errno codes. A Redhat 6.2 system was observed returning > EINVAL instead so it never went on to try IPv4. This update adds EINVAL to > the list. Question: why not always

Hi, all -- Here's a small patch that gives better diagnostics on the daemon side if it fails to start up due to inability to create or bind the socket. Presently, it gives a log entry indicating that no sockets could be bound, but crucially does *not* have the system error message (i.e. errno) from the failed call, making it difficult or impossible to determine the problem. I do have a