Displaying 14 results from an estimated 14 matches for "adjust_endianness".
2015 Mar 11
4
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...0 but QEMU passes 0x0001 to KVM... This happens *again* because
> > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > default.
> >
> > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > to negate the one that is done in adjust_endianness(). Since this is not
> > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > whether the guest is bi-endian or not.
> >
> > Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> > Suggested-by: Michael Roth <mdroth at linux.vnet.ibm...
2015 Mar 11
4
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...0 but QEMU passes 0x0001 to KVM... This happens *again* because
> > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > default.
> >
> > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > to negate the one that is done in adjust_endianness(). Since this is not
> > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > whether the guest is bi-endian or not.
> >
> > Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> > Suggested-by: Michael Roth <mdroth at linux.vnet.ibm...
2015 Mar 11
2
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...e TX vring number (16-bit) is supposed to
be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
default.
This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
to negate the one that is done in adjust_endianness(). Since this is not
a hot path and we want to keep virtio-pci.o in common-obj, we don't care
whether the guest is bi-endian or not.
Reported-by: C?dric Le Goater <clg at fr.ibm.com>
Suggested-by: Michael Roth <mdroth at linux.vnet.ibm.com>
Signed-off-by: Greg Kurz <gkurz at lin...
2015 Mar 11
2
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...e TX vring number (16-bit) is supposed to
be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
default.
This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
to negate the one that is done in adjust_endianness(). Since this is not
a hot path and we want to keep virtio-pci.o in common-obj, we don't care
whether the guest is bi-endian or not.
Reported-by: C?dric Le Goater <clg at fr.ibm.com>
Suggested-by: Michael Roth <mdroth at linux.vnet.ibm.com>
Signed-off-by: Greg Kurz <gkurz at lin...
2015 Mar 12
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...to KVM... This happens *again* because
> > > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > > default.
> > >
> > > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > > to negate the one that is done in adjust_endianness(). Since this is not
> > > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > > whether the guest is bi-endian or not.
> > >
> > > Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> > > Suggested-by: Michael Roth <...
2015 Mar 12
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...to KVM... This happens *again* because
> > > QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> > > default.
> > >
> > > This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> > > to negate the one that is done in adjust_endianness(). Since this is not
> > > a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> > > whether the guest is bi-endian or not.
> > >
> > > Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> > > Suggested-by: Michael Roth <...
2015 Mar 11
1
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote:
> /* The host notifier will be swapped in adjust_endianness() according to the
> * target default endianness. We need to negate this swap if the device uses
> * an endianness that is not the default (ppc64le for example).
> */
>
> > > +static uint16_t cpu_to_host_notifier16(VirtIODevice *vdev, uint16_t val)
> > > +{
> &g...
2015 Mar 11
1
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote:
> /* The host notifier will be swapped in adjust_endianness() according to the
> * target default endianness. We need to negate this swap if the device uses
> * an endianness that is not the default (ppc64le for example).
> */
>
> > > +static uint16_t cpu_to_host_notifier16(VirtIODevice *vdev, uint16_t val)
> > > +{
> &g...
2015 Mar 11
0
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
On Thu, 12 Mar 2015 09:18:38 +1100
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote:
>
> > /* The host notifier will be swapped in adjust_endianness() according to the
> > * target default endianness. We need to negate this swap if the device uses
> > * an endianness that is not the default (ppc64le for example).
> > */
> >
> > > > +static uint16_t cpu_to_host_notifier16(VirtIODevice *vdev, uint16_t val)...
2015 Mar 12
1
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
On 12/03/2015 08:08, Michael S. Tsirkin wrote:
> But common header format is simple, it's always LE.
> It does not depend on target.
> To me this looks like a bug in memory_region_add_eventfd,
> it should do the right thing depending on device
> endian-ness.
I agree it seems to be a QEMU bug.
Paolo
2015 Mar 11
0
[Qemu-ppc] [PATCH] virtio-pci: fix host notifiers on bi-endian architectures
On Thu, 12 Mar 2015 09:18:38 +1100
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> On Wed, 2015-03-11 at 23:03 +0100, Greg Kurz wrote:
>
> > /* The host notifier will be swapped in adjust_endianness() according to the
> > * target default endianness. We need to negate this swap if the device uses
> > * an endianness that is not the default (ppc64le for example).
> > */
> >
> > > > +static uint16_t cpu_to_host_notifier16(VirtIODevice *vdev, uint16_t val)...
2015 Mar 12
1
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
On 12/03/2015 08:08, Michael S. Tsirkin wrote:
> But common header format is simple, it's always LE.
> It does not depend on target.
> To me this looks like a bug in memory_region_add_eventfd,
> it should do the right thing depending on device
> endian-ness.
I agree it seems to be a QEMU bug.
Paolo
2015 Mar 11
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...supposed to
> be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> default.
>
> This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> to negate the one that is done in adjust_endianness(). Since this is not
> a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> whether the guest is bi-endian or not.
>
> Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> Suggested-by: Michael Roth <mdroth at linux.vnet.ibm.com>
> Signed-off-...
2015 Mar 11
0
[PATCH] virtio-pci: fix host notifiers on bi-endian architectures
...supposed to
> be 0x0100 but QEMU passes 0x0001 to KVM... This happens *again* because
> QEMU still assumes powerpc is big endian (TARGET_WORDS_BIGENDIAN) by
> default.
>
> This patch adds an extra swap in virtio_pci_set_host_notifier_internal()
> to negate the one that is done in adjust_endianness(). Since this is not
> a hot path and we want to keep virtio-pci.o in common-obj, we don't care
> whether the guest is bi-endian or not.
>
> Reported-by: C?dric Le Goater <clg at fr.ibm.com>
> Suggested-by: Michael Roth <mdroth at linux.vnet.ibm.com>
> Signed-off-...