search for: aditr

...y. This in turn leads to a use after free bug. This issue > was discovered by Hangbin Liu using KASAN and syzkaller. > > Fixes: bc63dedb7d46 ("VMCI: resource object implementation") > Reported-by: Hangbin Liu <liuhangbin at gmail.com> > Reviewed-by: Adit Ranadive <aditr at vmware.com> > Reviewed-by: Vishnu Dasa <vdasa at vmware.com> > Signed-off-by: Jorgen Hansen <jhansen at vmware.com> > --- > drivers/misc/vmw_vmci/vmci_driver.c | 2 +- > drivers/misc/vmw_vmci/vmci_resource.c | 3 ++- > 2 files changed, 3 insertions(+), 2 delet...

...y. This in turn leads to a use after free bug. This issue > was discovered by Hangbin Liu using KASAN and syzkaller. > > Fixes: bc63dedb7d46 ("VMCI: resource object implementation") > Reported-by: Hangbin Liu <liuhangbin at gmail.com> > Reviewed-by: Adit Ranadive <aditr at vmware.com> > Reviewed-by: Vishnu Dasa <vdasa at vmware.com> > Signed-off-by: Jorgen Hansen <jhansen at vmware.com> > --- > drivers/misc/vmw_vmci/vmci_driver.c | 2 +- > drivers/misc/vmw_vmci/vmci_resource.c | 3 ++- > 2 files changed, 3 insertions(+), 2 delet...

...station using kernel version 4.4 and later. Testing: Ran vsock tests between guest and host, and verified that with this change, the host isn't calling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Aditya Sarwade <asarwade at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsoc...

...station using kernel version 4.4 and later. Testing: Ran vsock tests between guest and host, and verified that with this change, the host isn't calling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Aditya Sarwade <asarwade at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsoc...

If skb_recv_datagram returns an skb, we should ignore the err value returned. Otherwise, datagram receives will return EAGAIN when they have to wait for a datagram. Acked-by: Adit Ranadive <aditr at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 662bdd2..5621473 100644 --- a/net/vmw...

...rn leads to a use after free bug. This issue was discovered by Hangbin Liu using KASAN and syzkaller. Fixes: bc63dedb7d46 ("VMCI: resource object implementation") Reported-by: Hangbin Liu <liuhangbin at gmail.com<mailto:liuhangbin at gmail.com>> Reviewed-by: Adit Ranadive <aditr at vmware.com<mailto:aditr at vmware.com>> Reviewed-by: Vishnu Dasa <vdasa at vmware.com<mailto:vdasa at vmware.com>> Signed-off-by: Jorgen Hansen <jhansen at vmware.com<mailto:jhansen at vmware.com>> --- drivers/misc/vmw_vmci/vmci_driver.c | 2 +- drivers/misc/vmw...

If skb_recv_datagram returns an skb, we should ignore the err value returned. Otherwise, datagram receives will return EAGAIN when they have to wait for a datagram. Acked-by: Adit Ranadive <aditr at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c index 662bdd2..5621473 100644 --- a/net/vmw...

...lla wrote: > vmci_transport never allowed half-closed socket on the host side. > Since we want to have the same behaviour across all transports, we > add a section in the "Implementation notes". > > Cc: Jorgen Hansen <jhansen at vmware.com> > Cc: Adit Ranadive <aditr at vmware.com> > Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> > --- > net/vmw_vsock/af_vsock.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index 2ab43b2bba31..27df57c2024b 100644 &gt...

...an vsock tests between guest and host, and verified that with this change, the host isn't calling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. v2: Rebased on top of recent change to sk_state values Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Aditya Sarwade <asarwade at vmware.com> Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-)...

...an vsock tests between guest and host, and verified that with this change, the host isn't calling vsock_stream_has_data during detach. Ran mixedTest between guest and host using both guest and host as server. v2: Rebased on top of recent change to sk_state values Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Aditya Sarwade <asarwade at vmware.com> Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-)...

...ound to a remote address (as is the case for a bound socket not yet in the listening state). This change fixes this by using the src of the incoming packet as destination for the reset packet in this case. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Vishnu Dasa <vdasa at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- v1 -> v2: - Changed order of local variables net/vmw_vsock/vmci_transport.c | 67 +++++++++++++++++++++++++++++++----------- 1 file changed, 50 insertions(+),...

We are implementing a test suite for the VSOCK sockets and we discovered that vmci_transport never allowed half-closed socket on the host side. As Jorgen explained [1] this is due to the implementation of VMCI. Since we want to have the same behaviour across all transports, this series adds a section in the "Implementation notes" to exaplain this behaviour, and changes the

We are implementing a test suite for the VSOCK sockets and we discovered that vmci_transport never allowed half-closed socket on the host side. As Jorgen explained [1] this is due to the implementation of VMCI. Since we want to have the same behaviour across all transports, this series adds a section in the "Implementation notes" to exaplain this behaviour, and changes the

...eturn value on create and destroy. That may not be the case, so we may end up with the wrong refcount. Instead, destroy should check explicitly whether the doorbell is in the index table as an indicator of whether the guest code was active at create time. Reviewed-by: Adit Ranadive <aditr at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- drivers/misc/vmw_vmci/vmci_doorbell.c | 8 +++++++- drivers/misc/vmw_vmci/vmci_driver.c | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_doorbell.c b/drivers/mi...

On 3/11/19 3:09 PM, Vishnu DASA wrote: > No functional changes, cleanup only. > > Reviewed-by: Adit Ranadive <aditr at vmware.com> > Reviewed-by: Jorgen Hansen <jhansen at vmware.com> > Signed-off-by: Vishnu Dasa <vdasa at vmware.com> > --- > include/linux/vmw_vmci_defs.h | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > Now this he...

vmci_transport never allowed half-closed socket on the host side. Since we want to have the same behaviour across all transports, we add a section in the "Implementation notes". Cc: Jorgen Hansen <jhansen at vmware.com> Cc: Adit Ranadive <aditr at vmware.com> Signed-off-by: Stefano Garzarella <sgarzare at redhat.com> --- net/vmw_vsock/af_vsock.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 2ab43b2bba31..27df57c2024b 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/n...

...eturn value on create and destroy. That may not be the case, so we may end up with the wrong refcount. Instead, destroy should check explicitly whether the doorbell is in the index table as an indicator of whether the guest code was active at create time. Reviewed-by: Adit Ranadive <aditr at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- drivers/misc/vmw_vmci/vmci_doorbell.c | 8 +++++++- drivers/misc/vmw_vmci/vmci_driver.c | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_doorbell.c b/drivers/mi...

...ound to a remote address (as is the case for a bound socket not yet in the listening state). This change fixes this by using the src of the incoming packet as destination for the reset packet in this case. Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Vishnu Dasa <vdasa at vmware.com> Signed-off-by: Jorgen Hansen <jhansen at vmware.com> --- net/vmw_vsock/vmci_transport.c | 67 +++++++++++++++++++++++++++++++----------- 1 file changed, 50 insertions(+), 17 deletions(-) diff --git a/net/vmw_vsock/vmci_t...

...bell handles that a VM can create in the hypervisor, and these handles are stored in a handle array. In this change, we introduce a mandatory max capacity for handle arrays/lists to avoid excessive memory usage. Signed-off-by: Vishnu Dasa <vdasa at vmware.com> Reviewed-by: Adit Ranadive <aditr at vmware.com> Reviewed-by: Jorgen Hansen <jhansen at vmware.com> --- drivers/misc/vmw_vmci/vmci_context.c | 80 +++++++++++++---------- drivers/misc/vmw_vmci/vmci_handle_array.c | 38 +++++++---- drivers/misc/vmw_vmci/vmci_handle_array.h | 29 +++++--- include/linux/vmw_vmci_defs.h...