search for: addtransition

...'ve regenerated the DFA table of Hexagon and everything is ok. >> Please review it. > > I had a few comments about the design change that you're introducing > with the patch: > > This patch adds multiple points of control for adding a transition: > there's now an addTransition() for DFA and another addTransition() for > State that populate different data structures. We shouldn't need both. I > am okay with transitions being folded into the State class if it results > in significant speedup in DFA generation. Yes, it gives a significant speedup to the emitte...

...ttached to states. > > I've regenerated the DFA table of Hexagon and everything is ok. > Please review it. I had a few comments about the design change that you're introducing with the patch: This patch adds multiple points of control for adding a transition: there's now an addTransition() for DFA and another addTransition() for State that populate different data structures. We shouldn't need both. I am okay with transitions being folded into the State class if it results in significant speedup in DFA generation. But then please remove the Transition mechanism for the DFA c...

...table of Hexagon and everything is ok. >>> Please review it. >> >> I had a few comments about the design change that you're introducing >> with the patch: >> >> This patch adds multiple points of control for adding a transition: >> there's now an addTransition() for DFA and another addTransition() for >> State that populate different data structures. We shouldn't need both. I >> am okay with transitions being folded into the State class if it results >> in significant speedup in DFA generation. > > Yes, it gives a significant...

...tate &S); + ~State(); // // canAddInsnClass - Returns true if an instruction of type InsnClass is a @@ -100,6 +104,15 @@ // which are possible from this state (PossibleStates). // void AddInsnClass(unsigned InsnClass, std::set<unsigned> &PossibleStates); + // + // addTransition - Add a transition from this state given the input InsnClass + // + void addTransition(unsigned InsnClass, Transition *T); + // + // hasTransition - Returns true if there is a transition from this state + // given the input InsnClass + // + bool hasTransition(unsigned InsnClass); }; } // E...

...ing is ok. >>>> Please review it. >>> >>> I had a few comments about the design change that you're introducing >>> with the patch: >>> >>> This patch adds multiple points of control for adding a transition: >>> there's now an addTransition() for DFA and another addTransition() for >>> State that populate different data structures. We shouldn't need both. I >>> am okay with transitions being folded into the State class if it results >>> in significant speedup in DFA generation. >> >> Yes, it...

Committed in r159281. -Anshu On 6/26/2012 3:04 AM, Ivan Llopard wrote: > Hi Anshu, > > I don't have commit access. It applies correctly on trunk, I've just > checked it. Could you please commit it? > > Ivan > > On 26/06/2012 04:44, adasgupt at codeaurora.org wrote: >> Hi Ivan, >> >> Sorry, I should have been more explicit in my last email. The

Hi Anshu, I don't have commit access. It applies correctly on trunk, I've just checked it. Could you please commit it? Ivan On 26/06/2012 04:44, adasgupt at codeaurora.org wrote: > Hi Ivan, > > Sorry, I should have been more explicit in my last email. The patch looks > good to me. Please check that it applies on trunk and go ahead and commit. > > Thanks > -Anshu