search for: addimplicitfiles

...having the YAML writer append a list of undefined atoms specified by the -u option, but the problem I have is each flavor has extra command line options for which it wants to create a DefinedAtom/UndefinedAtom. The flavor also may want to add extra linker internal files in the future. I prefer addImplicitFiles calling the reader to add more files, which means addFiles API moves to the reader. Thanks Shankar Easwaran On 8/28/2013 4:57 PM, Nick Kledzik wrote: > Shankar, > > The LinkingContext has a addImplictFiles() method that is supposed to call the Writer and give it a chance to add any im...

...inkingContext to create a file of UndefinedAtoms, and ELFLinkingContext could override that method to make weak undefines. Yes this will work for undefined atoms that need to be supported by all flavors. All the implicit files that are needed would be added to a vector of files in the inputGraph, addImplicitFiles would splice/prepend to the list of input files which it already has. Do you think that we still want the Writer::addFiles API, as this already covers the functionalities that is needed. Thanks Shankar Easwaran -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by th...

...append a list of undefined atoms specified by the -u option, but the problem I have is each flavor has extra command line options >> for which it wants to create a DefinedAtom/UndefinedAtom. The flavor also may want to add extra linker internal files in the future. >> >> I prefer addImplicitFiles calling the reader to add more files, which means addFiles API moves to the reader. > But won’t that fail too if you were using a YAML Reader and ELF Writer? Yeah :( > Since we are talking about files/atoms that are created because of command line options, perhaps the Driver should be creatin...

...YAML writer append a list of undefined atoms specified by the -u option, but the problem I have is each flavor has extra command line options > for which it wants to create a DefinedAtom/UndefinedAtom. The flavor also may want to add extra linker internal files in the future. > > I prefer addImplicitFiles calling the reader to add more files, which means addFiles API moves to the reader. But won’t that fail too if you were using a YAML Reader and ELF Writer? Since we are talking about files/atoms that are created because of command line options, perhaps the Driver should be creating the files/ato...

On Aug 28, 2013, at 4:24 PM, Shankar Easwaran <shankare at codeaurora.org> wrote: > Hi Nick, > >> Also for the case of -u, the Driver can make generic UndefinedAtoms. > ELF would want to treat the undefined symbols as a weak undefined symbols. So the driver cant create undefined atoms. > > Below is an example :- > > $cat 1.c > int _start() { return 0; }

Shankar, The LinkingContext has a addImplictFiles() method that is supposed to call the Writer and give it a chance to add any implicit files. Is the problem that the -u atoms are not attached to that implicit file? Or that the implicit file is not getting added? Or that this got lost in the transition from InputFiles to InputGraph? -Nick On Aug 28, 2013, at 2:44 PM, Shankar Easwaran

Hi, Right now, linker added symbols specified by the -u option do not endup in the output YAML file. This is because the target specific Writers dont get called, which creates the undefined atoms. I am in the process of adding more options and I would like the atoms created internally by the options available in the output YAML file. The options that I am trying to consider for the linker