search for: addfrag

...+ MCSymbolData *SymbolData); These aren't used, can you just remove them and add them when they actually are needed? > + MCSectionData *getSectionData(MCSection const *Section = 0); > + MCSymbolData *getSymbolData(MCSymbol const *Symbol); > + > + void AddFragment(MCFragment *Fragment); This function isn't necessary, fragments see below. > + void VisitSymbols(MCExpr const *Expr); > + > + void AddCommonSymbol(MCSymbol *Symbol, uint64_t Size, > + unsigned ByteAlignment, bool External); > + > // MCStreamer...

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

...- Watch out for case mismatches, i.e., #include "WinCoff.h" when the header is actually WinCOFF.h. - The patch doesn't have a consistent newline convention, it is a mix of DOS and Unix. - if( -> if ( - A [1] -> A[1] - Braces go on the same line as if/else. - Please use AddFragment instead of add_fragment, etc, and we tend to only use a leading lower case for accessor methods (getFoo) or trivial inlines functions, but not for methods which do work or have substantial side effects. - Please use complete sentences in comments, i.e. capitalized and ending with proper punct...

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------