search for: adddefinedsymbol

...cular linkage type will potentially have different behavior. For example, if you replace the DLLExportLinkage with ExternalLinkage+DLLExport_attribute, then codes that check hasExternalLinkage() will affect DLLExportLinkage symbols as well, which may or may not be the right thing. For example, LTO::addDefinedSymbol() currently does not handle dllimport/dllexport symbols, but if you change the semantics of ExternalLinkage to include dllimport/dllexport, then you could potentially have changed LTO (although, that is not necessarily a bad thing; you just need to check those places to make sure the compiler behav...

On 23.04.2013 19:10, Gao, Yunzhong wrote: > I missed the discussion when I implemented dllexport/dllimport for our local tree. I > essentially implemented your approach#1. I was trying to avoid the various > external_linkage + some_attribute approaches because it seems that external_linkage > would imply the external linkage without the dllimport/dllexport semantics, and there > may

...ls as well, which may or may not be the right thing. In this case everything should work fine. If the behavior will be changed, then we'll find some subtle bug hiding there for ages. normal dllexport'ed functions are essentially external functions with some additional semantics. > LTO::addDefinedSymbol() currently does not handle dllimport/dllexport > symbols, but if you change the semantics of ExternalLinkage to include > dllimport/dllexport, then you could potentially have changed LTO > (although, that is not necessarily a bad thing; you just need to check > those places to make sur...

...llvm::jitlink::Block&, unsigned long long, llvm::StringRef, unsigned long long, llvm::jitlink::Linkage, llvm::jitlink::Scope, bool, bool) at /Users/igorgomon/dev/third-party/llvm-project/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:366 #5 0x0000000106691e8c in llvm::jitlink::LinkGraph::addDefinedSymbol(llvm::jitlink::Block&, unsigned long long, llvm::StringRef, unsigned long long, llvm::jitlink::Linkage, llvm::jitlink::Scope, bool, bool) at /Users/igorgomon/dev/third-party/llvm-project/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:897 #6 0x000000010668f654 in llvm::jitlink::MachOLinkGr...

...; llvm::jitlink::Linkage, llvm::jitlink::Scope, bool, bool) at >>>>> /Users/igorgomon/dev/third-party/llvm-project/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:366 >>>>> >>>>> #5 0x0000000106691e8c in >>>>> llvm::jitlink::LinkGraph::addDefinedSymbol(llvm::jitlink::Block&, unsigned >>>>> long long, llvm::StringRef, unsigned long long, llvm::jitlink::Linkage, >>>>> llvm::jitlink::Scope, bool, bool) at >>>>> /Users/igorgomon/dev/third-party/llvm-project/llvm/include/llvm/ExecutionEngine/JITLink/JIT...

...g, > llvm::jitlink::Linkage, llvm::jitlink::Scope, bool, bool) at > /Users/igorgomon/dev/third-party/llvm-project/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:366 > >>>>>>> > >>>>>>> #5 0x0000000106691e8c in > llvm::jitlink::LinkGraph::addDefinedSymbol(llvm::jitlink::Block&, unsigned > long long, llvm::StringRef, unsigned long long, llvm::jitlink::Linkage, > llvm::jitlink::Scope, bool, bool) at > /Users/igorgomon/dev/third-party/llvm-project/llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:897 > >>>>>>> &gt...