search for: addcodeemitter

I forgot. Why do we have LLVMTargetMachine::addSimpleCodeEmitter() when we already have addCodeEmitter()? Thanks, Evan

Hi again, >From a .so, I'm doing the following: * I create an empty Module, declare some functions (from the main executable) and add a global mapping for them. * Then I create a jitted function that calls those global functions * and I call it. The JITted function segfaults because x86_64 JIT creates a call with 32bit relative address to rip, while the called function is outside reach.

Hi everyone, vmkit requires to know the size of a jitted method before emitting the method. This allows to allocate the correct size for the method. The attached patch creates this functionality when the flag SizedMemoryCode is on. In order to implement this functionality, i had to virtualize some MachineCodeEmitter functions. Is it OK to commit the patch? Thanks, Nicolas --------------

...&& PrintMachineCode) >> PM.add(createMachineFunctionPrinterPass(cerr)); >> + >> + if (SizedMemoryCode) { >> + SizeEmitter * SE = new SizeEmitter(&MCE); >> + addSimpleCodeEmitter(PM, Fast, false, *SE); >> + } >> >> + >> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >> >> PM.add(createCollectorMetadataDeleter()); >> Index: lib/CodeGen/SizeEmitter.cpp >> =================================================================== >> --- lib/CodeGen/SizeEmitter.cpp (revision 0) >> +++ lib/CodeGen/Size...

...> if (addPreEmitPass(PM, Fast) && PrintMachineCode) > PM.add(createMachineFunctionPrinterPass(cerr)); > + > + if (SizedMemoryCode) { > + SizeEmitter * SE = new SizeEmitter(&MCE); > + addSimpleCodeEmitter(PM, Fast, false, *SE); > + } > > + > addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); > > PM.add(createCollectorMetadataDeleter()); > Index: lib/CodeGen/SizeEmitter.cpp > =================================================================== > --- lib/CodeGen/SizeEmitter.cpp (revision 0) > +++ lib/CodeGen/SizeEmitter.cpp (revision 0)...

...>> PM.add(createMachineFunctionPrinterPass(cerr)); >>> + >>> + if (SizedMemoryCode) { >>> + SizeEmitter * SE = new SizeEmitter(&MCE); >>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>> + } >>> >>> + >>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>> >>> PM.add(createCollectorMetadataDeleter()); >>> Index: lib/CodeGen/SizeEmitter.cpp >>> =================================================================== >>> --- lib/CodeGen/SizeEmitter.cpp (revision 0) >>&g...

...FunctionPrinterPass(cerr)); >>>> + >>>> + if (SizedMemoryCode) { >>>> + SizeEmitter * SE = new SizeEmitter(&MCE); >>>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>>> + } >>>> >>>> + >>>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>>> >>>> PM.add(createCollectorMetadataDeleter()); >>>> Index: lib/CodeGen/SizeEmitter.cpp >>>> =================================================================== >>>> --- lib/CodeGen/SizeEmitter.cpp (re...

...>>>> + if (SizedMemoryCode) { >>>>>> + SizeEmitter * SE = new SizeEmitter(&MCE); >>>>>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>>>>> + } >>>>>> >>>>>> + >>>>>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>>>>> >>>>>> PM.add(createCollectorMetadataDeleter()); >>>>>> Index: lib/CodeGen/SizeEmitter.cpp >>>>>> = >>>>>> =============================================================...

...SizedMemoryCode) { >>>>>>> + SizeEmitter * SE = new SizeEmitter(&MCE); >>>>>>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>>>>>> + } >>>>>>> >>>>>>> + >>>>>>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>>>>>> >>>>>>> PM.add(createCollectorMetadataDeleter()); >>>>>>> Index: lib/CodeGen/SizeEmitter.cpp >>>>>>> = >>>>>>> === >>>>>>> ========...

...;>>>> + >>>>> + if (SizedMemoryCode) { >>>>> + SizeEmitter * SE = new SizeEmitter(&MCE); >>>>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>>>> + } >>>>> >>>>> + >>>>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>>>> >>>>> PM.add(createCollectorMetadataDeleter()); >>>>> Index: lib/CodeGen/SizeEmitter.cpp >>>>> = >>>>> ================================================================== >>>&g...

...gt;>>>>>> + SizeEmitter * SE = new SizeEmitter(&MCE); >>>>>>>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>>>>>>> + } >>>>>>>> >>>>>>>> + >>>>>>>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>>>>>>> >>>>>>>> PM.add(createCollectorMetadataDeleter()); >>>>>>>> Index: lib/CodeGen/SizeEmitter.cpp >>>>>>>> = >>>>>>>> === >>>>&...

...gt;> + SizeEmitter * SE = new SizeEmitter(&MCE); >>>>>>>>> + addSimpleCodeEmitter(PM, Fast, false, *SE); >>>>>>>>> + } >>>>>>>>> >>>>>>>>> + >>>>>>>>> addCodeEmitter(PM, Fast, PrintEmittedAsm, MCE); >>>>>>>>> >>>>>>>>> PM.add(createCollectorMetadataDeleter()); >>>>>>>>> Index: lib/CodeGen/SizeEmitter.cpp >>>>>>>>> = >>>>>>>>> ==...

...; + virtual const MipsInstrInfo *getInstrInfo() const { return InstrInfo.get(); } virtual const TargetFrameLowering *getFrameLowering() const @@ -73,6 +83,13 @@ public: // Pass Pipeline Configuration virtual TargetPassConfig *createPassConfig(PassManagerBase &PM); virtual bool addCodeEmitter(PassManagerBase &PM, JITCodeEmitter &JCE); + + // Set helper classes + void setHelperClassesMips16(); + + void setHelperClassesMipsSE(); + + }; /// MipsebTargetMachine - Mips32/64 big endian target machine. diff --git a/test/CodeGen/Mips/mips16_32_1.ll b/test/CodeGen/Mips/mips16_32_1...

On Thu, Mar 28, 2013 at 12:22 PM, Nadav Rotem <nrotem at apple.com> wrote: > IMHO the right way to handle target function attributes is to > re-initialize the target machine and TTI for every function (if the > attributes changed). Do you have another solution in mind ? I don't really understand this. TargetMachine and TTI may be quite expensive to initialize. Doing so for