search for: add_port

...virtconsole is removed (see a7a69ec0d8e4) >> >> To avoid the problem and to be symmetric, we could allocate all the buffers >> in init_vqs() as they are released in remove_vqs(), but it sounds like >> a waste of memory. >> >> Rather than that, this patch changes add_port() logic to only allocate the >> buffers if the in_vq has available free slots. >> >> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") >> Cc: mst at redhat.com >> Signed-off-by: Laurent Vivier <lvivier at redhat.com> >> --- >>...

...virtconsole is removed (see a7a69ec0d8e4) >> >> To avoid the problem and to be symmetric, we could allocate all the buffers >> in init_vqs() as they are released in remove_vqs(), but it sounds like >> a waste of memory. >> >> Rather than that, this patch changes add_port() logic to only allocate the >> buffers if the in_vq has available free slots. >> >> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") >> Cc: mst at redhat.com >> Signed-off-by: Laurent Vivier <lvivier at redhat.com> >> --- >>...

...the port is unplugged. They are only released when virtconsole is removed (see a7a69ec0d8e4) To avoid the problem and to be symmetric, we could allocate all the buffers in init_vqs() as they are released in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to only allocate the buffers if the in_vq has available free slots. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/char/virtio_console.c | 17 +++++++++++------ 1 file...

...the port is unplugged. They are only released when virtconsole is removed (see a7a69ec0d8e4) To avoid the problem and to be symmetric, we could allocate all the buffers in init_vqs() as they are released in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to only allocate the buffers if the in_vq has available free slots. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- drivers/char/virtio_console.c | 17 +++++++++++------ 1 file...

...7a69ec0d8e4) > >> > >> To avoid the problem and to be symmetric, we could allocate all the buffers > >> in init_vqs() as they are released in remove_vqs(), but it sounds like > >> a waste of memory. > >> > >> Rather than that, this patch changes add_port() logic to only allocate the > >> buffers if the in_vq has available free slots. > >> > >> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > >> Cc: mst at redhat.com > >> Signed-off-by: Laurent Vivier <lvivier at redhat.com&...

...the port is unplugged. They are only released when virtconsole is removed (see a7a69ec0d8e4) To avoid the problem and to be symmetric, we could allocate all the buffers in init_vqs() as they are released in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v2:...

...the port is unplugged. They are only released when virtconsole is removed (see a7a69ec0d8e4) To avoid the problem and to be symmetric, we could allocate all the buffers in init_vqs() as they are released in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v2:...

...are only released when virtconsole is removed (see a7a69ec0d8e4) > > To avoid the problem and to be symmetric, we could allocate all the buffers > in init_vqs() as they are released in remove_vqs(), but it sounds like > a waste of memory. > > Rather than that, this patch changes add_port() logic to ignore ENOSPC > error in fill_queue(), which means queue has already been filled. > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > Cc: mst at redhat.com > Cc: stable at vger.kernel.org > Signed-off-by: Laurent Vivier <lvivier at redha...

...are only released when virtconsole is removed (see a7a69ec0d8e4) > > To avoid the problem and to be symmetric, we could allocate all the buffers > in init_vqs() as they are released in remove_vqs(), but it sounds like > a waste of memory. > > Rather than that, this patch changes add_port() logic to only allocate the > buffers if the in_vq has available free slots. > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > Cc: mst at redhat.com > Signed-off-by: Laurent Vivier <lvivier at redhat.com> > --- > drivers/char/virtio_conso...

...eleased when virtconsole is removed (see a7a69ec0d8e4) > > To avoid the problem and to be symmetric, we could allocate all the > buffers > in init_vqs() as they are released in remove_vqs(), but it sounds > like > a waste of memory. > > Rather than that, this patch changes add_port() logic to ignore > ENOSPC > error in fill_queue(), which means queue has already been filled. > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > Cc: mst at redhat.com > Cc: stable at vger.kernel.org > Signed-off-by: Laurent Vivier <lvivier at...

...the port is unplugged. They are only released when virtconsole is removed (see a7a69ec0d8e4) To avoid the problem and to be symmetric, we could allocate all the buffers in init_vqs() as they are released in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v3:...

...the port is unplugged. They are only released when virtconsole is removed (see a7a69ec0d8e4) To avoid the problem and to be symmetric, we could allocate all the buffers in init_vqs() as they are released in remove_vqs(), but it sounds like a waste of memory. Rather than that, this patch changes add_port() logic to ignore ENOSPC error in fill_queue(), which means queue has already been filled. Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: mst at redhat.com Cc: stable at vger.kernel.org Signed-off-by: Laurent Vivier <lvivier at redhat.com> --- Notes: v3:...

...a7a69ec0d8e4) > > > > To avoid the problem and to be symmetric, we could allocate all the > > buffers > > in init_vqs() as they are released in remove_vqs(), but it sounds > > like > > a waste of memory. > > > > Rather than that, this patch changes add_port() logic to ignore > > ENOSPC > > error in fill_queue(), which means queue has already been filled. > > > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: mst at redhat.com > > Cc: stable at vger.kernel.org > > Signed-off...

...gt; > > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > > > index b585b47..6ebe8f6 100644 > > > --- a/drivers/char/virtio_console.c > > > +++ b/drivers/char/virtio_console.c > > > @@ -1449,6 +1449,8 @@ static int add_port(struct ports_device *portdev, u32 id) > > > spin_lock_init(&port->outvq_lock); > > > init_waitqueue_head(&port->waitqueue); > > > > > > + virtio_device_ready(portdev->vdev); > > > + > > > /* Fill the in_vq with buffers s...

...gt; > > > > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > > > index b585b47..6ebe8f6 100644 > > > --- a/drivers/char/virtio_console.c > > > +++ b/drivers/char/virtio_console.c > > > @@ -1449,6 +1449,8 @@ static int add_port(struct ports_device *portdev, u32 id) > > > spin_lock_init(&port->outvq_lock); > > > init_waitqueue_head(&port->waitqueue); > > > > > > + virtio_device_ready(portdev->vdev); > > > + > > > /* Fill the in_vq with buffers s...

...(see a7a69ec0d8e4) >>> >>> To avoid the problem and to be symmetric, we could allocate all the buffers >>> in init_vqs() as they are released in remove_vqs(), but it sounds like >>> a waste of memory. >>> >>> Rather than that, this patch changes add_port() logic to ignore ENOSPC >>> error in fill_queue(), which means queue has already been filled. >>> >>> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") >>> Cc: mst at redhat.com >>> Cc: stable at vger.kernel.org >>> Sig...

...sole is removed (see a7a69ec0d8e4) > > > > To avoid the problem and to be symmetric, we could allocate all the buffers > > in init_vqs() as they are released in remove_vqs(), but it sounds like > > a waste of memory. > > > > Rather than that, this patch changes add_port() logic to ignore ENOSPC > > error in fill_queue(), which means queue has already been filled. > > > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: mst at redhat.com > > Cc: stable at vger.kernel.org > > Signed-off-by: Laure...

...sole is removed (see a7a69ec0d8e4) > > > > To avoid the problem and to be symmetric, we could allocate all the buffers > > in init_vqs() as they are released in remove_vqs(), but it sounds like > > a waste of memory. > > > > Rather than that, this patch changes add_port() logic to ignore ENOSPC > > error in fill_queue(), which means queue has already been filled. > > > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: mst at redhat.com > > Cc: stable at vger.kernel.org > > Signed-off-by: Laure...

...tio_console.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index b585b47..6ebe8f6 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -1449,6 +1449,8 @@ static int add_port(struct ports_device *portdev, u32 id) > spin_lock_init(&port->outvq_lock); > init_waitqueue_head(&port->waitqueue); > > + virtio_device_ready(portdev->vdev); > + > /* Fill the in_vq with buffers so the host can send us data. */ > nr_added_bufs = fill_...

...tio_console.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c > index b585b47..6ebe8f6 100644 > --- a/drivers/char/virtio_console.c > +++ b/drivers/char/virtio_console.c > @@ -1449,6 +1449,8 @@ static int add_port(struct ports_device *portdev, u32 id) > spin_lock_init(&port->outvq_lock); > init_waitqueue_head(&port->waitqueue); > > + virtio_device_ready(portdev->vdev); > + > /* Fill the in_vq with buffers so the host can send us data. */ > nr_added_bufs = fill_...