search for: add_libvirt_dom

A hopefully cleaner implementation this time. It doesn't require any special insights into how libvirt-python is implemented. Instead, it requires a change to libvirt-python to add a .c_pointer() method: https://www.redhat.com/archives/libvir-list/2014-December/msg00615.html Rich.

Thank you, Rich, This was the issue indeed. export LIBGUESTFS_BACKEND=direct fixed it. The next step I tried was to integrate libguestfs in collectd virt plugin to collect this data automatically. In this case I'm having an unknown error in add_libvirt_dom() (same with add_domain) when it's invoking qemu-img to create overlay image. There is no difference between manual and service execution. I tried setting LIBGUESTFS_BACKEND to direct, libvirt, libvirt:qemu:///session with no success. Also tried using a different tmp dir just in case - nothing...

Since v3: - Fix labelling over overlays (see 6/6) - Tested it with a test program which simulates what virt-manager will do. See the attachment here: https://bugzilla.redhat.com/show_bug.cgi?id=1075164#c7 Rich.

This completes the implementation on the libguestfs side, allowing python-libvirt dom pointers to be passed to guestfs_add_libvirt_dom. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Rich.

...le.inc b/gobject/Makefile.inc index 7698c2a..149e4c6 100644 --- a/gobject/Makefile.inc +++ b/gobject/Makefile.inc @@ -53,6 +53,7 @@ guestfs_gobject_headers= \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ include/guestfs-gobject/optargs-add_libvirt_dom.h \ + include/guestfs-gobject/optargs-aug_transform.h \ include/guestfs-gobject/optargs-btrfs_filesystem_defragment.h \ include/guestfs-gobject/optargs-btrfs_filesystem_resize.h \ include/guestfs-gobject/optargs-btrfs_fsck.h \ @@ -143,6 +144,7 @@ guestfs_gobject_sources= \ src/optargs-...

...o.0 #15 0x00007ffff4784927 in guestfs_add_drive_opts_argv () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #16 0x00007ffff48128e0 in ?? () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #17 0x00007ffff4813cd6 in ?? () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #18 0x00007ffff47ab2c3 in guestfs_add_libvirt_dom_argv () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #19 0x00007ffff4812cf6 in ?? () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #20 0x00007ffff4760368 in guestfs_add_domain_argv () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #21 0x00007ffff47dfc38 in guestfs_add_domain_va () from /usr/lib/...

Hello, I have a simple C program that uses libguestfs to extract info about disk usage from a libvirt domain. It works when ran manually as root, but fails when started as a systemd service. I'm attaching the service file, source code and verbose logs from both the successful manual run and from the service journal. SELinix is disabled. Error messages: libguestfs:

This is only lightly tested at the moment. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Note this is not a complete fix. At least one more libguestfs patch is required (to implement virDomainPtr in the python bindings). Plus a virt-manager patch. Rich.

...respectively. I've tried to avoid long names like 'physicalblocksize' while keeping readability and semantic. - Do we want to add the same optional parameters to 'add_drive_scratch' API method? I think it would be nice but it is up to you. - What about 'add_dom', 'add_libvirt_dom' API methods? Should they also handle 'blokio' tag in domain XML and act respectively? - Anything else I didn't spot yet? - Do we want guestfish to accept physical/logical block size per drive from command line? - What about other virt tools like virt-df, virt-cat and so on? Sorry...

...If we only have one, we can use "blocksize". But it does require us to answer the previous one. > - Do we want to add the same optional parameters to 'add_drive_scratch' > API method? I think it would be nice but it is up to you. It should also be added to add_domain and add_libvirt_dom (note all the APIs which have 'discard' and 'copyonread' already). It could be added to add_drive_scratch, I guess. However it doesn't seem very useful for scratch drives (why create a scratch drive with 4K sectors which will be thrown away in the end?) > - What about '...

...lock_size and attach disk to libguestfs with physical_block_size == logical_block_size. > > - Do we want to add the same optional parameters to 'add_drive_scratch' > > API method? I think it would be nice but it is up to you. > > It should also be added to add_domain and add_libvirt_dom (note all > the APIs which have 'discard' and 'copyonread' already). Yeah, already did that. > It could be added to add_drive_scratch, I guess. However it doesn't > seem very useful for scratch drives (why create a scratch drive with > 4K sectors which will be thr...

..., Peter Dimitrov wrote: > Thank you, Rich, > This was the issue indeed. export LIBGUESTFS_BACKEND=direct fixed it. > > The next step I tried was to integrate libguestfs in collectd virt plugin > to collect this data automatically. > In this case I'm having an unknown error in add_libvirt_dom() (same with > add_domain) when it's invoking qemu-img to create overlay image. > > There is no difference between manual and service execution. > I tried setting LIBGUESTFS_BACKEND to direct, > libvirt, libvirt:qemu:///session with no success. > Also tried using a different...

...uestfs") - before = check_output (["ls", "-Z", self.filename]) - print ("disk label = %s" % before) - - # Now see if we can open the domain with libguestfs without - # disturbing the label. - g = guestfs.GuestFS () - r = g.add_libvirt_dom (dom, readonly = 1) - self.assertEqual (r, 1) - g.launch () - - print ("after starting libguestfs") - after = check_output (["ls", "-Z", self.filename]) - print ("disk label = %s" % after) - - self.assertEqual (before...

...(["ls", "-Z", filename]) -print "disk label = %s" % before +print ("disk label = %s" % before) # Now see if we can open the domain with libguestfs without # disturbing the label. @@ -101,9 +101,9 @@ if r != 1: raise "unexpected return value from add_libvirt_dom (%d)" % r g.launch () -print "after starting libguestfs" +print ("after starting libguestfs") after = check_output (["ls", "-Z", filename]) -print "disk label = %s" % after +print ("disk label = %s" % after) if before != after:...

...> Thank you, Rich, > > This was the issue indeed. export LIBGUESTFS_BACKEND=direct fixed it. > > > > The next step I tried was to integrate libguestfs in collectd virt plugin > > to collect this data automatically. > > In this case I'm having an unknown error in add_libvirt_dom() (same with > > add_domain) when it's invoking qemu-img to create overlay image. > > > > There is no difference between manual and service execution. > > I tried setting LIBGUESTFS_BACKEND to direct, > > libvirt, libvirt:qemu:///session with no success. > >...

Hi, This series adds new APIs to support btrfs scrub, balance, rescue and inspect. Some of them don't have tests because: - btrfs_scrub and btrfs_balance completes too early before we can test btrfs_scrub_cancel, btrfs_scrub_resume, btrfs_scrub_status, btrfs_balance_pause, btrfs_balance_cancel, btrfs_balance_resume and btrfs_balance_status. - can't

Hi, this series cleans up the Python sources, either static or generated, including also tests, to make them PEP 8 compliant; see https://www.python.org/dev/peps/pep-0008/ and tools like pep8. Almost all the issues reported by pep8 are fixed, reducing the issues from 3818 to 7. The changes should have no effect on the actual code, while it will help Python users with consistency with other

...sical and logical block size will be set to the same value. In this patch one more optional parameter 'blocksize' is added to add_drive_opts API method. Valid values are 512 and 4096. add_drive_scratch has the same optional parameter for a consistency and testing purpose. add-domain and add_libvirt_dom will pass logical_block_size value from libvirt XML to add_drive_opts method. --- generator/actions_core.ml | 26 +++++- lib/drives.c | 38 ++++++++- lib/guestfs-internal.h | 1 + lib/launch-direct.c...

...thus we will get current behaviour. This might be used in command line tools like guestfish, virt-df and so on to reset blocksize value to a beckend-default value (similar to --format option). add_drive_scratch has the same optional parameter for a consistency and testing purpose. add-domain and add_libvirt_dom will pass logical_block_size value from libvirt XML to add_drive_opts method. --- generator/actions_core.ml | 38 ++++++++- lib/drives.c | 38 ++++++++- lib/guestfs-internal.h | 1 + lib/launch-direct.c...

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.