Displaying 2 results from an estimated 2 matches for "add_fragment".
2010 Jun 16
0
[LLVMdev] Win32 COFF Support
...smatches, i.e., #include "WinCoff.h" when the
header is actually WinCOFF.h.
- The patch doesn't have a consistent newline convention, it is a
mix of DOS and Unix.
- if( -> if (
- A [1] -> A[1]
- Braces go on the same line as if/else.
- Please use AddFragment instead of add_fragment, etc, and we tend
to only use a leading lower case for accessor methods (getFoo) or
trivial inlines functions, but not for methods which do work or have
substantial side effects.
- Please use complete sentences in comments, i.e. capitalized and
ending with proper punctuation.
- Please don't...
2010 Jun 15
4
[LLVMdev] Win32 COFF Support
I have updated my patch based on Chris'es feedback. I removed the
dbgout_calls macro, but left others in place for now. If there are no
objections, I would like to commit this tomorrow evening (~7PM GMT-7). I
have compiled and tested it on MSVC, with Michaels testing code and it looks
good. Once this is committed, Michaels patch can be applied.
-Nathan
-------------- next part --------------