search for: add_firstboot_script

This patchset attempts to address a number of shortcomings in the firstboot infrastructure I came across while working with v2v conversion of various Windows VMs. Roman Kagan (4): firstboot: consolidate line ending conversion firstboot: enhance firstboot driver script for Windows firstboot: make script naming descriptive convert_windows: split firstboot into steps

...t fb = Buffer.create 1024 in - bprintf fb "@echo off\n"; + configure_rhev_apt (); + unconfigure_xenpv () - configure_rhev_apt fb; - unconfigure_xenpv fb; - - (* Write the completed script to the guest. *) - let firstboot_script = Buffer.contents fb in - Firstboot.add_firstboot_script g inspect.i_root "firstboot" firstboot_script - - and configure_rhev_apt fb = + and configure_rhev_apt () = (* Configure RHEV-APT (the RHEV guest agent). However if it doesn't * exist just warn about it and continue. *) @@ -159,22 +152,30 @@ let convert ~verbose ~k...

...igure_rhev_apt (); - unconfigure_xenpv () + unconfigure_xenpv (); + unconfigure_prltools () and configure_rhev_apt () = (* Configure RHEV-APT (the RHEV guest agent). However if it doesn't @@ -203,6 +257,23 @@ echo uninstalling Xen PV driver " uninst in Firstboot.add_firstboot_script g inspect.i_root "uninstall Xen PV" fb_script + + and unconfigure_prltools () = + List.iter ( + fun uninst -> + let fb_script = "\ +@echo off + +echo uninstalling Parallels guest tools +" ^ uninst ^ +(* ERROR_SUCCESS_REBOOT_REQUIRED == 3010 is OK too...

...xe"; (* XXX *) + g#upload tool_path "/rhev-apt.exe"; (* XXX *) - let fb_script = "\ + let fb_script = "\ @echo off echo installing rhev-apt @@ -233,8 +241,38 @@ echo installing rhev-apt echo starting rhev-apt net start rhev-apt " in - Firstboot.add_firstboot_script g inspect.i_root - "configure rhev-apt" fb_script + Firstboot.add_firstboot_script g inspect.i_root + "configure rhev-apt" fb_script + + and configure_vmdp tool_path = + (* Configure VMDP if possible *) + g#upload tool_path "/vmdp.exe"; + + let...

...t doesn't * exist just warn about it and continue. *) - match rhev_apt_exe with + match installer with | None -> () | Some rhev_apt_exe -> g#upload rhev_apt_exe "/rhev-apt.exe"; (* XXX *) @@ -236,6 +250,39 @@ net start rhev-apt Firstboot.add_firstboot_script g inspect.i_root "configure rhev-apt" fb_script + and configure_vmdp () = + (* Configure VMDP if possible *) + match installer with + | None -> () + | Some vmdp_exe -> + g#upload vmdp_exe "/vmdp.exe"; + + let fb_script = "\ +echo V2V...

...+ ) else + warning (f_"QEMU Guest Agent MSI not found on tools ISO/directory. You may want to install the guest agent manually after conversion."); + unconfigure_xenpv (); unconfigure_prltools (); unconfigure_vmwaretools () @@ -416,6 +423,18 @@ popd Firstboot.add_firstboot_script g inspect.i_root "finish vmdp setup" fb_recover_script + and configure_qemu_ga files = + List.iter ( + fun msi_path -> + let fb_script = "\ +echo Installing qemu-ga from " ^ msi_path ^ " +\"\\" ^ msi_path ^ "\" /qn /forcerestart /...

This is a replacement for previously posted patch "Delay firstboot scripts to some later time": https://www.redhat.com/archives/libguestfs/2019-November/msg00134.html Instead of delaying all the firstboot scripts we just delay the QEMU-GA installation that we know is problematic. I will possibly send a similar patch for RHEV-APT installation later. Tom?? Golembiovsk? (1): windows:

...et fb_script = "@echo off\n\ + \n\ + echo Wait for VirtIO drivers to be installed\n\ + %systemroot%\\Sysnative\\PnPutil -i -a \ + %systemroot%\\Drivers\\Virtio\\*.inf \ + " in + Firstboot.add_firstboot_script g inspect.i_root + "pnputil install drivers" fb_script; + and configure_wait_pnp tool_path = (* Prevent destructive interactions of firstboot with PnP. *) -- 2.31.1

....AddSeconds(120); schtasks.exe /Create /SC ONCE /ST $d.ToString('HH:mm') /SD $d.ToString('MM/dd/yyyy') /RU SYSTEM /TN Firstboot-qemu-ga /TR \\\"C:\\" ^ msi_path ^ " /forcerestart /qn /l+*vx C:\\" ^ msi_path ^ ".log\\\"\" " in Firstboot.add_firstboot_script g inspect.i_root ("install " ^ msi_path) fb_script; -- 2.25.0

...\n\ + echo Wait for VirtIO drivers to be installed\n\ + %systemroot%\\Sysnative\\PnPutil -i -a \ + %systemroot%\\Drivers\\Virtio\\*.inf >\"%~dpn0.log\" 2>&1\ + " in + Firstboot.add_firstboot_script g inspect.i_root + "pnputil install drivers" fb_script; + and configure_wait_pnp tool_path = (* Prevent destructive interactions of firstboot with PnP. *) -- 2.31.1

..."" in > + > + let fb_script = sprintf "\ > +@echo off > + > +echo Wait for PnP to complete > +\"%s\" >\"%%~dpn0.log\" 2>&1 > +%s" (String.concat "\\" pnp_wait_path) reg_restore_str in > + > + Firstboot.add_firstboot_script g inspect.i_root "wait pnp" fb_script; > + (* add_firstboot_script has created the path already *) > + g#upload pnp_wait_exe (g#case_sensitive_path > + (String.concat "/" pnp_wait_path)) > + > and configure_rhev_apt tool_p...

...uot;" in > + > + let fb_script = sprintf "\ > + at echo off > + > +echo Wait for PnP to complete > +\"%s\" >\"%%~dpn0.log\" 2>&1 > +%s" (String.concat "\\" pnp_wait_path) reg_restore_str in > + > + Firstboot.add_firstboot_script g inspect.i_root "wait pnp" fb_script; > + (* add_firstboot_script has created the path already *) > + g#upload pnp_wait_exe (g#case_sensitive_path > + (String.concat "/" pnp_wait_path)) > + > and configure_rhev_apt tool_p...

...et-date).AddSeconds(120); schtasks.exe /Create /SC ONCE /ST $d.ToString('HH:mm') /SD $d.ToString('MM/dd/yyyy') /RU SYSTEM /TN Firstboot-qemu-ga /TR \\\"C:\\%s /forcerestart /qn /l+*vx C:\\%s.log\\\"\" + " + msi_path msi_path msi_path in Firstboot.add_firstboot_script g inspect.i_root ("install " ^ msi_path) fb_script; ) files -- 2.25.0

In the TODO file there's a discussion of perhaps writing a new 'virt-customize' tool. I think it's probably better (or at any rate, easier) to just add this functionality into virt-sysprep. That is what this small series of patches aims to achieve. Note these are not very well tested at the moment. The first patch adds a generic and useful '--firstboot' flag. The

...+ echo Wait for VirtIO drivers to be installed\n\ > + %systemroot%\\Sysnative\\PnPutil -i -a \ > + %systemroot%\\Drivers\\Virtio\\*.inf >\"%~dpn0.log\" 2>&1\ > + " in > + Firstboot.add_firstboot_script g inspect.i_root > + "pnputil install drivers" fb_script; > + I'm not sure I'm really qualified to comment on this, since Windows is crazy. I guess the worst this can do is fail to run, but that won't stop anything else from happening. Note that firstboot scripts...

...VirtIO drivers to be installed\n\ > >> + %systemroot%\\Sysnative\\PnPutil -i -a \ > >> + %systemroot%\\Drivers\\Virtio\\*.inf >\"%~dpn0.log\" 2>&1\ > >> + " in > >> + Firstboot.add_firstboot_script g inspect.i_root > >> + "pnputil install drivers" fb_script; > >> + > > > > I'm not sure I'm really qualified to comment on this, since Windows is > > crazy. I guess the worst this can do is fail to run, but that won't > > stop...

...echo Wait for VirtIO drivers to be installed\n\ >> + %systemroot%\\Sysnative\\PnPutil -i -a \ >> + %systemroot%\\Drivers\\Virtio\\*.inf >\"%~dpn0.log\" 2>&1\ >> + " in >> + Firstboot.add_firstboot_script g inspect.i_root >> + "pnputil install drivers" fb_script; >> + > > I'm not sure I'm really qualified to comment on this, since Windows is > crazy. I guess the worst this can do is fail to run, but that won't > stop anything else from happening....

...i), the vm is unbootable + after conversion. The following function will try to make an uefi + fallback path if the vm being converted is an uefi setup. + *) + + let efi_fix_script = bootloader#fix_efi_boot () in + + if efi_fix_script <> "" then + Firstboot.add_firstboot_script g inspect.i_root + "fix uefi boot" efi_fix_script; + (* Delete blkid caches if they exist, since they will refer to the old * device names. blkid will rebuild these on demand. * diff --git a/v2v/linux_bootloaders.ml b/v2v/linux_bootloaders.ml index de3d107..cdab7b...

Wait for driver installations fired by the PnP manager to complete before running firstboot scripts. The first patch is a minor refactoring to pave the way for the second patch. The latter contains the bulk of the changes as well as the description of the idea. Roman Kagan (2): v2v:windows: factor out getting CurrentControlSet v2v:windows: prevent conflicts with PnP on firstboot --- v1

Hi there, Here is v3 of the remaining patches. Diff to v2: * Removed the patch related to QXL * Fixed the firstboot script with Roman's comments * Fixed ova with subfolders test * Handle MF-relative path in ova files * Fixed now unneeded match case as per Richard's comment Cédric Bosdonnat (3): customize: fix windows firstboot script v2v: add support for SUSE VMDP drivers v2v: