search for: add_fail

...his occurs rather than only return an errno to the user. In fact, ret is not set to an error value here, so it looks like this fails to create the device but returns success. Thanks, Alex > + goto class_id_fail; > + > ret = device_add(&mdev->dev); > if (ret) > goto add_fail; > @@ -340,6 +350,7 @@ int mdev_device_create(struct kobject *kobj, > > sysfs_fail: > device_del(&mdev->dev); > +class_id_fail: > add_fail: > parent->ops->remove(mdev); > ops_create_fail:

...-EINVAL; > >> + WARN(1, "class id must be specified for device %s\n", > >> + dev_name(dev)); > > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > > > Will fix. > > > > > >> + goto add_fail; > >> + } > >> + > >> ret = device_add(&mdev->dev); > >> if (ret) > >> goto add_fail; > >> diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c > >> index 0d3223aee20b..319d886ffaf7 100644 >...

...-EINVAL; > >> + WARN(1, "class id must be specified for device %s\n", > >> + dev_name(dev)); > > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > > > Will fix. > > > > > >> + goto add_fail; > >> + } > >> + > >> ret = device_add(&mdev->dev); > >> if (ret) > >> goto add_fail; > >> diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c > >> index 0d3223aee20b..319d886ffaf7 100644 >...

...(ret) > goto ops_create_fail; > > + if (!mdev->class_id) { > + ret = -EINVAL; > + WARN(1, "class id must be specified for device %s\n", > + dev_name(dev)); Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > + goto add_fail; > + } > + > ret = device_add(&mdev->dev); > if (ret) > goto add_fail; > diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c > index 0d3223aee20b..319d886ffaf7 100644 > --- a/drivers/vfio/mdev/mdev_driver.c > +++ b/drivers/vfio/mde...

...(ret) > goto ops_create_fail; > > + if (!mdev->class_id) { > + ret = -EINVAL; > + WARN(1, "class id must be specified for device %s\n", > + dev_name(dev)); Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > + goto add_fail; > + } > + > ret = device_add(&mdev->dev); > if (ret) > goto add_fail; > diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c > index 0d3223aee20b..319d886ffaf7 100644 > --- a/drivers/vfio/mdev/mdev_driver.c > +++ b/drivers/vfio/mde...

...gt; @@ -324,6 +331,9 @@ int mdev_device_create(struct kobject *kobj, >> if (ret) >> goto ops_create_fail; >> >> + if (!mdev->class_id) >> + goto class_id_fail; >> + >> ret = device_add(&mdev->dev); >> if (ret) >> goto add_fail; >> @@ -340,6 +350,7 @@ int mdev_device_create(struct kobject *kobj, >> >> sysfs_fail: >> device_del(&mdev->dev); >> +class_id_fail: > No need for new label. Just use add_fail label. Ok. > >> add_fail: >> parent->ops->remove...

...be specified for device %s\n", > > >> + dev_name(dev)); > > > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > > > > > > Will fix. > > > > > > > > > >> + goto add_fail; > > >> + } > > >> + > > >> ret = device_add(&mdev->dev); > > >> if (ret) > > >> goto add_fail; > > >> diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c > > >> index 0d3...

...v(struct mdev_device *mdev) { return &mdev->dev; @@ -324,6 +335,12 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) { + ret = -EINVAL; + dev_warn(dev, "mdev vendor driver failed to specify device class\n"); + goto add_fail; + } + ret = device_add(&mdev->dev); if (ret) goto add_fail; diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c index 0d3223aee20b..ed06433693e8 100644 --- a/drivers/vfio/mdev/mdev_driver.c +++ b/drivers/vfio/mdev/mdev_driver.c @@ -69,8 +69,33 @@ static int...

...v(struct mdev_device *mdev) { return &mdev->dev; @@ -324,6 +334,12 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) { + ret = -EINVAL; + dev_warn(dev, "mdev vendor driver failed to specify device class\n"); + goto add_fail; + } + ret = device_add(&mdev->dev); if (ret) goto add_fail; diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c index 0d3223aee20b..ed06433693e8 100644 --- a/drivers/vfio/mdev/mdev_driver.c +++ b/drivers/vfio/mdev/mdev_driver.c @@ -69,8 +69,33 @@ static int...

...list of registered parent devices. * Returns a negative value on error, otherwise 0. @@ -324,6 +331,9 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) + goto class_id_fail; + ret = device_add(&mdev->dev); if (ret) goto add_fail; @@ -340,6 +350,7 @@ int mdev_device_create(struct kobject *kobj, sysfs_fail: device_del(&mdev->dev); +class_id_fail: add_fail: parent->ops->remove(mdev); ops_create_fail: diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c index 0d3223aee20b..b7c40c...

...* Returns a negative value on error, otherwise 0. @@ -324,6 +335,13 @@ int mdev_device_create(struct kobject *kobj, if (ret) goto ops_create_fail; + if (!mdev->class_id) { + ret = -EINVAL; + WARN(1, "class id must be specified for device %s\n", + dev_name(dev)); + goto add_fail; + } + ret = device_add(&mdev->dev); if (ret) goto add_fail; diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c index 0d3223aee20b..319d886ffaf7 100644 --- a/drivers/vfio/mdev/mdev_driver.c +++ b/drivers/vfio/mdev/mdev_driver.c @@ -69,8 +69,30 @@ static int...

...>> + if (!mdev->class_id) { >> + ret = -EINVAL; >> + WARN(1, "class id must be specified for device %s\n", >> + dev_name(dev)); > Nit, dev_warn(dev, "mdev vendor driver failed to specify device class\n"); Will fix. > >> + goto add_fail; >> + } >> + >> ret = device_add(&mdev->dev); >> if (ret) >> goto add_fail; >> diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c >> index 0d3223aee20b..319d886ffaf7 100644 >> --- a/drivers/vfio/mdev/mdev_d...

...&mdev->dev; > @@ -324,6 +334,12 @@ int mdev_device_create(struct kobject *kobj, > if (ret) > goto ops_create_fail; > > + if (!mdev->class_id) { > + ret = -EINVAL; > + dev_warn(dev, "mdev vendor driver failed to specify device class\n"); > + goto add_fail; > + } > + > ret = device_add(&mdev->dev); > if (ret) > goto add_fail; > diff --git a/drivers/vfio/mdev/mdev_driver.c b/drivers/vfio/mdev/mdev_driver.c > index 0d3223aee20b..ed06433693e8 100644 > --- a/drivers/vfio/mdev/mdev_driver.c > +++ b/drivers/vfio/mde...

Hi all: There are hardware that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver to

Hi all: There are hardware that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver to

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver

Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and register itself as a new kind of mdev driver. Then it provides a unified way for kernel virtio driver