search for: add_drive_scratch

Hi, This series fix two bad commit ids referenced in commit messages, by first reverting the two commits and then re-applying them with correct commit ids referenced. No big problem, but for clarity. Hu Tao (4): Revert "Update gobject/Makefile.inc and POTFILES" Revert "Update gobject/Makefile.inc and POTFILES" Update gobject/Makefile.inc and POTFILES Update

...0 libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 LIBGUESTFS_PATH=/share/CACHEDEV1_DATA/appliance LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1 PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/bin/X11:/usr/local/sbin:/usr/local/bin SELinux: sh: getenforce: command not found libguestfs: trace: add_drive_scratch 104857600 libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: disk_create "/tmp/libguestfsbaZQUg/scratch.1" "raw" 104857600 libguestfs: trace: disk_create = 0 libguestfs: trace: add_drive "/tmp/libguestfsbaZQUg/scratch.1" &...

..." libguestfs: trace: set_backend = 0 libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 LIBGUESTFS_BACKEND=direct LIBGUESTFS_TRACE=1 LIBGUESTFS_DEBUG=1 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin SELinux: sh: 1: getenforce: not found libguestfs: trace: add_drive_scratch 104857600 libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: disk_create "/tmp/libguestfspqGts5/scratch.1" "raw" 104857600 libguestfs: trace: disk_create = 0 libguestfs: trace: add_drive "/tmp/libguestfspqGts5/scratch.1" &...

I download libguestfs from github and fetch to the *origin master*. I tried to build libguestfs in my own linux distro and I followd the http://libguestfs.org/guestfs-building.1.html#using-a-prebuilt-binary-appliance to replace with supermin I download the appliance-1.30.1.tar.xz and appliance-1.30.1.tar.xz.sig and extract the tarball to /home/user/appliance and export

...available only in guestfish. diff --git a/gobject/Makefile.inc b/gobject/Makefile.inc index 7698c2a..149e4c6 100644 --- a/gobject/Makefile.inc +++ b/gobject/Makefile.inc @@ -53,6 +53,7 @@ guestfs_gobject_headers= \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ include/guestfs-gobject/optargs-add_libvirt_dom.h \ + include/guestfs-gobject/optargs-aug_transform.h \ include/guestfs-gobject/optargs-btrfs_filesystem_defragment.h \ include/guestfs-gobject/optargs-btrfs_filesystem_resize.h \ include/guestfs-gobject/optargs-btrfs_fsck.h \ @@ -143...

...set_verbose = 0 > libguestfs: trace: set_verbose true > libguestfs: trace: set_verbose = 0 > LIBGUESTFS_DEBUG=1 > LIBGUESTFS_TRACE=1 > PATH=/usr/java/jdk1.8.0_151/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin > SELinux: Disabled > libguestfs: trace: add_drive_scratch 104857600 > libguestfs: trace: get_tmpdir > libguestfs: trace: get_tmpdir = "/tmp" > libguestfs: trace: disk_create "/tmp/libguestfsr2XJRP/scratch1.img" "raw" 104857600 > libguestfs: trace: disk_create = 0 > libguestfs: trace: add_drive "/tmp/libgue...

...ect/struct-version.h \ include/guestfs-gobject/struct-xattr.h \ include/guestfs-gobject/struct-xfsinfo.h \ + include/guestfs-gobject/struct-yara_detection.h \ include/guestfs-gobject/optargs-add_domain.h \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ @@ -140,6 +141,7 @@ guestfs_gobject_sources= \ src/struct-version.c \ src/struct-xattr.c \ src/struct-xfsinfo.c \ + src/struct-yara_detection.c \ src/optargs-add_domain.c \ src/optargs-add_drive.c \ src/optargs-add_drive_scratch.c \ diff --git a/java/Makefile.inc b/java/Makef...

...ect/struct-version.h \ include/guestfs-gobject/struct-xattr.h \ include/guestfs-gobject/struct-xfsinfo.h \ + include/guestfs-gobject/struct-yara_detection.h \ include/guestfs-gobject/optargs-add_domain.h \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ @@ -141,6 +142,7 @@ guestfs_gobject_sources= \ src/struct-version.c \ src/struct-xattr.c \ src/struct-xfsinfo.c \ + src/struct-yara_detection.c \ src/optargs-add_domain.c \ src/optargs-add_drive.c \ src/optargs-add_drive_scratch.c \ diff --git a/java/Makefile.inc b/java/Makef...

...ect/struct-version.h \ include/guestfs-gobject/struct-xattr.h \ include/guestfs-gobject/struct-xfsinfo.h \ + include/guestfs-gobject/struct-yara_detection.h \ include/guestfs-gobject/optargs-add_domain.h \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ @@ -141,6 +142,7 @@ guestfs_gobject_sources= \ src/struct-version.c \ src/struct-xattr.c \ src/struct-xfsinfo.c \ + src/struct-yara_detection.c \ src/optargs-add_domain.c \ src/optargs-add_drive.c \ src/optargs-add_drive_scratch.c \ diff --git a/java/Makefile.inc b/java/Makef...

...ect/struct-version.h \ include/guestfs-gobject/struct-xattr.h \ include/guestfs-gobject/struct-xfsinfo.h \ + include/guestfs-gobject/struct-yara_detection.h \ include/guestfs-gobject/optargs-add_domain.h \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ @@ -142,6 +143,7 @@ guestfs_gobject_sources= \ src/struct-version.c \ src/struct-xattr.c \ src/struct-xfsinfo.c \ + src/struct-yara_detection.c \ src/optargs-add_domain.c \ src/optargs-add_drive.c \ src/optargs-add_drive_scratch.c \ diff --git a/java/Makefile.inc b/java/Makef...

...+++ b/ruby/t/tc_100_launch.rb @@ -17,8 +17,8 @@ require File::join(File::dirname(__FILE__), 'test_helper') -class TestLoad < MiniTest::Unit::TestCase - def test_launch +class Test100Launch < MiniTest::Unit::TestCase + def test_100_launch g = Guestfs::Guestfs.new() g.add_drive_scratch(500*1024*1024) diff --git a/ruby/t/tc_410_close_event.rb b/ruby/t/tc_410_close_event.rb index be62b91..b77d44f 100644 --- a/ruby/t/tc_410_close_event.rb +++ b/ruby/t/tc_410_close_event.rb @@ -17,8 +17,8 @@ require File::join(File::dirname(__FILE__), 'test_helper') -class TestLoad <...

...set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1 PATH=/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/home/danielhb/.local/bin:/home/danielhb/bin SELinux: Enforcing libguestfs: trace: add_drive_scratch 104857600 libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: disk_create "/tmp/libguestfsgakCjw/scratch.1" "raw" 104857600 libguestfs: trace: disk_create = 0 libguestfs: trace: add_drive "/tmp/libguestfsgakCjw/scratch.1"...

...rbose = 0 LIBGUESTFS_TRACE=1 LIBVIRT_DEFAULT_URI=qemu:///system LIBGUESTFS_DEBUG=1 PATH=/home/farzad//.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin XDG_RUNTIME_DIR=/run/user/1000 SELinux: sh: 1: getenforce: not found libguestfs: trace: add_drive_scratch 104857600 libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: disk_create "/tmp/libguestfsf9YvJG/scratch1.img" "raw" 104857600 libguestfs: trace: disk_create = 0 libguestfs: trace: add_drive "/tmp/libguestfsf9YvJG/scratch1.img&q...

...t/struct-xfsinfo.h \ - include/guestfs-gobject/struct-utsname.h \ - include/guestfs-gobject/struct-hivex_node.h \ - include/guestfs-gobject/struct-hivex_value.h \ include/guestfs-gobject/optargs-add_domain.h \ include/guestfs-gobject/optargs-add_drive.h \ include/guestfs-gobject/optargs-add_drive_scratch.h \ @@ -100,26 +100,26 @@ guestfs_gobject_headers= \ guestfs_gobject_sources= \ src/session.c \ src/tristate.c \ + src/struct-application.c \ + src/struct-application2.c \ + src/struct-btrfssubvolume.c \ + src/struct-dirent.c \ + src/struct-hivex_node.c \ + src/struct-hivex_value.c \ +...

...size? - I'm not sure I've made a good choise for parameter names: 'pblocksize' and 'lblocksize' respectively. I've tried to avoid long names like 'physicalblocksize' while keeping readability and semantic. - Do we want to add the same optional parameters to 'add_drive_scratch' API method? I think it would be nice but it is up to you. - What about 'add_dom', 'add_libvirt_dom' API methods? Should they also handle 'blokio' tag in domain XML and act respectively? - Anything else I didn't spot yet? - Do we want guestfish to accept physical/l...

--- generator/ruby.ml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/generator/ruby.ml b/generator/ruby.ml index 97ccfdc..0f71ccc 100644 --- a/generator/ruby.ml +++ b/generator/ruby.ml @@ -404,15 +404,17 @@ event_callback_wrapper_wrapper (VALUE argvv) return Qnil; } +/* Callbacks aren't supposed to throw exceptions. We just print the + * exception on

...trace: set_verbose = 0 > > > LIBGUESTFS_BACKEND=direct > > > LIBGUESTFS_TRACE=1 > > > LIBGUESTFS_DEBUG=1 > > > PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin > > > SELinux: sh: 1: getenforce: not found > > > libguestfs: trace: add_drive_scratch 104857600 > > > libguestfs: trace: get_tmpdir > > > libguestfs: trace: get_tmpdir = "/tmp" > > > libguestfs: trace: disk_create "/tmp/libguestfspqGts5/scratch.1" "raw" > > > 104857600 > > > libguestfs: trace: disk_create = 0...

...respectively. I've tried to avoid long names like > 'physicalblocksize' while keeping readability and semantic. If we only have one, we can use "blocksize". But it does require us to answer the previous one. > - Do we want to add the same optional parameters to 'add_drive_scratch' > API method? I think it would be nice but it is up to you. It should also be added to add_domain and add_libvirt_dom (note all the APIs which have 'discard' and 'copyonread' already). It could be added to add_drive_scratch, I guess. However it doesn't seem very usef...

...et physical_block_size and logical_block_size to the same value. On the other hand, reading this values from libvirt XML we will take logical_block_size and attach disk to libguestfs with physical_block_size == logical_block_size. > > - Do we want to add the same optional parameters to 'add_drive_scratch' > > API method? I think it would be nice but it is up to you. > > It should also be added to add_domain and add_libvirt_dom (note all > the APIs which have 'discard' and 'copyonread' already). Yeah, already did that. > It could be added to add_drive_scratch...

...s: trace: set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 LIBGUESTFS_DEBUG=1 LIBGUESTFS_TRACE=1 PATH=/root/perl5/bin:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin SELinux: Disabled libguestfs: trace: add_drive_scratch 104857600 libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: disk_create "/tmp/libguestfs7oWVq5/scratch.1" "raw" 104857600 libguestfs: trace: disk_create = 0 libguestfs: trace: add_drive "/tmp/libguestfs7oWVq5/scratch.1" &...