search for: add_drive_ro

...urn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -------------- next part -------------- >From 004c0345d6fd9f141978f5163e053a67dba31cd0 Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at redhat.com> Date: Thu, 22 Jul 2010 14:39:36 +0100 Subject: [PATCH] Revert "add_drive_ro adds readonly=on option if available." (RHBZ#617200). Adding the readonly=on option is not so clever. This causes qemu to present the disk as read-only to the guest. (The expected behaviour of snapshots=on,readonly=on was that it would open the disk O_RDONLY but present a writable disk to t...

...rnative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora -------------- next part -------------- >From 26161a7a03edcad9cebf6908c052475765250ffb Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at redhat.com> Date: Tue, 16 Mar 2010 20:06:54 +0000 Subject: [PATCH] add_drive_ro adds readonly=on option if available. Change the add_drive_ro call so it adds the readonly=on option if qemu supports that. This just means that qemu will not try to open the drive with O_RDWR, and should not otherwise change the behaviour of qemu or libguestfs. (In particular, writes to the rea...

...sometimes* fail to virt-sysprep. The debug messages: libguestfs: trace: set_verbose true libguestfs: trace: set_verbose = 0 libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = python2 libguestfs: trace: set_program "lago" libguestfs: trace: set_program = 0 libguestfs: trace: add_drive_ro "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" libguestfs: trace: add_drive "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" "read...

...t; libguestfs: trace: set_verbose true > > libguestfs: trace: set_verbose = 0 > > libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = python2 > > libguestfs: trace: set_program "lago" > > libguestfs: trace: set_program = 0 > > libguestfs: trace: add_drive_ro > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > libguestfs: trace: add_drive > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > master/default/images/lago-basic-suite...

...h -a, then just add-cdrom and run - list-devices does not cause guestfsd to crash when sorting the list of devices (exposed by the test case in RHBZ#563450) - the result of list-devices now reflects the order images were added (RHBZ#563450) add_cdrom is still deprecated, but now in favour of add_drive_ro (instead of add_drive), with its documentation reflecting that. Add two small regression tests for the fixes described above. --- generator/actions.ml | 6 ++--- src/drives.c | 13 +--------- tests/regressions/Makefile.am | 2 ++ tests/regressions/rhbz563450.s...

...t; The debug messages: > libguestfs: trace: set_verbose true > libguestfs: trace: set_verbose = 0 > libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = python2 > libguestfs: trace: set_program "lago" > libguestfs: trace: set_program = 0 > libguestfs: trace: add_drive_ro > "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" > libguestfs: trace: add_drive > "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2&q...

Hello, First off, many thanks for libguestfs... very useful! I'm trying to run libguestfs as an RPC service by using a python daemon with the python libguestfs bindings. With this service I'm "centrally" editing VM images, and often running many GuestFS() on the same image file in a short amount of time to edit the image's contents. The problem I'm running across is

...-1; > > > > } > > > > - if (access (filename, F_OK) == -1) { > > - perrorf (g, "%s", filename); > > - return -1; > > - } > > - > > - return guestfs_config (g, "-cdrom", filename); > > + return guestfs__add_drive_ro (g, filename); > > > > } > > I don't think this implementation is quite right because it leaves the > [now] bogus check for ':' in the filename. guestfs_add_drive_ro can > handle ':' in the filename (because it creates an overlay): I see, I was being...

...gt; libguestfs: trace: set_verbose = 0 > > > > libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = > python2 > > > > libguestfs: trace: set_program "lago" > > > > libguestfs: trace: set_program = 0 > > > > libguestfs: trace: add_drive_ro > > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > > > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > > > libguestfs: trace: add_drive > > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- &gt...

...gt; > libguestfs: trace: set_verbose = 0 > > > > libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = python2 > > > > libguestfs: trace: set_program "lago" > > > > libguestfs: trace: set_program = 0 > > > > libguestfs: trace: add_drive_ro > > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > > > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > > > libguestfs: trace: add_drive > > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- &gt...

...1, [DeprecatedBy "add_drive_opts"], + ("add_cdrom", (RErr, [String "filename"], []), -1, [DeprecatedBy "add_drive_opts"; ConfigOnly], [], "add a CD-ROM disk image to examine", "\ @@ -185,7 +185,7 @@ should probably use C<guestfs_add_drive_ro> instead. =back"); - ("add_drive_ro", (RErr, [String "filename"], []), -1, [FishAlias "add-ro"], + ("add_drive_ro", (RErr, [String "filename"], []), -1, [FishAlias "add-ro"; ConfigOnly], [], "add a drive in snap...

..._verbose true > > > libguestfs: trace: set_verbose = 0 > > > libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = python2 > > > libguestfs: trace: set_program "lago" > > > libguestfs: trace: set_program = 0 > > > libguestfs: trace: add_drive_ro > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > > libguestfs: trace: add_drive > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > > master/defaul...

...> libguestfs: trace: set_verbose = 0 >>>>> libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = python2 >>>>> libguestfs: trace: set_program "lago" >>>>> libguestfs: trace: set_program = 0 >>>>> libguestfs: trace: add_drive_ro >>>>> "/home/ykaul/ovirt-system-tests/deployment-basic-suite- >>>> master/default/images/lago-basic-suite-master-host-0_root.qcow2" >>>>> libguestfs: trace: add_drive >>>>> "/home/ykaul/ovirt-system-tests/deployment-basic-suite...

...e: set_verbose = 0 > > > > > libguestfs: create: flags = 0, handle = 0x7f4600005dd0, program = > python2 > > > > > libguestfs: trace: set_program "lago" > > > > > libguestfs: trace: set_program = 0 > > > > > libguestfs: trace: add_drive_ro > > > > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > > > > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > > > > libguestfs: trace: add_drive > > > > > "/home/ykaul/ovirt-system-tests/deploym...

...ot;arch", None) fields) with Not_found -> - eprintf (f_"%s: no ‘arch’ entry for ‘%s’\n") prog n; - corrupt_file () in + if template then + try + let g = new Guestfs.guestfs () in + g#add_drive_ro file_uri; + g#launch (); + let roots = g#inspect_os () in + let nroots = Array.length roots in + if nroots <> 1 then ( + eprintf (f_"%s: no ‘arch’ entry for %s and failed to guess it\n") prog n; +...

...s"; + longdesc = "\ +Similar to \"launch\" call, but requires an integer as blocksize for disks. + +A call of \"launch_blocksize 512\" is equivalent of \"launch\" since the +default blocksize for qemu is 512." }; + { defaults with name = "add_drive_ro"; added = (1, 0, 38); style = RErr, [String (PlainString, "filename")], []; diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h index 75b8a5c..e9b7057 100644 --- a/lib/guestfs-internal.h +++ b/lib/guestfs-internal.h @@ -513,6 +513,9 @@ struct guestfs_h { /* Used by...

...dex.Arch (List.assoc ("arch", None) fields) with Not_found -> - eprintf (f_"%s: no ‘arch’ entry for ‘%s’\n") prog n; - corrupt_file () in + if template then + let g = new Guestfs.guestfs () in + g#add_drive_ro file_uri; + g#launch (); + let roots = g#inspect_os () in + let nroots = Array.length roots in + if nroots <> 1 then ( + eprintf (f_"%s: no ‘arch’ entry for %s and failed to guess it\n") prog n; +...

...t;arch", None) fields) with Not_found -> - eprintf (f_"%s: no ‘arch’ entry for ‘%s’\n") prog n; - corrupt_file () in + if template then + let g = open_guestfs ~identifier:"template" () in + g#add_drive_ro file_uri; + g#launch (); + let roots = g#inspect_os () in + let nroots = Array.length roots in + if nroots <> 1 then ( + eprintf (f_"%s: no ‘arch’ entry for %s and failed to guess it\n") prog n; +...

...;logical_block_size=\"blocksize\"> to qemu's C<-device> directive. The blocksize +must be a power of 2 between 512 and 32768, or else it will be ignored. + +The default is none, and qemu would assume a blocksize of 512. + +=back" }; { defaults with name = "add_drive_ro"; added = (1, 0, 38); diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h index 75b8a5c..090ba58 100644 --- a/lib/guestfs-internal.h +++ b/lib/guestfs-internal.h @@ -513,6 +513,9 @@ struct guestfs_h { /* Used by lib/info.c. -1 = not tested or error; else 0 or 1. */ int qemu_i...

...;; longdesc = "\ This kills the hypervisor. @@ -56,7 +56,7 @@ Do not call this. See: C<guestfs_shutdown> instead." }; { defaults with name = "add_cdrom"; added = (0, 0, 3); style = RErr, [String "filename"], []; - deprecated_by = Some "add_drive_ro"; config_only = true; + deprecated_by = Replaced_by "add_drive_ro"; config_only = true; blocking = false; shortdesc = "add a CD-ROM disk image to examine"; longdesc = "\ @@ -68,7 +68,7 @@ of C<guestfs_add_drive_ro>." }; { defaults with...