search for: add_drive

...gn/scan.c index 7ae8adf..26f77fd 100644 --- a/align/scan.c +++ b/align/scan.c @@ -236,7 +236,7 @@ main (int argc, char *argv[]) error (EXIT_FAILURE, 0, _("--uuid option cannot be used with -a or -d")); /* Add domains/drives from the command line (for a single guest). */ - add_drives (drvs, 'a'); + add_drives (drvs, 0); if (guestfs_launch (g) == -1) exit (EXIT_FAILURE); diff --git a/cat/cat.c b/cat/cat.c index 9fa8b4f..990fc90 100644 --- a/cat/cat.c +++ b/cat/cat.c @@ -236,7 +236,7 @@ main (int argc, char *argv[]) } /* Add drives, inspect and m...

...ng one. --- fish/test-add-uri.sh | 8 +++++++- fish/uri.c | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/fish/test-add-uri.sh b/fish/test-add-uri.sh index 07b68c4..0264829 100755 --- a/fish/test-add-uri.sh +++ b/fish/test-add-uri.sh @@ -49,14 +49,20 @@ grep -sq 'add_drive "disk" "protocol:gluster" "server:tcp:example.com"' test-add $VG guestfish -x -a nbd://example.com </dev/null >test-add-uri.out 2>&1 grep -sq 'add_drive "" "protocol:nbd" "server:tcp:example.com"' test-add-uri.ou...

...Ad additional checking for URIs, we have fish/test-add-uri.sh, which > fails with your patch. You might want to also add additional checks > with for query string http/https URIs. > The test is now failing on this case: + guestfish -x -a 'nbd:///export?socket=/sk' + grep -sq 'add_drive *"/export"* "protocol:nbd" "server:unix:/sk"' test-add-uri.out because I am now appending the query string as in: add_drive* "/export?socket=/sk"* "protocol:nbd" "server:unix:/sk" In which cases should the query string be appended an...

...xpand /dev/sda1 --LV-expand /dev/mapper/prop-home >> > prop-1.img prop-expand.img >> > command line: virt-resize -d --expand /dev/sda1 --LV-expand >> > /dev/mapper/prop-home prop-1.img prop-expand.img >> > Examining prop-1.img ... >> > libguestfs: trace: add_drive "prop-1.img" "readonly:true" >> > libguestfs: trace: add_drive = 0 >> > libguestfs: trace: add_drive "prop-expand.img" "readonly:false" >> > libguestfs: trace: add_drive = 0 >> > libguestfs: trace: launch >> > libg...

...eceiving the following message from virt-resize: # virt-resize -d --expand /dev/sda1 --LV-expand /dev/mapper/prop-home prop-1.img prop-expand.img command line: virt-resize -d --expand /dev/sda1 --LV-expand /dev/mapper/prop-home prop-1.img prop-expand.img Examining prop-1.img ... libguestfs: trace: add_drive "prop-1.img" "readonly:true" libguestfs: trace: add_drive = 0 libguestfs: trace: add_drive "prop-expand.img" "readonly:false" libguestfs: trace: add_drive = 0 libguestfs: trace: launch libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp&q...

...eceiving the following message from virt-resize: # virt-resize -d --expand /dev/sda1 --LV-expand /dev/mapper/prop-home prop-1.img prop-expand.img command line: virt-resize -d --expand /dev/sda1 --LV-expand /dev/mapper/prop-home prop-1.img prop-expand.img Examining prop-1.img ... libguestfs: trace: add_drive "prop-1.img" "readonly:true" libguestfs: trace: add_drive = 0 libguestfs: trace: add_drive "prop-expand.img" "readonly:false" libguestfs: trace: add_drive = 0 libguestfs: trace: launch libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp&q...

...home >> >> > prop-1.img prop-expand.img >> >> > command line: virt-resize -d --expand /dev/sda1 --LV-expand >> >> > /dev/mapper/prop-home prop-1.img prop-expand.img >> >> > Examining prop-1.img ... >> >> > libguestfs: trace: add_drive "prop-1.img" "readonly:true" >> >> > libguestfs: trace: add_drive = 0 >> >> > libguestfs: trace: add_drive "prop-expand.img" "readonly:false" >> >> > libguestfs: trace: add_drive = 0 >> >> > libguest...

...+++++- > fish/uri.c | 1 + > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/fish/test-add-uri.sh b/fish/test-add-uri.sh > index 07b68c4..0264829 100755 > --- a/fish/test-add-uri.sh > +++ b/fish/test-add-uri.sh > @@ -49,14 +49,20 @@ grep -sq 'add_drive "disk" "protocol:gluster" "server:tcp:example.com"' test-add > $VG guestfish -x -a nbd://example.com </dev/null >test-add-uri.out 2>&1 > grep -sq 'add_drive "" "protocol:nbd" "server:tcp:example.com"' test-...

...d a new optional argument "querystring". Another bug that I'm looking at (#1118305) is about setting initiator IQNs for iSCSI drives; a good solution IMHO would be add a new initiator-name parameter for this. Thinking more, I was realizing that keep adding more optional arguments to add_drive would make it a bit cluttered; for this, maybe a more flexible solution for this could be adding a single extra optional argument as hash-table (or list of "param=value") for all these rarely used parameters specific to different protocols. How would that look? Thanks, -- Pino Toscano

...ailing list. > > # virt-resize -d --expand /dev/sda1 --LV-expand /dev/mapper/prop-home > prop-1.img prop-expand.img > command line: virt-resize -d --expand /dev/sda1 --LV-expand > /dev/mapper/prop-home prop-1.img prop-expand.img > Examining prop-1.img ... > libguestfs: trace: add_drive "prop-1.img" "readonly:true" > libguestfs: trace: add_drive = 0 > libguestfs: trace: add_drive "prop-expand.img" "readonly:false" > libguestfs: trace: add_drive = 0 > libguestfs: trace: launch > libguestfs: trace: get_tmpdir > libguestfs: tr...

...; Another bug that I'm looking at (#1118305) is about setting initiator > > IQNs for iSCSI drives; a good solution IMHO would be add a new > > initiator-name parameter for this. > > > > Thinking more, I was realizing that keep adding more optional arguments > > to add_drive would make it a bit cluttered; for this, maybe a more > > flexible solution for this could be adding a single extra optional > > argument as hash-table (or list of "param=value") for all these > > rarely used parameters specific to different protocols. How would that &gt...

...run', you should see qemu complaining about something > like a 404 Error and the file not existing. After the unescape change the > above will start working. In this case, you can check in a simplier way: $ guestfish -x -a '/vhds/etc...' you'll see a "libguestfs: trace: add_drive ..." line contaning the actual add_drive call which guestfish will do to the library, and the parameters passed to it. Also, I'm thinking we should focus on making sure to have the proper query string for http(s) URIs to add_drive, we'll deal with the percent-encoding on the way. &gt...

...y to apply setfacl to share directory in domain controller My Problem is: I have one Samba AD [4.1] it work fine. I create common share folder in domain controller when try to apply ACL permission it show the following message [root at sambadc ~]# setfacl -m "u:RISHI\Administrator:rwx" /ADD_Drive/Samplesetfacl: Option -m: Invalid argument near character 3 After that i try to find usres id [root at sambadc ~]# id RISHI\\administrator id: RISHI\administrator: no such user But when i try the below command it shows the users [root at sambadc ~]# samba-tool user list AvijitGhosh RanjitRaman T...

.../fish/test-add-uri.sh index 756df997b..cb4d40199 100755 --- a/fish/test-add-uri.sh +++ b/fish/test-add-uri.sh @@ -26,6 +26,7 @@ skip_if_skipped rm -f test-add-uri.out rm -f test-add-uri.img +rm -f test-add-uri.sock $VG guestfish sparse test-add-uri.img 10M @@ -55,11 +56,17 @@ grep -sq 'add_drive "" "protocol:nbd" "server:tcp:example.com"' test-add-uri.out $VG guestfish -x -a nbd://example.com:3000 </dev/null >test-add-uri.out 2>&1 grep -sq 'add_drive "" "protocol:nbd" "server:tcp:example.com:3000"' test-...

...rystring". > > Another bug that I'm looking at (#1118305) is about setting initiator > IQNs for iSCSI drives; a good solution IMHO would be add a new > initiator-name parameter for this. > > Thinking more, I was realizing that keep adding more optional arguments > to add_drive would make it a bit cluttered; for this, maybe a more > flexible solution for this could be adding a single extra optional > argument as hash-table (or list of "param=value") for all these > rarely used parameters specific to different protocols. How would that > look? So tha...

...These still return raw device names (which still exist, even if the serial is used). Instead there is a new API called list-serial-names which returns a mapping of the serial names to raw device names. This patch is in preparation for hotplugging. The plan would be to remove the restriction that add_drive{_opts} has to be called before launch. If it's called after launch (ie. hotplugging) then we strongly recommend that users specify the serial option so the disk has a predictable name. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk...

Seeing `g.add_drive_opt :readonly => 1` allows one to imply that ensuring writable access to drive should happen via `g.add_drive_opt :readonly => 0`. However, the passed option value gets passed down to C according to Ruby Boolean semantics, that is, any value apart from `false` and `nil` will be true (see RTES...

...an pre-allocate your image in several vmdk files. But I have not bee able to mount that in guestfs. On file (e.g. guest.vmdk) is a text file pointing to all the other files (e.g. guest-f001.vmdk, guest-f002.vmdk,...). I tried the following scenarios without success: 1- just adding the base vmdk: add_drive guest.vmdk 2- adding all the files: add_drive guest-f001.vmdk add_drive guest-f002.vmdk ... It works if I merge all the files with vmware-vdiskmanager (something like: vmware-vdiskmanager -r guest.vmdk -t 0 guest-new.vmdk) Can I use guestfs without merging all the files in one image? Thanks, Th...

So far the failure of some test would have not reported a non-zero return value by run-tests.php. Since now all the PHP tests pass, we can ask for failures to be fatal, by exporting REPORT_EXIT_STATUS=1 for run-tests.php. --- php/run-php-tests.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh index 6f9ae10..e498987 100755 ---

...0644 > --- a/align/scan.c > +++ b/align/scan.c > @@ -236,7 +236,7 @@ main (int argc, char *argv[]) > error (EXIT_FAILURE, 0, _("--uuid option cannot be used with -a or -d")); > > /* Add domains/drives from the command line (for a single guest). */ > - add_drives (drvs, 'a'); > + add_drives (drvs, 0); This, and in all the other files, is using 0 as starting index. Since add_drives is a macro, I'd remove its drive_index parameter, and always pass 0 to add_drives_handle. The only change needed would be... > char > -add_drives_hand...